Ubuntu
ubuntu-ui-toolkit package

Allow Header foreground color customization per Page

  1. Vivid (15.04)
  2. Bug #1315884
Bug #1315884 reported by Michael Hall
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu UI Toolkit
Fix Released
High
Tim Peeters
ubuntu-ui-toolkit (Ubuntu)
Fix Released
Undecided
Unassigned
Vivid
New
Undecided
Unassigned

Bug Description

Each Page should have the ability to customize a few things about the look of the header, these changes should take affect when the page becomes the top page in a PageStack or the current tab in Tabs.

headerTextColor: Set the color of text displayed in the Header

I removed the other (header background) properties from this bug, they are now in a separate bug here: https://bugs.launchpad.net/ubuntu-ui-toolkit/+bug/1350893

See original description

Related branches

lp://staging/~tpeeters/ubuntu-ui-toolkit/headIconColor
PS Jenkins bot: Approve (continuous-integration)
Cris Dywan: Approve
Diff: 299 lines (+125/-21)
8 files modified
components.api (+1/-0)
examples/ubuntu-ui-toolkit-gallery/Icons.qml (+4/-6)
modules/Ubuntu/Components/Icon10.qml (+3/-1)
modules/Ubuntu/Components/PageHeadConfiguration.qml (+5/-0)
modules/Ubuntu/Components/Themes/Ambiance/PageHeadButton.qml (+5/-6)
modules/Ubuntu/Components/Themes/Ambiance/PageHeadStyle.qml (+6/-2)
tests/resources/header/header.qml (+5/-6)
tests/unit/tst_components/tst_header_colors.qml (+96/-0)
Michael Hall (mhall119)
tags: added: android-compat header theming
Revision history for this message
Tim Peeters (tpeeters) wrote :

Michael can you discuss with design which customization is important?

I do not think "android-compat" is a good enough motivation for implementing certain features. If you can add a few use cases, that would help in prioritizing the features and deciding on an API to add them (for example, for a fixed header color per-app we may recommend to use theming, or add a property to the MainView. However, if it is a common use case to change the header-color per Page in an app, we may need to add a property to the page. It is also important to get feedback from design on this to find out which settings we like to promote and for which we will recommend the app developers to use the defaults to make the applications consistent).

Changed in ubuntu-ui-toolkit:
status: New → Confirmed
assignee: nobody → Tim Peeters (tpeeters)
importance: Undecided → Medium
Tim Peeters (tpeeters)
Changed in ubuntu-ui-toolkit:
importance: Medium → High
Revision history for this message
Tim Peeters (tpeeters) wrote :

Workaround for the header color: use MainView.backgroundColor, this also updates the header background.
If you need the page contents to be a different color from the background, you can add a background in the Page.

Revision history for this message
Tim Peeters (tpeeters) wrote :

The features requested here are actually several features. I am working on a branch to set the foreground and background color of the header. For images, please report a separate bug.

Tim Peeters (tpeeters)
summary: - Allow Header style customization per Page
+ Allow Header foreground color customization per Page
Changed in ubuntu-ui-toolkit:
status: Confirmed → In Progress
description: updated
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/staging at revision None, scheduled for release in ubuntu-ui-toolkit, milestone Unknown

Changed in ubuntu-ui-toolkit:
status: In Progress → Fix Committed
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

ubuntu-ui-toolkit (1.1.1179+14.10.20140804-0ubuntu1) utopic; urgency=medium

  [ Florian Boucault ]
  * UbuntuShape: removed QML proxy.

  [ Loïc Molinari ]
  * [UbuntuShape] Implemented QSGMaterial::compare() methods so that
    Ubuntu shapes can be batched.
    Fixes: https://bugs.launchpad.net/bugs/1350863.
  * Disconnected from old texture provider signals (Ubuntushape)

  [ Tim Peeters ]
  * Make header text color configurable, and always match the header
    icon colors to the header text color.
    Fixes: https://bugs.launchpad.net/bugs/1315884
           https://bugs.launchpad.net/bugs/1317816.

  [ Christian Dywan ]
  * Move QSKIP for test_updateAlarm_Repeating one line up.

  [ Zsombor Egri ]
  * Text input context menu facelift.

  [ Michał Sawicz ]
   * Add "source" property to the Icon component.
     Fixes: https://bugs.launchpad.net/bugs/1284233
 -- Ubuntu daily release <email address hidden> Mon, 04 Aug 2014 16:00:56 +0000

Changed in ubuntu-ui-toolkit:
status: Fix Committed → Fix Released
Zsombor Egri (zsombi)
Changed in ubuntu-ui-toolkit (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Related blueprints

Remote bug watches

Bug watches keep track of this bug in other bug trackers.