Move TabBar to HeaderStyle
Bug #1292601 reported by
Tim Peeters
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Ubuntu UI Toolkit |
Fix Released
|
Critical
|
Tim Peeters | ||
ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Vivid |
New
|
Undecided
|
Unassigned |
Bug Description
It belongs there. With the new header we will then simply pick a different HeaderStyle.
Related branches
lp://staging/~tpeeters/ubuntu-ui-toolkit/tabBarInStyle
Rejected
for merging
into
lp://staging/ubuntu-ui-toolkit
- Tim Peeters: Disapprove
- PS Jenkins bot: Needs Fixing (continuous-integration)
- Zsombor Egri: Approve
-
Diff: 224 lines (+51/-34)8 files modifiedCHANGES (+1/-0)
components.api (+1/-0)
modules/Ubuntu/Components/Header.qml (+13/-2)
modules/Ubuntu/Components/Tabs.qml (+8/-18)
modules/Ubuntu/Components/Themes/Ambiance/HeaderStyle.qml (+23/-1)
tests/resources/navigation/TabView.qml (+1/-9)
tests/unit/tst_components/tst_pagestack.qml (+3/-3)
tests/unit_x11/tst_components/tst_hide_chrome.qml (+1/-1)
lp://staging/~tpeeters/ubuntu-ui-toolkit/20-tabbarInStyle
- PS Jenkins bot: Approve (continuous-integration)
- Zsombor Egri: Approve
-
Diff: 336 lines (+73/-46)10 files modifiedCHANGES (+2/-0)
components.api (+2/-0)
modules/Ubuntu/Components/Header.qml (+16/-3)
modules/Ubuntu/Components/MainView.qml (+3/-6)
modules/Ubuntu/Components/Tabs.qml (+13/-14)
modules/Ubuntu/Components/Themes/Ambiance/HeaderStyle.qml (+23/-1)
tests/resources/navigation/TabView.qml (+1/-9)
tests/unit/tst_components/tst_pagestack.qml (+3/-3)
tests/unit_x11/tst_components/tst_hide_chrome.qml (+1/-1)
tests/unit_x11/tst_components/tst_tabs.qml (+9/-9)
Changed in ubuntu-ui-toolkit: | |
importance: | Undecided → Critical |
assignee: | nobody → Tim Peeters (tpeeters) |
status: | New → In Progress |
milestone: | none → march-2014 |
tags: | added: header tabs |
Changed in ubuntu-ui-toolkit: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fix committed into lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/staging at revision None, scheduled for release in ubuntu-ui-toolkit, milestone Unknown