Ubuntu
ubuntu-ui-toolkit package

Can't use uris for Icon source

  1. Vivid (15.04)
  2. Bug #1284233
Bug #1284233 reported by Michał Sawicz
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu UI Toolkit
Fix Released
Undecided
Michał Sawicz
ubuntu-ui-toolkit (Ubuntu)
Fix Released
Undecided
Unassigned
Vivid
New
Undecided
Unassigned

Bug Description

The Icon component doesn't have a "source" property, it only supports a "name", which means that there's no way to pass a image://theme/ uri (which backends send instead of plain names to uniquely identify the source of the icon).

Tags: icon

Related branches

lp://staging/~saviq/ubuntu-ui-toolkit/add-icon-source-property
PS Jenkins bot: Approve (continuous-integration)
Tim Peeters: Approve
Zsombor Egri: Needs Fixing
Diff: 426 lines (+122/-116)
6 files modified
components.api (+3/-0)
modules/Ubuntu/Components/Icon.qdoc (+87/-0)
modules/Ubuntu/Components/Icon10.qml (+8/-53)
modules/Ubuntu/Components/Icon11.qml (+21/-0)
modules/Ubuntu/Components/qmldir (+3/-2)
tests/unit_x11/tst_components/tst_icon.qml (+0/-61)
Revision history for this message
Tim Peeters (tpeeters) wrote :

The name property seems to do what you want, it converts "name" into an image://theme/name to take the image from the theme. If you want to set the source, you can use Image directly.

Also, most components have both an iconSource and iconName property, so you can choose which one you need

Changed in ubuntu-ui-toolkit:
status: New → Incomplete
Revision history for this message
Tim Peeters (tpeeters) wrote :

what is the use case here?

tags: added: icon
Revision history for this message
Michał Sawicz (saviq) wrote :

The use case is to use Icon directly (without any wrapper around it to check for image://theme/ in the uri) and its colourization feature, when the actual path for the icon comes from a remote service (e.g. indicator services).

And especially *because* other components support both iconName and iconSource, it would make sense here as well.

Michał Sawicz (saviq)
Changed in ubuntu-ui-toolkit:
status: Incomplete → In Progress
assignee: nobody → Michał Sawicz (saviq)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

Fix committed into lp:~ubuntu-sdk-team/ubuntu-ui-toolkit/staging at revision None, scheduled for release in ubuntu-ui-toolkit, milestone Unknown

Changed in ubuntu-ui-toolkit:
status: In Progress → Fix Committed
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

ubuntu-ui-toolkit (1.1.1179+14.10.20140804-0ubuntu1) utopic; urgency=medium

  [ Florian Boucault ]
  * UbuntuShape: removed QML proxy.

  [ Loïc Molinari ]
  * [UbuntuShape] Implemented QSGMaterial::compare() methods so that
    Ubuntu shapes can be batched.
    Fixes: https://bugs.launchpad.net/bugs/1350863.
  * Disconnected from old texture provider signals (Ubuntushape)

  [ Tim Peeters ]
  * Make header text color configurable, and always match the header
    icon colors to the header text color.
    Fixes: https://bugs.launchpad.net/bugs/1315884
           https://bugs.launchpad.net/bugs/1317816.

  [ Christian Dywan ]
  * Move QSKIP for test_updateAlarm_Repeating one line up.

  [ Zsombor Egri ]
  * Text input context menu facelift.

  [ Michał Sawicz ]
   * Add "source" property to the Icon component.
     Fixes: https://bugs.launchpad.net/bugs/1284233
 -- Ubuntu daily release <email address hidden> Mon, 04 Aug 2014 16:00:56 +0000

Changed in ubuntu-ui-toolkit:
status: Fix Committed → Fix Released
Zsombor Egri (zsombi)
Changed in ubuntu-ui-toolkit (Ubuntu):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.