Active property of Tabs not updated when pushed on a PageStack
Bug #1260116 reported by
Tim Peeters
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu UI Toolkit |
Fix Released
|
High
|
Tim Peeters | ||
| ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
| Vivid |
New
|
Undecided
|
Unassigned | ||
Bug Description
The attached program sets tabs.active initially to false because initially the tabs header must not be shown.
After pushing it on the PageStack, it does not become active, while it should.
--edit: the same is valid for a Page defined inside PageStack. It must initially not be active, and become active when pushed on the PageStack.
Related branches
lp://staging/~tpeeters/ubuntu-ui-toolkit/tabs-active
- Tim Peeters: Disapprove
- PS Jenkins bot: Needs Fixing (continuous-integration)
-
Diff: 479 lines (+212/-51)12 files modifiedexamples/ubuntu-ui-toolkit-gallery/ubuntu-ui-toolkit-gallery.qml (+2/-0)
modules/Ubuntu/Components/MainView.qml (+8/-1)
modules/Ubuntu/Components/Page.qml (+1/-1)
modules/Ubuntu/Components/PageStack.qml (+3/-0)
modules/Ubuntu/Components/PageTreeNode.qml (+23/-26)
modules/Ubuntu/Components/Tabs.qml (+3/-0)
modules/Ubuntu/Components/pageTree.js (+58/-0)
tests/resources/navigation/PageStack.qml (+0/-3)
tests/resources/navigation/TabsOnStack.qml (+61/-0)
tests/unit/tst_components/tst_mainview.qml (+29/-0)
tests/unit/tst_components/tst_pagestack.qml (+21/-20)
tests/unit_x11/tst_components/tst_header.qml (+3/-0)
lp://staging/~tpeeters/ubuntu-ui-toolkit/80-betterActive
- PS Jenkins bot: Approve (continuous-integration)
- Zsombor Egri: Approve
-
Diff: 198 lines (+55/-12)7 files modifiedcomponents.api (+1/-0)
modules/Ubuntu/Components/MainView.qml (+5/-1)
modules/Ubuntu/Components/Page.qml (+2/-0)
modules/Ubuntu/Components/PageStack.qml (+11/-0)
modules/Ubuntu/Components/PageTreeNode.qml (+10/-8)
tests/unit/tst_components/tst_pagestack.qml (+23/-3)
tests/unit/tst_mainview/PageStack.qml (+3/-0)
Revision history for this message
| Tim Peeters (tpeeters) wrote | #1 |
| Changed in ubuntu-ui-toolkit: | |
| assignee: | nobody → Tim Peeters (tpeeters) |
| importance: | Medium → High |
Revision history for this message
| Tim Peeters (tpeeters) wrote | #2 |
| Changed in ubuntu-ui-toolkit: | |
| status: | In Progress → Confirmed |
| Changed in ubuntu-ui-toolkit: | |
| importance: | High → Low |
| Changed in ubuntu-ui-toolkit: | |
| status: | Confirmed → In Progress |
| Changed in ubuntu-ui-toolkit: | |
| importance: | Low → Medium |
| description: | updated |
| Changed in ubuntu-ui-toolkit: | |
| importance: | Medium → High |
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | #3 |
| Changed in ubuntu-ui-toolkit: | |
| status: | In Progress → Fix Committed |
| Changed in ubuntu-ui-toolkit: | |
| status: | Fix Committed → Fix Released |
| Changed in ubuntu-ui-toolkit (Ubuntu): | |
| status: | New → Fix Released |
To post a comment you must log in.
with the new branch, active of Tabs needs not be set. It works fine now automatically.