Ubuntu
ubuntu-ui-toolkit package

[theming] rewrite theming unit tests

  1. Vivid (15.04)
  2. Bug #1248982
Bug #1248982 reported by Zsombor Egri
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
ubuntu-ui-toolkit (Ubuntu)
Fix Released
High
Zsombor Egri
Vivid
New
Undecided
Unassigned

Bug Description

Theming unit tests are not reliable enough, i.e. they pass locally but fail on Jenkins. The tests load several themes and change environment variables, which require the theme engine to be reinitialized every time in order to have proper functionality provided.

Tags: theming

Related branches

lp://staging/~zsombi/ubuntu-ui-toolkit/01-multiple-theme-engines
PS Jenkins bot: Needs Fixing (continuous-integration)
Tim Peeters: Approve
Diff: 1386 lines (+616/-234)
23 files modified
modules/Ubuntu/Components/plugin/plugin.cpp (+3/-3)
modules/Ubuntu/Components/plugin/plugin.pro (+6/-4)
modules/Ubuntu/Components/plugin/ucdefaulttheme.cpp (+7/-7)
modules/Ubuntu/Components/plugin/ucdefaulttheme.h (+6/-6)
modules/Ubuntu/Components/plugin/ucdeprecatedtheme.cpp (+124/-0)
modules/Ubuntu/Components/plugin/ucdeprecatedtheme.h (+53/-0)
modules/Ubuntu/Components/plugin/uclistitem.cpp (+7/-4)
modules/Ubuntu/Components/plugin/uctheme.cpp (+57/-46)
modules/Ubuntu/Components/plugin/uctheme.h (+17/-10)
tests/resources/subtheming/Simple.qml (+45/-0)
tests/unit/tst_performance/StyledItemOldTheming.qml (+72/-0)
tests/unit/tst_performance/tst_performance.cpp (+4/-0)
tests/unit/tst_performance/tst_performance.pro (+2/-1)
tests/unit_x11/tst_components/tst_app_theming.qml (+54/-0)
tests/unit_x11/tst_components/tst_components.pro (+2/-2)
tests/unit_x11/tst_deprecated_theme_engine/Parent.qml (+14/-4)
tests/unit_x11/tst_deprecated_theme_engine/SimpleItem.qml (+20/-0)
tests/unit_x11/tst_deprecated_theme_engine/themes/CustomTheme/TestStyle.qml (+0/-1)
tests/unit_x11/tst_deprecated_theme_engine/themes/TestModule/TestTheme/TestStyle.qml (+0/-1)
tests/unit_x11/tst_deprecated_theme_engine/tst_deprecated_theme_engine.cpp (+113/-113)
tests/unit_x11/tst_deprecated_theme_engine/tst_deprecated_theme_engine.pro (+9/-2)
tests/unit_x11/tst_theme_engine/TestApp.qml (+0/-29)
tests/unit_x11/unit_x11.pro (+1/-1)
Zsombor Egri (zsombi)
Changed in ubuntu-ui-toolkit:
importance: Undecided → Critical
status: New → Confirmed
Zsombor Egri (zsombi)
Changed in ubuntu-ui-toolkit:
importance: Critical → High
Revision history for this message
Zsombor Egri (zsombi) wrote :

The theme paths used by custom themes are not registered to the theme engine, therefore theme loading fails.

Zoltan Balogh (bzoltan)
Changed in ubuntu-ui-toolkit (Ubuntu):
assignee: nobody → Zsombor Egri (zsombi)
importance: Undecided → High
status: New → Confirmed
Zoltan Balogh (bzoltan)
no longer affects: ubuntu-ui-toolkit
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-ui-toolkit - 1.3.1510+15.10.20150519-0ubuntu1

---------------
ubuntu-ui-toolkit (1.3.1510+15.10.20150519-0ubuntu1) wily; urgency=medium

  [ Loïc Molinari ]
  * Set QSGNode debug description on the shape-based nodes to ease renderer
    debugging. Fixes LP: #1437270
  * Ensured QSGLayer-based source textures (like ShaderEffectSource) are
    updated before rendering. Fixes LP: #1447495

  [ Tim Peeters ]
  * Update sections test program.
  * Document the correct version when Page.head.visible and Page.head.locked
    were added.
  * Revert to use the old header in trunk.
  * Introduce the new ActionBar component.
  * Restore moving property on AppHeader 1.2.

  [ Zsombor Egri ]
  * Provide versioning for theme loading. Each toolkit must be released with a
    well defined system theme version, and theme modules must have the same
    version as the toolkit. Fixes LP: #1447113
  * Fix import versions in entire UITK and examples. Move example code under
    1.3 folder. Fixes LP: #1447113
  * Separate 1.2 from 1.3 versions in all Ubuntu.Component modules.
    Fixes LP: #1447113

  [ Zoltan Balogh ]
  * Fix header CPO for 1.2 without moving attribute. Let the header CPO try
    both old and new buttons.

  [ Christian Dywan ]
  * Add version subfolder to benchmark test paths.
  * Only show handlers if text isn't empty. Fixes LP: #1450213.
  * Only print unique deprecation notes. Fixes LP: #1454281.

  [ CI Train Bot ]
  * New rebuild forced.

 -- CI Train Bot <email address hidden> Tue, 19 May 2015 10:47:09 +0000

Changed in ubuntu-ui-toolkit (Ubuntu):
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.