PageStack doesn't display default of ConditionalLayout
Bug #1204834 reported by
Andreas E.
This bug affects 3 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu UI Toolkit |
Fix Released
|
Critical
|
Zsombor Egri | ||
| ubuntu-ui-toolkit (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
| Vivid |
New
|
Undecided
|
Unassigned | ||
Bug Description
The ConditionalLayout object allows to define a default layout (children of Layout object) and a list of special layouts with conditions. When the layouts list contains one or more layouts, the default layout will not render (when it is supposed to render).
It does render either when adding it to the layouts list, or when the layouts list is empty or when using the page without PageStack.
Related branches
lp://staging/~zsombi/ubuntu-ui-toolkit/layouts-visibility
- Cris Dywan: Approve
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 1516 lines (+595/-227)12 files modifiedcomponents.api (+2/-0)
modules/Ubuntu/Layouts/plugin/plugin.pro (+1/-1)
modules/Ubuntu/Layouts/plugin/propertychanges.cpp (+18/-33)
modules/Ubuntu/Layouts/plugin/propertychanges_p.h (+3/-16)
modules/Ubuntu/Layouts/plugin/ulitemlayout.h (+4/-1)
modules/Ubuntu/Layouts/plugin/ullayouts.cpp (+92/-81)
modules/Ubuntu/Layouts/plugin/ullayouts.h (+8/-3)
modules/Ubuntu/Layouts/plugin/ullayouts_p.h (+3/-5)
tests/unit_x11/tst_layouts/NestedVisibility.qml (+163/-0)
tests/unit_x11/tst_layouts/Visibility.qml (+84/-0)
tests/unit_x11/tst_layouts/tst_layouts.cpp (+214/-86)
tests/unit_x11/tst_layouts/tst_layouts.pro (+3/-1)
Revision history for this message
| Andreas E. (andreas-e) wrote | #1 |
Revision history for this message
| Tim Peeters (tpeeters) wrote | #2 |
| Changed in ubuntu-ui-toolkit: | |
| assignee: | nobody → Zsombor Egri (zsombi) |
| importance: | Undecided → Medium |
| Changed in ubuntu-ui-toolkit: | |
| status: | New → Confirmed |
Revision history for this message
| Zsombor Egri (zsombi) wrote | #3 |
| Changed in ubuntu-ui-toolkit: | |
| status: | Confirmed → Invalid |
Revision history for this message
| Niklas Wenzel (nikwen) wrote | #4 |
| Changed in ubuntu-ui-toolkit: | |
| assignee: | Zsombor Egri (zsombi) → nobody |
| status: | Invalid → Confirmed |
Revision history for this message
| Niklas Wenzel (nikwen) wrote | #5 |
| Changed in ubuntu-ui-toolkit: | |
| assignee: | nobody → Zsombor Egri (zsombi) |
| milestone: | none → june-2014 |
| Changed in ubuntu-ui-toolkit: | |
| importance: | Medium → Critical |
| status: | Confirmed → In Progress |
| tags: | added: convergence layouts |
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | #6 |
| Changed in ubuntu-ui-toolkit: | |
| status: | In Progress → Fix Committed |
| Changed in ubuntu-ui-toolkit: | |
| status: | Fix Committed → Fix Released |
| Changed in ubuntu-ui-toolkit (Ubuntu): | |
| status: | New → Fix Released |
To post a comment you must log in.
When the PageStack is not in a ConditionalLayout, but in Layouts (as the default layout), it also doesn't work. Initially the PageStack may show, but when switching layouts and going back, things get messed up and the PageStack is gone (or its Pages show, but no back button in toolbar).