Ubuntu
indicator-datetime package

Alarms not shown in indicator datetime after upgrade to ota4

  1. Vivid (15.04)
  2. Bug #1465806
Bug #1465806 reported by Dave Morley
26
This bug affects 5 people
Affects Status Importance Assigned to Milestone
Canonical System Image
Fix Released
High
Unassigned
Canonical System Image ww28-2015 "ota5"
evolution-data-server (Ubuntu)
Fix Released
Undecided
Charles Kerr
indicator-datetime (Ubuntu)
Fix Released
Undecided
Charles Kerr
Vivid
New
Undecided
Unassigned

Bug Description

STEPS:
1. Flash image 22 from stable
2. Set a one time alarm and a recurring alarm
3. Update to 23

EXPECTED:
Alarms should be up and running as expected

ACTUAL:
Alarms are not shown in the datetime indicator but show up as active in and available in the clock. Because the indicator is in control of the alarm trigger the alarm never goes off.

TEMPORARY WORK AROUND:
Disable and enable all your alarms and then they work as expected.

Related branches

lp://staging/~charlesk/indicator-datetime/lp-1465806-inject-missing-triggers-to-clock-app-alarms
Ted Gould (community): Approve
PS Jenkins bot (community): Approve (continuous-integration)
Diff: 374 lines (+321/-2)
5 files modified
src/engine-eds.cpp (+135/-2)
tests/CMakeLists.txt (+1/-0)
tests/print-to.h (+24/-0)
tests/test-eds-ics-missing-trigger.cpp (+116/-0)
tests/test-eds-ics-missing-trigger.ics (+45/-0)
lp://staging/~charlesk/indicator-datetime/merge-vivid-fixes-and-tests-into-wily
PS Jenkins bot (community): Approve (continuous-integration)
Ted Gould (community): Approve
Diff: 1611 lines (+1133/-268)
16 files modified
src/engine-eds.cpp (+486/-186)
tests/CMakeLists.txt (+16/-13)
tests/print-to.h (+34/-1)
tests/run-eds-ics-test.sh (+10/-0)
tests/test-eds-ics-all-day-events.cpp (+91/-0)
tests/test-eds-ics-all-day-events.ics (+19/-0)
tests/test-eds-ics-config-files/.config/evolution/sources/system-proxy.source (+21/-0)
tests/test-eds-ics-missing-trigger.cpp (+116/-0)
tests/test-eds-ics-missing-trigger.ics (+45/-0)
tests/test-eds-ics-nonrepeating-events.cpp (+93/-0)
tests/test-eds-ics-nonrepeating-events.ics (+27/-0)
tests/test-eds-ics-repeating-events.cpp (+100/-0)
tests/test-eds-ics-repeating-events.ics (+28/-0)
tests/test-eds-ics-repeating-valarms.ics (+47/-0)
tests/test-eds-valarms-config-files/.config/evolution/sources/system-proxy.source (+0/-21)
tests/test-eds-valarms-config-files/.local/share/evolution/calendar/system/calendar.ics (+0/-47)
Dave Morley (davmor2)
tags: added: qa-manual-testing
John McAleely (john.mcaleely)
Changed in canonical-devices-system-image:
milestone: none → ww28-2015
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in evolution-data-server (Ubuntu):
status: New → Confirmed
Revision history for this message
Zsombor Egri (zsombi) wrote :

I thunk this and the Clock crasher bug are two different bugs! The alarm not kicking is not the Clock or backend's problem, please break the duplication!

Revision history for this message
John McAleely (john.mcaleely) wrote :

I agree they are different.

Charles Kerr (charlesk)
Changed in canonical-devices-system-image:
assignee: nobody → Charles Kerr (charlesk)
assignee: Charles Kerr (charlesk) → nobody
Changed in evolution-data-server (Ubuntu):
assignee: nobody → Charles Kerr (charlesk)
status: Confirmed → In Progress
Revision history for this message
Charles Kerr (charlesk) wrote :

I see what the problem is -- the alarms created by ubuntu-clock-app in image 22 have valarms that are missing the required 'trigger' property. This works for alarms created by qtorganizer5-eds after the fix for bug #1440878 landed -- which is why disabling and then re-enabling the alarms as davmor2 works as a workaround -- but that still leaves the question of how to handle these triggerless alarms without requiring a workaround.

Until 13.10.0+15.04.20150521-0ubuntu1, indicator-datetime /pretended/ that x-canonical-alarm entries had a trigger even if they didn't. That's no longer possible because we're now querying EDS for alarms based on the trigger, which was necessary to fix bug #1456281.

Probably the safest fix here is for indicator-datetime to ask EDS on startup for all the x-canonical-alarm components, then walk through them looking for valarms missing a trigger, insert the missing trigger, and save the corrected entry back to EDS.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package indicator-datetime - 13.10.0+15.10.20150622-0ubuntu1

---------------
indicator-datetime (13.10.0+15.10.20150622-0ubuntu1) wily; urgency=medium

  [ Charles Kerr ]
  * Fix bugs relating to timezones and triggers from clock-app alarms.
    (LP: #1456281, #1465806)

 -- CI Train Bot <email address hidden> Mon, 22 Jun 2015 18:03:38 +0000

Changed in indicator-datetime (Ubuntu):
status: New → Fix Released
Charles Kerr (charlesk)
Changed in indicator-datetime (Ubuntu):
assignee: nobody → Charles Kerr (charlesk)
Changed in evolution-data-server (Ubuntu):
status: In Progress → Fix Released
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
status: New → Fix Released
importance: Undecided → High
Revision history for this message
John McAleely (john.mcaleely) wrote :

@pmcgowan, is this in vivid-overlay? It's hard to tell from the bug text

Revision history for this message
Pat McGowan (pat-mcgowan) wrote :

@john yes this is fixed in rtm

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.