menulibre save changes confirmation dialog is handled wrong
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MenuLibre |
Fix Released
|
High
|
Sean Davis | ||
menulibre (Ubuntu) |
Confirmed
|
Undecided
|
Unassigned | ||
Trusty |
Confirmed
|
Undecided
|
Unassigned |
Bug Description
[SRU - Test Case]
1. Modify a launcher, do not save.
2. Click on another launcher.
3. Save dialog appears. Click "Save changes".
[SRU - Expected Results]
[[MenuLibre 2.0.3]]
The launcher is saved, but the next item cannot be activated.
[[Menulibre 2.0.4]]
The launcher is saved, and the intended launcher is activated.
[Original Report]
If I change some properties of a menu item, say visibility flag, and then click on the next menu item a 'save changes' confirmation dialog appears. If I click Save then the previous menu item stays selected. I click on the next menu item again and this 'save changes' confirmation dialog appears again! It won't let me continue with the next menu item until I click Cancel even if I previously clicked Save a thousand times!
ubuntu 14.04 lts beta 2
menulibre 2.0.3-1
Related branches
Changed in menulibre: | |
status: | New → Confirmed |
assignee: | nobody → Sean Davis (smd-seandavis) |
status: | Confirmed → Triaged |
importance: | Undecided → High |
Changed in menulibre: | |
status: | Triaged → Fix Committed |
Changed in menulibre: | |
milestone: | none → 2.0.4 |
Changed in menulibre: | |
status: | Fix Committed → Fix Released |
description: | updated |
Here is the error message I get:
DEBUG:menulibre: save_launcher() 'Executing Command: ['xdg-desktop- menu', 'install', '--novendor', '/home/ alex/.local/ share/applicati ons/exo- mail-reader. desktop' ]' python3/ dist-packages/ menulibre/ MenulibreApplic ation.py" , line 1472, in on_treeview_ selection save_launcher( ) python3/ dist-packages/ menulibre/ MenulibreApplic ation.py" , line 2237, in save_launcher call(cmd_ list) python3. 4/subprocess. py", line 533, in call python3. 4/subprocess. py", line 848, in __init__ signals, start_new_session) python3. 4/subprocess. py", line 1446, in _execute_child _type(errno_ num, err_msg)
Traceback (most recent call last):
File "/usr/lib/
self.
File "/usr/lib/
subprocess.
File "/usr/lib/
with Popen(*popenargs, **kwargs) as p:
File "/usr/lib/
restore_
File "/usr/lib/
raise child_exception
FileNotFoundError: [Errno 2] No such file or directory: 'xdg-desktop-menu'
Yes, the xdg-desktop-menu is not installed on my system. If menulibre needs it to function properly then it should have a direct dependency to a package that has this executable. Current dependency is probably in the recommends section and that's why it is not installed. Would be better not to have this dependency at all