modified conf file contents attached by apport without asking
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
apport (Ubuntu) |
Fix Released
|
High
|
Brian Murray | ||
Oneiric |
Fix Released
|
High
|
Brian Murray |
Bug Description
In apport/hookutils.py there is a function called attach_conffiles which does the following:
key = 'modified.
if os.path.
m = hashlib.md5()
if calculated_md5sum != default_md5sum:
So it adds the contents of the conffile without checking with the reporter if this is okay. As I understand it some conffiles can contain passwords so it better if a dialog were raised if the md5sums did not match and the reporter were asked if they want to include the modified file.
Related branches
- Martin Pitt: Approve
-
Diff: 76 lines (+22/-4) (has conflicts)3 files modifiedapport/hookutils.py (+9/-2)
data/general-hooks/ubuntu.py (+2/-2)
debian/changelog (+11/-0)
Changed in apport (Ubuntu Oneiric): | |
status: | New → In Progress |
assignee: | nobody → Brian Murray (brian-murray) |
The code in question can be found here:
http:// bazaar. launchpad. net/~ubuntu- core-dev/ ubuntu/ oneiric/ apport/ ubuntu/ view/head: /apport/ hookutils. py#L83