Desktop icons in Mantic doesn't honor dock margins

Bug #2039475 reported by Sergio Costas
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gnome-shell-extension-desktop-icons-ng (Ubuntu)
Status tracked in Mantic
Mantic
In Progress
Undecided
Unassigned

Bug Description

[Impact]

The port to Gnome Shell 45 of Desktop Icons had a bug that prevents it from honoring the Dock size when in "IntelliHide" mode, thus allowing to put icons under it. It has been fixed in upstream by fixing in DING the implementation of the protocol that allows other extensions (like Dash-to-dock, Dash-to-panel, Hide-top-bar and more) to notify DING which zones are being used by them and thus allow to avoid putting icons there, which would be unreachable when the panel/dock/bar are visible.

[Test plan]

Go to the extensions properties of Dash-to-dock or Ubuntu-dock and ensure that the "IntelliHide" option (which hides the dock when a window is below it, and shows it again when there's only "empty desktop" below it) is ENABLED, the option "panel mode: extend up to the screen borders" is DISABLED, and the "maximum size of the dock" is BELOW 100% (90% is fine).

In an empty desktop (this is, without any window) the dock should be visible, with some free space in each side (top and bottom if the dock is vertical; left and right if it is horizontal) where the underlying desktop can be seen.

Now, open any window and maximize it; the dock should hide, thus allowing the window to fill the whole screen.

Close the window. The dock should appear again.

Try to move a desktop icon (any icon; a folder, a file, the trash, the personal folder... any is right) into the free zone of any of the sides.

If the patch works, it should NOT be possible to place the icon there; if the bug is present, then it will be possible to place the icon there.

It must be also test if it is possible to put an icon in any place of the "free" desktop surface (this is: any zone that won't be obscured by a bar, dock or panel).

[Where problems could occur]

If there are problems, they can show in several ways:

- the bugfix doesn't work, and thus it will still be possible to put icons in zones that should be forbidden

- DING might fail and no icons would be visible

- DING might wrongly interpret the data sent by other extensions, reducing too much the usable zone.

[ Other info ]
It seems easiest to take the new upstream release (47.0.5 -> 47.0.7) which includes this single code commit, plus translation updates.

Tags: mantic patch
Revision history for this message
Sergio Costas (rastersoft-gmail) wrote :

This patch fixes the problem.

Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "patch.diff" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags: added: patch
tags: added: mantic
affects: gnome-shell-extension-desktop-icons (Ubuntu) → gnome-shell-extension-desktop-icons-ng (Ubuntu)
Revision history for this message
Sergio Costas (rastersoft-gmail) wrote :

Just a little note: it's already fixed upstream with this same patch ;-)

Jeremy Bícha (jbicha)
Changed in gnome-shell-extension-desktop-icons-ng (Ubuntu):
status: New → Fix Committed
description: updated
Jeremy Bícha (jbicha)
description: updated
Jeremy Bícha (jbicha)
Changed in gnome-shell-extension-desktop-icons-ng (Ubuntu Mantic):
status: Fix Committed → In Progress
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.