selftest: fib_tests: Always cleanup before exit
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ubuntu-kernel-tests |
Fix Released
|
Undecided
|
Po-Hsu Lin | ||
linux (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Focal |
Fix Released
|
Medium
|
Po-Hsu Lin | ||
Jammy |
Fix Released
|
Medium
|
Po-Hsu Lin | ||
Kinetic |
Fix Released
|
Medium
|
Po-Hsu Lin | ||
Lunar |
Fix Released
|
Undecided
|
Unassigned | ||
linux-oem-5.17 (Ubuntu) |
Invalid
|
Undecided
|
Unassigned | ||
Focal |
Invalid
|
Undecided
|
Unassigned | ||
Jammy |
Fix Released
|
Undecided
|
Po-Hsu Lin | ||
Kinetic |
Invalid
|
Undecided
|
Unassigned | ||
Lunar |
Invalid
|
Undecided
|
Unassigned | ||
linux-oem-6.0 (Ubuntu) |
Invalid
|
Undecided
|
Unassigned | ||
Focal |
Invalid
|
Undecided
|
Unassigned | ||
Jammy |
Fix Released
|
Undecided
|
Po-Hsu Lin | ||
Kinetic |
Invalid
|
Undecided
|
Unassigned | ||
Lunar |
Invalid
|
Undecided
|
Unassigned | ||
linux-oem-6.1 (Ubuntu) |
Invalid
|
Undecided
|
Unassigned | ||
Focal |
Invalid
|
Undecided
|
Unassigned | ||
Jammy |
Fix Released
|
Undecided
|
Unassigned | ||
Kinetic |
Invalid
|
Undecided
|
Unassigned | ||
Lunar |
Invalid
|
Undecided
|
Unassigned |
Bug Description
[Impact]
Copied from the commit message:
Usage of `set -e` before executing a command causes immediate exit
on failure, without cleanup up the resources allocated at setup.
This can affect the next tests that use the same resources,
leading to a chain of failures.
A simple fix is to always call cleanup function when the script exists.
This approach is already used by other existing tests.
[Fix]
* b60417a9f2 selftest: fib_tests: Always cleanup before exit
This patch can be cherry-picked into affected kernels.
[Test]
Run the patched fib_tests.sh on KVM kernels, which is expected to fail
due to bug 2007458.
Check with `ip netns`, the ns1 added during setup() should be removed.
[Where problems could occur]
Test robustness improvement, this should not break things.
description: | updated |
Changed in linux (Ubuntu Lunar): | |
status: | New → Fix Released |
Changed in ubuntu-kernel-tests: | |
assignee: | nobody → Po-Hsu Lin (cypressyew) |
status: | New → In Progress |
Changed in linux (Ubuntu Focal): | |
assignee: | nobody → Po-Hsu Lin (cypressyew) |
Changed in linux (Ubuntu Jammy): | |
assignee: | nobody → Po-Hsu Lin (cypressyew) |
status: | New → In Progress |
Changed in linux (Ubuntu Kinetic): | |
status: | New → In Progress |
Changed in linux (Ubuntu Focal): | |
status: | New → In Progress |
Changed in linux (Ubuntu Kinetic): | |
assignee: | nobody → Po-Hsu Lin (cypressyew) |
description: | updated |
tags: | added: 5.4 focal |
Changed in linux (Ubuntu Kinetic): | |
importance: | Undecided → Medium |
status: | In Progress → Fix Committed |
Changed in linux (Ubuntu Jammy): | |
importance: | Undecided → Medium |
status: | In Progress → Fix Committed |
Changed in linux (Ubuntu Focal): | |
importance: | Undecided → Medium |
status: | In Progress → Fix Committed |
Changed in linux-oem-5.17 (Ubuntu Jammy): | |
status: | In Progress → Fix Committed |
Changed in linux-oem-6.0 (Ubuntu Jammy): | |
status: | In Progress → Fix Committed |
tags: |
added: verification-done-focal removed: verification-needed-focal |
Changed in ubuntu-kernel-tests: | |
status: | In Progress → Fix Released |
https:/ /lists. ubuntu. com/archives/ kernel- team/2023- April/138657. html