Ubuntu
libvirt package

/etc/profile.d/libvirt-uri.sh (LIBVIRT_DEFAULT_URI setting) overrides configured default

  1. Lunar (23.04)
  2. Bug #2027838
Bug #2027838 reported by Daniel Richard G.
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
libvirt (Ubuntu)
Fix Released
Wishlist
Lena Voytek
Jammy
New
Undecided
Lena Voytek
Lunar
New
Undecided
Lena Voytek

Bug Description

This concerns libvirt-clients 8.0.0-1ubuntu7.5 in Ubuntu 22.04/jammy.

The /etc/profile.d/libvirt-uri.sh profile script sets LIBVIRT_DEFAULT_URI to a value of "qemu:///system" or "xen:///". This setting occurs irrespective of any previous value (so this cannot be overridden by an earlier profile script or environment setting) or setting for uri_default in /etc/libvirt/libvirt.conf .

I wanted the default connection URI to be "qemu:///session", and was wondering why virsh(1) insisted on connecting to the system session despite my having set uri_default in libvirt.conf.

It seems to me that the profile script may no longer be needed in light of the uri_default setting, and should thus be removed. (Notably, the Debian libvirt-clients package does not contain this script.) If there is still a need for it, then it should at least be made more admin-friendly.

Related branches

~lvoytek/ubuntu/+source/libvirt:merge-lp2018082-mantic
git-ubuntu bot: Approve
Sergio Durigan Junior (community): Approve
Canonical Server: Pending requested
Canonical Server Reporter: Pending requested
Diff: 10453 lines (+9470/-85)
37 files modified
debian/changelog (+8235/-41)
debian/control (+9/-7)
debian/libvirt-clients.install (+1/-0)
debian/libvirt-clients.lintian-overrides (+1/-0)
debian/libvirt-daemon-system.dirs (+2/-0)
debian/libvirt-daemon-system.install (+2/-0)
debian/libvirt-daemon-system.libvirt-guests.default (+2/-2)
debian/libvirt-daemon-system.postinst (+136/-0)
debian/libvirt-daemon-system.postrm (+24/-1)
debian/libvirt-daemon.README.Debian (+82/-22)
debian/libvirt-daemon.apport (+22/-0)
debian/libvirt-daemon.dnsmasq (+2/-0)
debian/libvirt-daemon.install (+1/-0)
debian/libvirt-uri.sh (+21/-0)
debian/patches/series (+19/-0)
debian/patches/ubuntu-aa/0020-virt-aa-helper-ubuntu-storage-paths.patch (+37/-0)
debian/patches/ubuntu-aa/0029-appmor-libvirt-qemu-Add-9p-support.patch (+34/-0)
debian/patches/ubuntu-aa/0031-virt-aa-helper-Ask-for-no-deny-rule-for-readonly-dis.patch (+43/-0)
debian/patches/ubuntu-aa/0032-apparmor-libvirt-qemu-Allow-reading-charm-specific-c.patch (+34/-0)
debian/patches/ubuntu-aa/0033-UBUNTU-only-apparmor-for-kvm.powerpc-LP-1680384.patch (+41/-0)
debian/patches/ubuntu-aa/0034-apparmor-virt-aa-helper-access-for-snapped-nova.patch (+28/-0)
debian/patches/ubuntu-aa/lp-1815910-allow-vhost-hotplug.patch (+57/-0)
debian/patches/ubuntu/Allow-libvirt-group-to-access-the-socket.patch (+50/-0)
debian/patches/ubuntu/daemon-augeas-fix-expected.patch (+21/-0)
debian/patches/ubuntu/dnsmasq-as-priv-user (+300/-0)
debian/patches/ubuntu/lp-1861125-ubuntu-models.patch (+21/-0)
debian/patches/ubuntu/ovmf_paths.patch (+54/-0)
debian/patches/ubuntu/set-default-machine-to-ubuntu.patch (+45/-0)
debian/patches/ubuntu/swtpm-by-swtpm-user.patch (+40/-0)
debian/patches/ubuntu/ubuntu_machine_type.patch (+14/-0)
debian/patches/ubuntu/wait-for-qemu-kvm.patch (+23/-0)
debian/polkit/60-libvirt.pkla (+6/-0)
debian/rules (+23/-4)
debian/tests/control (+3/-2)
debian/tests/smoke-lxc (+30/-4)
debian/tests/smoke-qemu-session (+5/-0)
debian/tests/smoke-qemu-session.xml (+2/-2)
Revision history for this message
Bryce Harrington (bryce) wrote :

From the debian changelog, it appears this script was added to perform an automated switch when xen is in use. It was added prior to 2015, and does not appear to have been substantially modified since then. So, I suspect a question may be if this xen use case is still important. If not, then your suggested course of action could make sense.

OTOH, if the automatic behavior with xen is important, then it sounds like what is needed would be either a way to ensure user settings in /etc/libvirt/libvirt.conf take precedence, or to provide administrators with a straightforward way to disable the automated behavior.

Changed in libvirt (Ubuntu):
importance: Undecided → Wishlist
status: New → Triaged
tags: added: server-triage-discuss
Revision history for this message
Daniel Richard G. (skunk) wrote :

Wouldn't it make sense to have a libvirt-clients package script set the appropriate value (Xen or no Xen) in libvirt.conf, perhaps with an associated debconf question? The current approach doesn't seem consistent with normal Debian/Ubuntu practice.

Revision history for this message
Bryce Harrington (bryce) wrote :

Hi Daniel, thanks for the quick reply. I am not personally familiar enough with libvirt to say, but offhand I do agree with you that the current approach feels like it could be done more cleanly. I've tagged the bug as 'server-triage-discuss' which adds it to a list of review items for the server team's Wednesday meeting.

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

I think we need to keep qemu:system as the default.
But you are right
- we do no more need xen nowadays
- we want users to be able to override it in non-weird ways

We'll have a look at this when merging a recent libvirt for 23.10

tags: added: libvirt-23.10 server-todo
removed: server-triage-discuss
Revision history for this message
Lena Voytek (lvoytek) wrote :

I'll add this as part of the libvirt merge

Changed in libvirt (Ubuntu):
assignee: nobody → Lena Voytek (lvoytek)
Lena Voytek (lvoytek)
Changed in libvirt (Ubuntu):
status: Triaged → In Progress
Christian Ehrhardt  (paelzer)
Changed in libvirt (Ubuntu Jammy):
assignee: nobody → Lena Voytek (lvoytek)
Changed in libvirt (Ubuntu Lunar):
assignee: nobody → Lena Voytek (lvoytek)
Revision history for this message
Lena Voytek (lvoytek) wrote :

Fixed in mantic merge, I'll start the SRUs soon

Changed in libvirt (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.