dkms modules are not built anymore for linux-kvm
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
autopkgtest (Ubuntu) |
Invalid
|
Medium
|
Roxana Nicolescu | ||
Jammy |
Invalid
|
Undecided
|
Unassigned | ||
Kinetic |
Invalid
|
Undecided
|
Unassigned | ||
dkms (Ubuntu) |
New
|
Undecided
|
Unassigned | ||
Jammy |
New
|
Undecided
|
Unassigned | ||
Kinetic |
New
|
Undecided
|
Unassigned | ||
linux-kvm (Ubuntu) |
Invalid
|
Undecided
|
Unassigned | ||
Jammy |
Invalid
|
Undecided
|
Unassigned | ||
Kinetic |
Invalid
|
Undecided
|
Unassigned |
Bug Description
SRU Justification
[Impact]
Some dkms modules are not built anymore when a retry is triggred from adt matrix page.
It was noticed because these modules previously failed during build (because a config options is disabled) but now they pass (artificial pass).
Affected modules:
1. digimend-dkms
2. oss4
3. rtl8812au
4. rtl8812ce
Looking at digimend-dkms for jammy:linux-kvm, first time the test was correct (it failed) was when the new kernel was just pushed to proposed and adt testing was triggered. When a manual retry was done, it passed because build was ignored.
Looking at the artifacts (attached for both cases), ADT_TEST_TRIGGERS differs:
1. when build is triggered, ADT_TEST_
logs https:/
2. when build is not triggered, ADT_TEST_
logs:
https:/
Last log line present in both cases is:
"I: Testing binary package $pkg".
Looking at dkms: debian/
After that line and the line where build is triggered the following code:
dkms_pkg=$(bash -c ". $dkms_conf > /dev/null; echo \$PACKAGE_NAME" 2>/dev/null)
dkms_ver=$(bash -c ". $dkms_conf > /dev/null; echo \$PACKAGE_VERSION" 2>/dev/null)
for k in /lib/modules/
do
test -d "$k" || continue
# If any linux-meta is in triggers, only test abistems that
# match triggers otherwise continue. This helps integration
# with adt-matrix which specifically requests test results
# against each individual linux-meta and tracks unique results
# per kernel abi.
## abistem is 5.15.0-130
case "${ADT_
esac
echo "I: Trying to build $dkms_pkg/$dkms_ver for $kver"
What happens here is that it never gets passed the switch case and build is not triggered when ADT_TEST_TRIGGERS consists of linux-meta only, because abistem=
This justifies why the module is built when ADT_TEST_
[Fix]
Add an extra check for meta_version in that switch case statement.
[Testcase]
1. Tested locally with ADT_TEST_
I: linux-headers-
I: Testing binary package digimend-dkms
autopkgtest [11:14:45]: test dkms-autopkgtest: -------
autopkgtest [11:14:46]: test dkms-autopkgtest: - - - - - - - - - - results - - - - - - - - - -
dkms-autopkgtest PASS
autopkgtest [11:14:47]: @@@@@@@
dkms-autopkgtest PASS
qemu-system-x86_64: terminating on signal 15 from pid 15111 (/usr/bin/python3)
2. Tested locally with ADT_TEST_
I: Testing binary package digimend-dkms
I: Trying to build digimend/10 for 5.15.0-1029-kvm
Creating symlink /var/lib/
Kernel preparation unnecessary for this kernel. Skipping...
Building module:
cleaning build area...
make -j1 KERNELRELEASE=
ERROR (dkms apport): kernel package linux-headers-
Error! Bad return status for module build on kernel: 5.15.0-1029-kvm (x86_64)
Consult /var/lib/
E: digimend/10 failed to build for 5.15.0-1029-kvm
========== /var/lib/
DKMS make.log for digimend-10 for kernel 5.15.0-1029-kvm (x86_64)
Wed Mar 15 11:20:05 CET 2023
make -C /lib/modules/
make[1]: Entering directory '/usr/src/
CC [M] /var/lib/
CC [M] /var/lib/
CC [M] /var/lib/
CC [M] /var/lib/
/var/lib/
/var/lib/
1147 | if (bNumInterfaces != 3) {
| ^
/var/lib/
1165 | case VID_PID(
| ^~~~
LD [M] /var/lib/
CC [M] /var/lib/
CC [M] /var/lib/
MODPOST /var/lib/
ERROR: modpost: "usb_string" [/var/lib/
ERROR: modpost: "usb_control_msg" [/var/lib/
ERROR: modpost: "usb_hid_driver" [/var/lib/
make[2]: *** [scripts/
make[2]: *** Deleting file '/var/lib/
make[1]: *** [Makefile:1821: modules] Error 2
make[1]: Leaving directory '/usr/src/
make: *** [Makefile:25: modules] Error 2
=======
./digimend/
autopkgtest [11:20:08]: test dkms-autopkgtest: -------
autopkgtest [11:20:09]: test dkms-autopkgtest: - - - - - - - - - - results - - - - - - - - - -
dkms-autopkgtest FAIL non-zero exit status 1
autopkgtest [11:20:10]: @@@@@@@
dkms-autopkgtest FAIL non-zero exit status 1
qemu-system-x86_64: terminating on signal 15 from pid 16171 (/usr/bin/python3)
[Regression potential]
We will see now failures instead of passes, but for the modules listed above, fixes are in the making.
[Note]
Not sure why ADT_TEST_TRIGGERS is different for manual retries vs when test is automated triggered when the new kernel is in proposed.
Related branches
- Sergio Durigan Junior (community): Needs Information
- git-ubuntu import: Pending requested
-
Diff: 24 lines (+8/-0)1 file modifieddebian/scripts/dkms-autopkgtest (+8/-0)
Changed in autopkgtest (Ubuntu): | |
importance: | Undecided → Medium |
assignee: | nobody → Roxana Nicolescu (roxanan) |
tags: | added: sru-20230130 |
tags: | added: sru-20230227 |
description: | updated |
Changed in autopkgtest (Ubuntu): | |
status: | Incomplete → Invalid |
Changed in linux-kvm (Ubuntu): | |
status: | New → Invalid |
Changed in autopkgtest (Ubuntu Jammy): | |
status: | New → Invalid |
Changed in autopkgtest (Ubuntu Kinetic): | |
status: | New → Invalid |
Changed in linux-kvm (Ubuntu Jammy): | |
status: | New → Invalid |
Changed in linux-kvm (Ubuntu Kinetic): | |
status: | New → Invalid |
Hi Roxana, you linked the same log twice, so I can't see the "Logs where test passes". Having a link to the unexpected pass log will help us understand the issue. At the moment it is not clear to me the report is about the dep8 tests, the autpkgtest package or the autopkgtest infrastructure. Thanks!