Update gstreamer to 1.20.3

Bug #1980239 reported by Jeremy Bícha
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
gst-libav1.0 (Ubuntu)
Fix Released
High
Unassigned
Jammy
Fix Released
High
Unassigned
gst-plugins-bad1.0 (Ubuntu)
Fix Released
High
Unassigned
Jammy
Fix Released
High
Unassigned
gst-plugins-good1.0 (Ubuntu)
Fix Released
High
Unassigned
Jammy
Fix Released
High
Unassigned
gst-plugins-ugly1.0 (Ubuntu)
Fix Released
High
Unassigned
Jammy
In Progress
High
Unassigned
gst-python1.0 (Ubuntu)
Fix Released
High
Unassigned
Jammy
Won't Fix
High
Unassigned
gst-rtsp-server1.0 (Ubuntu)
Fix Released
High
Unassigned
Jammy
In Progress
High
Unassigned
gstreamer-editing-services1.0 (Ubuntu)
Fix Released
High
Unassigned
Jammy
Incomplete
High
Unassigned
gstreamer-vaapi (Ubuntu)
Fix Released
High
Unassigned
Jammy
Triaged
High
Unassigned
gstreamer1.0 (Ubuntu)
Fix Released
High
Unassigned
Jammy
Fix Released
High
Unassigned

Bug Description

Impact
------
Since Ubuntu 22.04 LTS's release with gstreamer 1.20.1, there have been two bugfix stable releases.

https://gstreamer.freedesktop.org/releases/1.20/#1.20.2
https://gstreamer.freedesktop.org/releases/1.20/#1.20.3

Test Case 1
-----------
We now run upstream's test suite for most gstreamer components at build time and fail the build for errors on our key desktop architectures, amd64 & arm64.

Ensure the builds succeeed.

Test Case 2
-----------
Play a variety of videos in Totem. Play a variety of audio tracks in Rhythmbox. Try to stream audio and/or video. Try to install a missing codec.

In all cases, make sure that everything which worked before still works.

What Could Go Wrong
-------------------
If one of the fixes is bad then it might break video or audio playback, or could crash any application that tries to use gstreamer.

Jeremy Bícha (jbicha)
Changed in gst-libav1.0 (Ubuntu):
status: New → Fix Released
importance: Undecided → High
Changed in gst-libav1.0 (Ubuntu Jammy):
importance: Undecided → High
status: New → In Progress
Changed in gst-plugins-bad1.0 (Ubuntu):
importance: Undecided → High
status: New → Fix Released
Changed in gst-plugins-bad1.0 (Ubuntu Jammy):
importance: Undecided → High
status: New → In Progress
Changed in gst-plugins-good1.0 (Ubuntu):
importance: Undecided → High
status: New → Fix Released
Changed in gstreamer1.0 (Ubuntu Jammy):
importance: Undecided → High
status: New → In Progress
Changed in gstreamer-vaapi (Ubuntu Jammy):
importance: Undecided → High
status: New → In Progress
Changed in gstreamer-vaapi (Ubuntu):
importance: Undecided → High
status: New → Fix Released
Changed in gstreamer-editing-services1.0 (Ubuntu Jammy):
importance: Undecided → High
status: New → In Progress
Changed in gstreamer-editing-services1.0 (Ubuntu):
importance: Undecided → High
status: New → Fix Released
Changed in gst-rtsp-server1.0 (Ubuntu Jammy):
importance: Undecided → High
status: New → In Progress
Changed in gst-rtsp-server1.0 (Ubuntu):
importance: Undecided → High
status: New → Fix Released
Changed in gst-python1.0 (Ubuntu Jammy):
importance: Undecided → High
status: New → Fix Released
Changed in gst-python1.0 (Ubuntu):
importance: Undecided → High
status: New → Fix Released
Changed in gst-python1.0 (Ubuntu Jammy):
status: Fix Released → In Progress
Changed in gst-plugins-ugly1.0 (Ubuntu Jammy):
importance: Undecided → High
status: New → In Progress
Changed in gst-plugins-good1.0 (Ubuntu Jammy):
importance: Undecided → High
status: New → In Progress
Changed in gst-plugins-ugly1.0 (Ubuntu):
importance: Undecided → High
status: New → Fix Released
Revision history for this message
Steve Langasek (vorlon) wrote : Please test proposed package

Hello Jeremy, or anyone else affected,

Accepted gst-libav1.0 into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gst-libav1.0/1.20.3-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in gst-libav1.0 (Ubuntu Jammy):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-jammy
Changed in gst-plugins-bad1.0 (Ubuntu Jammy):
status: In Progress → Fix Committed
Revision history for this message
Steve Langasek (vorlon) wrote :

Hello Jeremy, or anyone else affected,

Accepted gst-plugins-bad1.0 into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gst-plugins-bad1.0/1.20.3-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in gst-plugins-good1.0 (Ubuntu Jammy):
status: In Progress → Fix Committed
Revision history for this message
Steve Langasek (vorlon) wrote :

Hello Jeremy, or anyone else affected,

Accepted gst-plugins-good1.0 into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gst-plugins-good1.0/1.20.3-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Steve Langasek (vorlon) wrote :

gst-plugins-ugly1.0 is not listed on https://gitlab.gnome.org/GNOME/gnome-build-meta/-/tree/master/elements/sdk as referenced from https://wiki.ubuntu.com/StableReleaseUpdates/GNOME , unlike base/good/bad. On what basis is this being included in an SRU without a test case?

Changed in gst-plugins-ugly1.0 (Ubuntu Jammy):
status: In Progress → Incomplete
Revision history for this message
Steve Langasek (vorlon) wrote :

same question on vaapi as for plugins-ugly.

Revision history for this message
Steve Langasek (vorlon) wrote :

And gst-python :/

Changed in gst-python1.0 (Ubuntu Jammy):
status: In Progress → Incomplete
Revision history for this message
Steve Langasek (vorlon) wrote :

Actually, gst-python's diff shows no functional changes except the following, which is irrelevant to us:

- Fix build on systems without C++ compiler

I don't think it's justifiable to release an SRU to the world of this package which should include no functional changes. Making the version number match the other gst packages is not adequate justification for the download for every desktop user in the world. If you want this to be included in -proposed and blocked there due to the addition of the build-time tests, that would be ok, but otherwise this is a reject from me.

Revision history for this message
Steve Langasek (vorlon) wrote :

gstreamer-editing-services1.0 also not listed as one of the components covered by the GNOME exception.

Also the package introduces patches that are undocumented in the changelog (increase-test-timeout.patch).

Changed in gstreamer-editing-services1.0 (Ubuntu Jammy):
status: In Progress → Incomplete
Revision history for this message
Steve Langasek (vorlon) wrote :

gstreamer1.0 is not listed on the GNOME sdk page, but at least it's self-evident that this is a core component that is being tested if gst-plugins-base is...

Changed in gstreamer1.0 (Ubuntu Jammy):
status: In Progress → Fix Committed
Revision history for this message
Steve Langasek (vorlon) wrote :

Hello Jeremy, or anyone else affected,

Accepted gstreamer1.0 into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/gstreamer1.0/1.20.3-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Jeremy Bícha (jbicha) wrote :

I wasn't intending for gstreamer to be updated under the GNOME microrelease exception.

There is longstanding precedent for gstreamer microreleases to be accepted as SRUs and I don't think those have claimed they were being done as a GNOME dependency.

The gstreamer 20.04 LTS SRU included only the core pieces.

The 18.04 LTS SRU included all the parts of gstreamer LP: #1832123

-ugly and -vaapi were included in 18.04 LTS (above) and 16.04 LTS LP: #1619600

I am ok with gst-python1.0 being rejected since the change is unimportant.

I think this gstreamer-editing-services-1.0 update is worth a microrelease SRU. I would need to beg upstream for a test case since they didn't provide enough details in their commit messages & merge proposals.

For the first time, I made failures in the build tests for most of gstreamer fail the build for amd64 & arm64. I did this to try to better comply with the SRU guidelines. That makes this the best tested gstreamer SRU we've done. I didn't mention those changes in the debian/changelog because it doesn't really affect the user experience but I mentioned it briefly in this bug's description.

Jeremy Bícha (jbicha)
Changed in gst-plugins-ugly1.0 (Ubuntu Jammy):
status: Incomplete → In Progress
Revision history for this message
Sebastien Bacher (seb128) wrote :

Replying about the gstreamer-vaapi SRU, the update has only 3 changes outside of build system and changelog updates

https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2459
it's the fix for bug #1970013 which is referenced in the changelog

https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2604
which is an upstream fix without testcase

https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2163
which is a typo fix in a gobject introspection annotation, the binding doesn't have known users but the wrong annotation would lead to incorrect ownership of the returned value

The first fix is important and we would like to get in the LTS .1. Gstreamer has a solid record of stability so we would like the update to be considered as a micro-update and trust upstream that the other fixes are right.

Is that acceptable or should we do another upload cherrypicking the one fix we really care about?

Revision history for this message
Steve Langasek (vorlon) wrote :

> For the first time, I made failures in the build tests for most of gstreamer
> fail the build for amd64 & arm64. I did this to try to better comply
> with the SRU guidelines.

I appreciate this; it's not required by any means but it is a welcome improvement.

> There is longstanding precedent for gstreamer microreleases to be
> accepted as SRUs and I don't think those have claimed they were being
> done as a GNOME dependency.

This, however, is not persuasive to me. I don't consider "precedent" to be a reason not to follow the SRU procedure. If the other SRU team members who accepted those SRUs want to explain why they think an exception should be made here, that's fine, and then we can document it for the future. Without having talked to them first, however, my /suspicion/ is that they were regarding this as covered by the GNOME exception because of the difficulty we've had pinning down what is or isn't meant to be covered by it.

> I think this gstreamer-editing-services-1.0 update is worth a
> microrelease SRU. I would need to beg upstream for a test case
> since they didn't provide enough details in their commit messages
> & merge proposals.

That seems reasonable - please do get a test case for it.

> I am ok with gst-python1.0 being rejected since the change is unimportant.

Ok, I'll go ahead and do that.

> Gstreamer has a solid record of stability

I find I have to balance this against the fact that they have explicitly partitioned the codec drivers upstream into different levels of support, and the ones we're talking about here are not part of the GNOME core.

> Is that acceptable or should we do another upload cherrypicking
> the one fix we really care about?

Given that there are no test cases and the possible effects of the changes are not obvious, please cherry-pick the one fix in order to get this through into .1.

Jeremy Bícha (jbicha)
Changed in gst-python1.0 (Ubuntu Jammy):
status: Incomplete → Won't Fix
Changed in gstreamer-vaapi (Ubuntu Jammy):
status: In Progress → Triaged
Revision history for this message
Jeremy Bícha (jbicha) wrote :

I installed gst-plugins-good1.0, gst-plugins-bad1.0, gst-libav1.0, and gstreamer1.0 from jammy-proposed. I verified that I was able to play a variety of audio files with Rhythmbox and video files from Totem. The build tests also passed.

tags: added: jammy upgrade-software-version verification-done verification-done-jammy
removed: verification-needed verification-needed-jammy
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gst-libav1.0 - 1.20.3-0ubuntu1

---------------
gst-libav1.0 (1.20.3-0ubuntu1) jammy; urgency=medium

  * New upstream release (LP: #1980239)

 -- Jeremy Bicha <email address hidden> Wed, 29 Jun 2022 09:32:37 -0400

Changed in gst-libav1.0 (Ubuntu Jammy):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gstreamer1.0 - 1.20.3-0ubuntu1

---------------
gstreamer1.0 (1.20.3-0ubuntu1) jammy; urgency=medium

  * New upstream release (LP: #1980239)

 -- Jeremy Bicha <email address hidden> Thu, 30 Jun 2022 09:26:38 -0400

Changed in gstreamer1.0 (Ubuntu Jammy):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gst-plugins-bad1.0 - 1.20.3-0ubuntu1

---------------
gst-plugins-bad1.0 (1.20.3-0ubuntu1) jammy; urgency=medium

  * New upstream release (LP: #1980239)

 -- Jeremy Bicha <email address hidden> Wed, 29 Jun 2022 09:50:26 -0400

Changed in gst-plugins-bad1.0 (Ubuntu Jammy):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gst-plugins-good1.0 - 1.20.3-0ubuntu1

---------------
gst-plugins-good1.0 (1.20.3-0ubuntu1) jammy; urgency=medium

  * New upstream release (LP: #1980239)

 -- Jeremy Bicha <email address hidden> Wed, 29 Jun 2022 09:59:39 -0400

Changed in gst-plugins-good1.0 (Ubuntu Jammy):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for gst-libav1.0 has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Steve Langasek (vorlon) wrote : Proposed package upload rejected

An upload of gst-python1.0 to jammy-proposed has been rejected from the upload queue for the following reason: "rejected as discussed on the bug".

Revision history for this message
Steve Langasek (vorlon) wrote :

An upload of gst-plugins-ugly1.0 to jammy-proposed has been rejected from the upload queue for the following reason: "Request for test cases on gst-plugins-ugly1.0 has gone unanswered since last July".

Revision history for this message
Steve Langasek (vorlon) wrote :

An upload of gstreamer-editing-services1.0 to jammy-proposed has been rejected from the upload queue for the following reason: "not covered by GNOME exception; includes distro changes not documented in changelog".

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.