Using DiNG triggers ubuntu-dock opacity

Bug #1981837 reported by Coeur Noir
18
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Gnome Shell Extension Desktop Icons Ng
Fix Released
Unknown
gnome-shell-extension-desktop-icons-ng (Ubuntu)
Won't Fix
Undecided
Unassigned
Jammy
New
Undecided
Unassigned
gnome-shell-extension-ubuntu-dock (Ubuntu)
Fix Released
Low
Patryk Skorupa
Jammy
Triaged
Low
Marco Trevisan (Treviño)

Bug Description

Hi,

Ubuntu 22.04 LTS
jammy
Linux 5.15.0-40-generic x86_64 x86_64
ubuntu-xorg / x11

I prefer panel and dock to become fully opaque only when windows are maximized.

So I use this extension for panel : Transparent Top Bar (Adjustable transparency) which JustWorks™ in both Xorg and Wayland.

In ubuntu-dock, dynamic-transparency is set through dconf-editor ( transparency-mode, min-alpha, max-alpha. )

When using DiNG under Wayland, opacity is triggered as if « desktop » was considered as a maximized window.

Under Xorg, DiNG does not trigger dock opacity, as expected.

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

DING became a maximized window in Wayland sessions since the most recent update to fix bug 1976204.

I suggest the fix here is for "Transparent Top Bar" to ignore the DING window once it has 'hide_from_window_list' set.

tags: added: jammy
tags: added: wayland wayland-session
Changed in gnome-shell-extension-desktop-icons-ng (Ubuntu):
status: New → Won't Fix
Revision history for this message
Coeur Noir (coeur-noir) wrote :

Hi and thanks for answer.

Sorry for my low understanding but what am I supposed to do with your suggestion ?

Is there a way to tell ubuntu-dock ( when used in Wayland ) to ignore the DiNG maximized window ?

Hence the « won't fix » ? It's not a bug but a matter of ubuntu-dock settings ?

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

I was suggesting that you probably need to log a bug against the "Transparent Top Bar" extension. But my previous comments were a little wrong...

It looks like "Transparent Top Bar" needs to be modified to check the "window.skip_taskbar" flag and ignore any windows with that set. Then it won't get fooled by DING technically being a maximized window.

Revision history for this message
Coeur Noir (coeur-noir) wrote :

Guess you already know about :

Add compatibility with DING for Dynamic Transparency #1767
https://github.com/micheleg/dash-to-dock/pull/1767

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

I did not, but indeed that sounds like the right fix for dash-to-dock and ubuntu-dock. I've added a task tracking the bug in ubuntu-dock here.

Revision history for this message
Daniel van Vugt (vanvugt) wrote (last edit ):

Please test:

  https://github.com/micheleg/dash-to-dock/pull/1767.patch

If it works for you then I will get it merged upstream.

Changed in gnome-shell-extension-ubuntu-dock (Ubuntu):
status: New → In Progress
assignee: nobody → Patryk Skorupa (skoruppa)
Revision history for this message
Coeur Noir (coeur-noir) wrote :

And now I feel utterly ashamed and useless because I don't know how to test that.

Revision history for this message
Gunnar Hjalmarsson (gunnarhj) wrote :

One way is to just download it and:

sudo patch /<email address hidden>/theming.js ~/Downloads/1767.patch

Revision history for this message
Coeur Noir (coeur-noir) wrote :

^^

Thanks ! Aaaand… it works I can now use Wayland and having Dynamic Transparency for both Ubuntu Dock ( and top panel ).

Changed in gnome-shell-extension-desktop-icons-ng:
status: Unknown → Fix Released
Revision history for this message
Daniel van Vugt (vanvugt) wrote :
Changed in gnome-shell-extension-ubuntu-dock (Ubuntu):
status: In Progress → Fix Committed
tags: added: fixed-in-73 fixed-upstream
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package gnome-shell-extension-ubuntu-dock - 72ubuntu2

---------------
gnome-shell-extension-ubuntu-dock (72ubuntu2) kinetic; urgency=medium

  [ Patryk Skorupa ]
  * Add compatibility with DING for Dynamic Transparency (LP: #1981837)

  [ Daniel van Vugt ]
  * Declare compatibility with gnome-shell 43 (LP: #1987272)

 -- Daniel van Vugt <email address hidden> Mon, 22 Aug 2022 17:37:30 +0800

Changed in gnome-shell-extension-ubuntu-dock (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Coeur Noir (coeur-noir) wrote :

Hi,

am very surprised, as I am facing the same behaviour on a freshly installed Ubuntu 22.04 LTS :

on Wayland, using DING triggers opacity in ubuntu-dock with dynamic-transparency,

it's okay on Xorg.

Revision history for this message
Coeur Noir (coeur-noir) wrote :

Forget to mention :

gnome-shell-extension-ubuntu-dock is 72~ubuntu5.22.04.1
and
gnome-shell-extension-desktop-icons-ng is 43-2ubuntu1

( If of any interest, dash-to-panel and transparent-top-bar gnome-shell-extensions don't have their opacity triggered by DiNG, they behave as expected on both Wayland and Xorg. )

Revision history for this message
Coeur Noir (coeur-noir) wrote :

It has been fixed a moment and now it's back… 22.04 LTS

gnome-shell-extension-ubuntu-dock 72~ubuntu5.22.04.2.1

Revision history for this message
Coeur Noir (coeur-noir) wrote :
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

This bug was never fixed in 22.04. Only in 22.10 and later.

Changed in gnome-shell-extension-ubuntu-dock (Ubuntu Jammy):
status: New → Triaged
importance: Undecided → Low
assignee: nobody → Marco Trevisan (Treviño) (3v1n0)
Changed in gnome-shell-extension-ubuntu-dock (Ubuntu):
importance: Undecided → Low
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Just added a reminder to fix this in jammy, some time.

Revision history for this message
Coeur Noir (coeur-noir) wrote :

…aah ok, I thought it was fixed in priority in LTS, my bad.

Applying the 1767.patch from #6 still fixes the issue ;-)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.