[FFe] ubuntu-proxy-manager and adsys

Bug #2012371 reported by Gabriel Nagy
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
adsys (Ubuntu)
Fix Released
Undecided
Unassigned
Jammy
Incomplete
Undecided
Unassigned
Lunar
New
Undecided
Unassigned

Bug Description

Ubuntu Proxy Manager is a D-Bus mediated service that allows for managing system proxy settings via multiple backends (APT, environment variables and GSettings).

We request a FFe for this new source package (ubuntu-proxy-manager). As it's a new source package the risk of it breaking existing setups is non-existent as it must be explicitly opted into by users. The package is written in Go and benefits from an extensive test suite covering over 90% of the codebase.

Additionally, we would like to request a FFe for adsys where we added a Suggests dependency on ubuntu-proxy-manager. We have taken great care on the adsys part to maintain backwards compatibility and not affect users who do not install the ubuntu-proxy-manager package.

Installing the ubuntu-proxy-manager package on its own has no impact to the system. To benefit from its functionality adsys has to be upgraded and correctly configured.

-----

Relevant URLs:

1. ubuntu-proxy-manager homepage: https://github.com/ubuntu/ubuntu-proxy-manager
2. ubuntu-proxy-manager implementation in ADSys: https://github.com/ubuntu/adsys/pull/637
3. LP build of ubuntu-proxy-manager: https://launchpad.net/~gabuscus/+archive/ubuntu/ppa/+sourcepub/14562796/+listing-archive-extra
4. LP build of adsys: https://launchpad.net/~gabuscus/+archive/ubuntu/ppa/+sourcepub/14562807/+listing-archive-extra

Gabriel Nagy (gabuscus)
description: updated
Revision history for this message
Graham Inggs (ginggs) wrote :

FFe granted, please go ahead.

Changed in adsys (Ubuntu):
status: New → Triaged
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package adsys - 0.11.0

---------------
adsys (0.11.0) lunar; urgency=medium

  [ Denison Barbosa ]
  [ Gabriel Nagy ]
  * List Pro policy types in service status output
  * Warn when Pro-only rules are configured
  * Use systemd via D-Bus instead of systemctl commands
  * Add placeholder notes for entry types
  * Add guideline docs to the policy managers
  * Change Ubuntu Advantage to Ubuntu Pro in docs
  * Add system proxy policy manager (LP: #2012371)
  * Update dependencies to latest:
    - github.com/charmbracelet/lipgloss
    - github.com/coreos/go-systemd/v22
    - github.com/fatih/color
    - github.com/golangci/golangci-lint
    - github.com/golang/protobuf
    - golang.org/x/net
    - google.golang.org/grpc
    - google.golang.org/grpc/cmd/protoc-gen-go-grpc
    - google.golang.org/protobuf
  * CI and quality of life changes not impacting package functionality:
    - Bump github actions to latest:
      - actions/setup-go
    - Update Rust related auto update jobs
    - Replace testutils.Setenv with t.Setenv
    - Set up more tests to run in parallel
    - Various test refactors and improvements

 -- Gabriel Nagy <email address hidden> Tue, 04 Apr 2023 19:40:35 +0300

Changed in adsys (Ubuntu):
status: Triaged → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

This bug is mentioned from the adsys SRU .changes file but does not provide an SRU template. As this seems to reference a new feature (and new dependency), I would like to see this properly tested with a regression potential section filled in.

Also, this upload seems to add a Suggests: ubuntu-proxy-manager for jammy but there is no ubuntu-proxy-manager in jammy (and no upload in the queue).

Changed in adsys (Ubuntu Jammy):
status: New → Incomplete
Revision history for this message
Denison Barbosa (justdenis) wrote :

Hey, @sil2100! ubuntu-proxy-manager is just a suggested package and its absence does not impact adsys functionality. We have different situations for when the ubuntu-proxy-manager is present and when it isn't and both cases are tested.
We have plans for releasing it to Jammy later, but we made it a suggested package precisely so we wouldn't block adsys releases and SRUs on this package.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.