Ubuntu
lxc package

lxc-test-rootfs test regression with 4.0.10-0ubuntu3

  1. Impish (21.10)
  2. Bug #1938771
Bug #1938771 reported by Andrea Righi
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
lxc (Ubuntu)
Fix Released
Undecided
Christian Brauner
Impish
Fix Committed
Undecided
Christian Brauner

Bug Description

It looks like the option "lxc.rootfs.options = ro" is not honored with lxc 4.0.10-0ubuntu3 and it used to work with lxc 4.0.6-0ubuntu1 (kernel is the same, I'm testing this with 5.13.0-13.13).

Output of the test:

09:12 ubuntu@impish$ sudo ./src/tests/lxc-test-rootfs
+ PHASE=setup
+ trap cleanup EXIT
+ lxc-destroy -n lxc-test-rootfs -f
lxc-destroy: lxc-test-rootfs: tools/lxc_destroy.c: main: 242 Container is not defined
+ true
+ lxc-create -t busybox -n lxc-test-rootfs
+ PHASE=ro_rootfs
+ echo 'Starting phase ro_rootfs'
Starting phase ro_rootfs
+ config=/var/lib/lxc/lxc-test-rootfs/config
+ sed -i /lxc.rootfs.options/d /var/lib/lxc/lxc-test-rootfs/config
+ echo 'lxc.rootfs.options = ro'
+ lxc-start -n lxc-test-rootfs
++ lxc-info -n lxc-test-rootfs -p -H
+ pid=2147
+ ro=0
+ mkdir /proc/2147/root/rotest
+ '[' 0 -ne 0 ']'
+ cleanup
+ set +e
+ lxc-destroy -n lxc-test-rootfs -f
+ '[' ro_rootfs '!=' done ']'
+ echo 'rootfs test failed at ro_rootfs'
rootfs test failed at ro_rootfs
+ exit 1

Revision history for this message
Christian Brauner (cbrauner) wrote :

Thanks for reporting this. I've fixed this in:
https://github.com/lxc/lxc/pull/3921

Changed in lxc (Ubuntu Impish):
status: New → Confirmed
assignee: nobody → Christian Brauner (cbrauner)
Revision history for this message
Christian Brauner (cbrauner) wrote :

Also added tests around rootfs mount options.

Changed in lxc (Ubuntu Impish):
status: Confirmed → In Progress
Christian Brauner (cbrauner)
Changed in lxc (Ubuntu Impish):
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package lxc - 1:4.0.12-0ubuntu1

---------------
lxc (1:4.0.12-0ubuntu1) jammy; urgency=medium

  * Cherry-pick upstream bugfixes (stable-4.0):
    - 0002-lxc-checkconfig-Fix-bashism.patch
    - 0003-doc-Fix-reverse-allowlist-denylist.patch (LP: #1957934)

  * New upstream bugfix release (4.0.12):
    (https://discuss.linuxcontainers.org/t/lxc-4-0-12-has-been-released/13288)
    - Fixed CRIU restoration of containers with pre-created veth interfaces
    - Fixed issue with kernels lacking SMT support
    - Extended cgroup2 config options in lxc.mount.auto (cgroup2)
    - lxc-download now relies on HTTPS for validation (avoids GPG issues)

  * New upstream bugfix release (4.0.11)
    (LP: #1943441, LP: #1938771, LP: #1891903):
    (https://discuss.linuxcontainers.org/t/lxc-4-0-11-has-been-released/12427)
    - Core scheduling support (lxc.sched.core)
    - riscv64 support in lxc.arch
    - Significantly improved bash completion profile
    - Greater use of the new VFS mount API (when supported by the kernel)
    - Fix containers with empty network namespaces
    - Handle kernels that lack TIOCGPTPEER
    - Improve CPU bitmask/id handling (handle skipped CPU numbers)
    - Reworked the tests to run offline

  * Bump to debhelper 12 (allows focal SRUs)
  * Bump standards to 4.6.0.1
  * Add lintian overrides for incorrect bashism detection
  * Remove bash completion install logic (now done upstream)

 -- Stéphane Graber <email address hidden> Wed, 02 Feb 2022 20:48:39 -0500

Changed in lxc (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.