Ubuntu
symfony package

php-symfony-dependency-injection not working with php 8

  1. Focal (20.04)
  2. Bug #1932552
Bug #1932552 reported by Massimiliano Arione
24
This bug affects 2 people
Affects Status Importance Assigned to Milestone
phpMyAdmin
New
Unknown
symfony (Ubuntu)
Fix Released
Undecided
Unassigned
Focal
Confirmed
High
William Desportes

Bug Description

[ Impact ]

The user is unable to use phpMyAdmin or the related symfony library

[ Test Plan ]

# Reproduced using the 20.04.6 ISO

Run the following commands:

    apt update
    apt upgrade -y
# Install the "add-apt-repository" command
    apt install software-properties-common -y
    add-apt-repository ppa:phpmyadmin/ppa

# Install the deb sury repo
    apt-get -y install lsb-release ca-certificates curl

    curl -sSLo /usr/share/keyrings/deb.sury.org-php.gpg https://packages.sury.org/php/apt.gpg
    sh -c 'echo "deb [signed-by=/usr/share/keyrings/deb.sury.org-php.gpg] https://packages.sury.org/php/ bullseye main" > /etc/apt/sources.list.d/php.list'
    apt update
    apt install php8.2
    apt install mysql-server -y
    service mysql start
# Choose apache2 to auto configure and accept dbcommon setup
    apt install phpmyadmin
    service apache2 start

# Change the root password
    mysql -e "ALTER USER 'root'@'localhost' IDENTIFIED WITH mysql_native_password by 'public';"

# Browse: http://localhost/phpmyadmin/
# Login: root/public
# See the error "Unknown parameter $$dbi"

Apply the change in the merge request and login another time, now phpMyAdmin works !

[ Where problems could occur ]

 This exact fix was applied by users for years, there is nothing more to be afraid about.

[ Other Info ]

This has been fixed since jammy.

Recent report at phpMyAdmin: https://github.com/phpmyadmin/phpmyadmin/issues/18498
And the oldest on 20.04.2 LTS: https://github.com/phpmyadmin/phpmyadmin/issues/16968

Fixed by https://code.launchpad.net/~williamdes/ubuntu/+source/symfony/+git/symfony/+merge/442971

[ Original message ]

Package should be updated to symfony/dependency-injection:4.4.9 at least, since it's the first release of v4 that is supporting both php7 and php8. I think that, anyway, using current last available point release (that is 4.4.25) would be better.
See https://github.com/phpmyadmin/phpmyadmin/issues/16968 for a related bug.

See original description

Related branches

~williamdes/ubuntu/+source/symfony:ubuntu/focal-devel-php8-sru
Athos Ribeiro (community): Needs Fixing
Christian Ehrhardt : Pending requested
Diff: 79 lines (+47/-1)
4 files modified
debian/changelog (+8/-0)
debian/control (+2/-1)
debian/patches/Fix-ContainerBuilder-createService-for-PHP8.patch (+36/-0)
debian/patches/series (+1/-0)
~williamdes/ubuntu/+source/symfony:ubuntu/focal-devel-php8-sru
Athos Ribeiro (community): Needs Fixing
Christian Ehrhardt : Pending requested
Diff: 366 lines (+263/-0) (has conflicts)
5 files modified
debian/changelog (+210/-0)
debian/control (+7/-0)
debian/patches/Fix-ContainerBuilder-createService-for-PHP8.patch (+36/-0)
debian/patches/series (+4/-0)
debian/tests/phpunit (+6/-0)
Revision history for this message
Utkarsh Gupta (utkarsh) wrote :

Hello,

Impish (-propose) has 5.2.6+dfsg-1ubuntu7, which is hopefully what you want. And also works with PHP 8.0. We're currently in midst of the transition so that should happen soon. And that mean, it should soon migrate to Impish (-release).

Please enable the -propose pocket in case you want to use that *now*. But make sure you know what you're doing! :)

Changed in symfony (Ubuntu):
status: New → Fix Released
Revision history for this message
Utkarsh Gupta (utkarsh) wrote :

FWIW, 4.4.19+dfsg-1 is already available in Hirsute & Impish (-release). And 4.4.14+dfsg-1 in Groovy. So we've had > 4.4.9 for a while now. :)

Revision history for this message
Massimiliano Arione (garakkio) wrote :

Well, phpmyadmin is typically a package used in a server environment.
As you know, usual servers are kept on LTS releases.
Do you think an update for focal could be feasible?

Revision history for this message
Massimiliano Arione (garakkio) wrote :

Well, the weird thing is that you didn't have 4.4 in focal, being Symfony support release planned with a long advance.
Now 4.3 is out of support (even for security fixes) and I guess that this not nice for an LTS

Revision history for this message
Utkarsh Gupta (utkarsh) wrote :

Hello,

Unfortunately, this didn't work with the cycle & timeline we had. We can't do much about it now. But I guess I can try to add the patch for fixing this in Focal.

Changed in symfony (Ubuntu Focal):
status: New → Confirmed
Revision history for this message
Utkarsh Gupta (utkarsh) wrote :

Just to be clear, the fix for the problem is https://github.com/symfony/symfony/commit/8e34978e4e2c4bf7dac97e44e904368c4cfb54f8, correct?

Revision history for this message
William Desportes (williamdes) wrote :

Correct, this is the needed fix

Utkarsh Gupta (utkarsh)
Changed in symfony (Ubuntu Focal):
assignee: nobody → Utkarsh Gupta (utkarsh)
Revision history for this message
Łukasz (kanlukasz) wrote :

Hello

I would like to ask about any progress in fix this package in Focal?
Is there a chance that this fix will appear?

Many of us have problems with phpmyadmin apt because of this problem
- https://github.com/phpmyadmin/phpmyadmin/issues/17187
- https://github.com/phpmyadmin/phpmyadmin/issues/16968
- https://github.com/symfony/symfony/issues/38089
- https://github.com/phpmyadmin/phpmyadmin/issues/17197

PS. I'm not sure, but there is probably one more thing that is related to this issue
```
PHP Deprecated: Required parameter $arguments follows optional parameter $callable in /usr/share/php/Twig/Node/Expression/CallExpression.php on line 116
```
but I'm not sure where to report it

Revision history for this message
Utkarsh Gupta (utkarsh) wrote :

Hello,

This is in my list of things to do but I have other important things to do as well. Can someone help prepare this bug as an SRU bug with all the templating, et al?
cf: the first three points mentioned here: https://wiki.ubuntu.com/StableReleaseUpdates#Procedure

TIA! \o/

Revision history for this message
Łukasz (kanlukasz) wrote :

I don't know how this is possible, but I unassigned you. I'm sorry my mistake

Changed in symfony (Ubuntu Focal):
assignee: Utkarsh Gupta (utkarsh) → nobody
Revision history for this message
Utkarsh Gupta (utkarsh) wrote :

No problem, re-assigned. I intend to get to this bug this month.

Changed in symfony (Ubuntu Focal):
assignee: nobody → Utkarsh Gupta (utkarsh)
Bryce Harrington (bryce)
Changed in symfony (Ubuntu Focal):
importance: Undecided → High
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Utkarsh mentioned in #ubuntu-server that he is still planning to work on this bug.

Revision history for this message
William Desportes (williamdes) wrote :

I made an SRU for some phpMyAdmin stuff kind of related (https://bugs.launchpad.net/ubuntu/+source/phpmyadmin/+bug/2013402), I may work on this one if it's still on a LTS version that can have updates.

What versions should I make an SRU for ?

William Desportes (williamdes)
Changed in phpmyadmin:
importance: Unknown → High
Bug Watch Updater (bug-watch-updater)
Changed in phpmyadmin:
importance: High → Unknown
status: Unknown → New
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Utkarsh didn't work on this for a while and is busy elsewhere.
Removing the assignment to reflect that.

Since William offered to help let us embrace that \o/
@William - as the bug tasks show having a look at Focal is the LTS release that would still benefit from an SRU.

Changed in symfony (Ubuntu Focal):
assignee: Utkarsh Gupta (utkarsh) → nobody
Revision history for this message
William Desportes (williamdes) wrote :

Hi Christian,

I made a merge proposal: https://code.launchpad.net/~williamdes/ubuntu/+source/symfony/+git/symfony/+merge/442971

Changed in symfony (Ubuntu Focal):
assignee: nobody → William Desportes (williamdes)
Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

Hi William,

would you mind also filling in the SRU paperwork for this bug (as you did with the phpmyadmin ones)?

Revision history for this message
William Desportes (williamdes) wrote :

Here is the SRU https://bugs.launchpad.net/ubuntu/+source/symfony/+bug/2024615
And the merge: https://code.launchpad.net/~williamdes/ubuntu/+source/symfony/+git/symfony/+merge/442971

Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

Hi WIlliam,

As we agreed, I am moving the SRU template here and will mark LP: #2024615 as a duplicate.

description: updated
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.