Reduce NAPI weight in hns driver from 256 to 64
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
linux (Ubuntu) |
Incomplete
|
Undecided
|
Ike Panhc | ||
Bionic |
Fix Released
|
Undecided
|
Ike Panhc | ||
Cosmic |
Fix Committed
|
Undecided
|
Ike Panhc | ||
Disco |
Fix Released
|
Undecided
|
Ike Panhc | ||
Eoan |
Incomplete
|
Undecided
|
Ike Panhc |
Bug Description
[Impact]
We have a warning[1] in dmesg shows hns register napi as weight 256 but not recommended. According to this commit[2] we shall use weight 64 as suggested.
[1] netif_napi_add() called with weight 256
[2] https:/
[Test Case]
dmesg | grep netif_napi_add
[Fix]
commit acb1ce15a61154a
Author: Yonglong Liu <email address hidden>
Date: Thu Apr 4 16:46:43 2019 +0800
net: hns: Use NAPI_POLL_WEIGHT for hns driver
When the HNS driver loaded, always have an error print:
"netif_
This is because the kernel checks the NAPI polling weights
requested by drivers and it prints an error message if a driver
requests a weight bigger than 64.
So use NAPI_POLL_WEIGHT to fix it.
Signed-off-by: Yonglong Liu <email address hidden>
Signed-off-by: Peng Li <email address hidden>
Signed-off-by: David S. Miller <email address hidden>
[Regression Risk]
Only weight for NAPI changed. Lowest regression risk.
CVE References
Changed in linux (Ubuntu Eoan): | |
assignee: | nobody → Ike Panhc (ikepanhc) |
Changed in linux (Ubuntu Disco): | |
assignee: | nobody → Ike Panhc (ikepanhc) |
Changed in linux (Ubuntu Cosmic): | |
assignee: | nobody → Ike Panhc (ikepanhc) |
Changed in linux (Ubuntu Bionic): | |
assignee: | nobody → Ike Panhc (ikepanhc) |
description: | updated |
Changed in linux (Ubuntu Bionic): | |
status: | Incomplete → Fix Committed |
Changed in linux (Ubuntu Cosmic): | |
status: | Incomplete → Fix Committed |
Changed in linux (Ubuntu Disco): | |
status: | Incomplete → Fix Committed |
This bug is missing log files that will aid in diagnosing the problem. While running an Ubuntu kernel (not a mainline or third-party kernel) please enter the following command in a terminal window:
apport-collect 1830587
and then change the status of the bug to 'Confirmed'.
If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.
This change has been made by an automated script, maintained by the Ubuntu Kernel Team.