Ubuntu
ubuntu-advantage-tools package

'ua fix' tells me to reboot with inaccurate message

Bionic (18.04)
Bug #1926183

Bug #1926183 reported by James Troup on 2021-04-26

This bug affects 1 person

	Status	Importance	Assigned to
ubuntu-advantage-tools (Ubuntu)	Fix Released	Medium	Grant Orndorff
Xenial	Fix Released	Medium	Unassigned
Bionic	Fix Committed	Medium	Unassigned
Focal	Fix Committed	Medium	Unassigned
Groovy	Won't Fix	Medium	Unassigned
Hirsute	Won't Fix	Medium	Unassigned
Impish	Fix Released	Medium	Grant Orndorff

Bug Description

[Impact]

When using an affected version of uaclient (any beta of v27) and using the `fix` command, the user could be shown a misleading message. Specifically, if the users machine has the system reboot required flag set, and then they use the `ua fix` command, uaclient will say that a reboot is required to complete the fix, even though uaclient didn't even have to install anything.

[Test case]

The following example will work on xenial, bionic, focal, and groovy.

To reproduce on hirsute, use USN-4913-2 instead of USN-4898-1, and use node-underscore instead of curl in the instructions below.

To reproduce:

1. Launch a container: using focal here as an example
lxc launch ubuntu-daily:focal dev-f

2. Add the uaclient staging ppa: https://launchpad.net/~ua-client/+archive/ubuntu/staging
add-apt-repository ppa:ua-client/staging
apt-get update

3. Install version 27 beta 3
apt install ubuntu-advantage-tools=27.0~20.04.1~beta3

4. Make sure you have the latest version of curl installed
apt install curl

5. Touch the reboot-required file
sudo touch /var/run/reboot-required

6. Attempt to fix https://ubuntu.com/security/notices/USN-4898-1
ua fix USN-4898-1

7. See a message like this

USN-4898-1: curl vulnerabilities
Found CVEs:
https://ubuntu.com/security/CVE-2021-22890
https://ubuntu.com/security/CVE-2021-22876
1 affected package is installed: curl
(1/1) curl:
A fix is available in Ubuntu standard updates.
The update is already installed.
A reboot is required to complete fix operation.
✘ USN-4898-1 is not resolved.

To see the fixed version:

1. Launch a container: using focal here as an example
lxc launch ubuntu-daily:focal dev-f

2. Add this ppa that contains the unreleased fix for this bug: https://launchpad.net/~orndorffgrant/+archive/ubuntu/uaclient-staging-27
add-apt-repository ppa:orndorffgrant/uaclient-staging-27
apt-get update

3. Install version 27
apt install ubuntu-advantage-tools

4. Make sure you have the latest version of curl installed
apt install curl

5. Touch the reboot-required file
sudo touch /var/run/reboot-required

6. Attempt to fix https://ubuntu.com/security/notices/USN-4898-1
ua fix USN-4898-1

7. See a message like this

[Where problems could occur]

The logic of when to show the reboot required message is still based on the system /var/run/reboot-required flag, and this fix adds additional complexity to our messaging logic after fixing a cve/usn.

If this new logic isn't quite right, it may result in uaclient still saying that a reboot is required to complete a fix even when it isn't (for some other situation not in this bug).

Or from the opposite direction: if the logic is wrong, it could result in uaclient failing to tell the user that a reboot is required to complete a fix, even when it is.

More generally, the changeset is large and carries the risk of other unexpected issues. Any unexpected issues would be limited to uaclient behavior though.

[Discussion]

This bug doesn't actually exist outside of the v27 betas in the ua-client/staging ppa. The number of users affected by this bug is very low and almost entirely limited to those who were deliberately testing the v27 betas. Because of this, the risk associated with fixing this bug is predicted to be very low.

[Original Report]

root@malefic:~# ua fix CVE-2021-3410
CVE-2021-3410: libcaca vulnerability
https://ubuntu.com/security/CVE-2021-3410
1 affected package is installed: libcaca
(1/1) libcaca:
A fix is available in Ubuntu standard updates.
The update is already installed.
A reboot is required to complete fix operation.
✘ CVE-2021-3410 is not resolved.
root@malefic:~#

The line 'A reboot is required to complete fix operation.' may be partially true (i.e. a reboot is needed) for other reasons, but is not accurate in the context of this CVE. Both 'checkrestart' and 'needrestart' confirm that no running process is using the caca library. Looking at the code, it looks like it's looking at a global 'needs reboot' flag, unrelated to the specific fix operation. I'd argue that a) it shouldn't say 'to complete fix operation' and b) it shouldn't claim 'CVE-2021-3410 is not resolved'.

See original description

Tags:

Related branches

~chad.smith/ubuntu/+source/ubuntu-advantage-tools:release-27-hirsute

Merged into ubuntu/+source/ubuntu-advantage-tools:ubuntu/hirsute-proposed at revision fc4f806498fc0c73631fa698e2fb37ec96b35b60

Bryce Harrington (community): Approve on 2021-04-28

Diff: 12713 lines (+8514/-712)

88 files modified

.gitignore (+24/-0)
Jenkinsfile (+28/-35)
README.md (+29/-12)
RELEASES.md (+63/-4)
apt-hook/20apt-esm-hook.conf (+10/-2)
apt-hook/Makefile (+11/-4)
apt-hook/hook.cc (+264/-74)
apt-hook/json-hook-src/go.mod (+3/-0)
apt-hook/json-hook-src/json-hook.go (+253/-0)
apt-hook/json-hook-src/json-hook_test.go (+410/-0)
debian/changelog (+160/-1)
debian/control (+8/-2)
debian/lintian-overrides (+5/-0)
debian/po/templates.pot (+2/-2)
debian/rules (+10/-2)
debian/ubuntu-advantage-tools.config (+14/-0)
debian/ubuntu-advantage-tools.postinst (+150/-40)
debian/ubuntu-advantage-tools.templates (+1/-1)
dev/null (+0/-0)
features/attach_invalidtoken.feature (+1/-1)
features/attach_validtoken.feature (+63/-28)
features/attached_commands.feature (+12/-12)
features/attached_enable.feature (+62/-118)
features/cloud.py (+0/-12)
features/environment.py (+27/-17)
features/gcp-ids.yaml (+3/-3)
features/staging_commands.feature (+50/-5)
features/steps/steps.py (+75/-3)
features/ubuntu_pro.feature (+39/-9)
features/unattached_commands.feature (+388/-3)
features/util.py (+0/-81)
integration-requirements.txt (+1/-1)
lib/reboot_cmds.py (+12/-8)
lib/ua_update_messaging.py (+302/-0)
setup.py (+1/-0)
systemd/ua-messaging.service (+8/-0)
systemd/ua-messaging.timer (+11/-0)
tools/test_xenial_upgrade.sh (+224/-0)
tools/tox-lxd-runner (+2/-2)
tox.ini (+2/-2)
uaclient-devel.conf (+1/-0)
uaclient.conf (+1/-0)
uaclient/apt.py (+1/-0)
uaclient/cli.py (+87/-18)
uaclient/clouds/identity.py (+12/-0)
uaclient/clouds/tests/test_identity.py (+31/-0)
uaclient/config.py (+136/-8)
uaclient/contract.py (+1/-2)
uaclient/defaults.py (+10/-1)
uaclient/entitlements/esm.py (+53/-7)
uaclient/entitlements/fips.py (+9/-3)
uaclient/entitlements/livepatch.py (+3/-3)
uaclient/entitlements/repo.py (+3/-3)
uaclient/entitlements/tests/test_base.py (+2/-2)
uaclient/entitlements/tests/test_cc.py (+1/-1)
uaclient/entitlements/tests/test_esm.py (+145/-34)
uaclient/entitlements/tests/test_fips.py (+38/-1)
uaclient/entitlements/tests/test_livepatch.py (+8/-6)
uaclient/entitlements/tests/test_repo.py (+1/-1)
uaclient/exceptions.py (+12/-0)
uaclient/gpg.py (+1/-1)
uaclient/security.py (+1179/-0)
uaclient/serviceclient.py (+19/-2)
uaclient/status.py (+237/-37)
uaclient/testing/fakes.py (+4/-1)
uaclient/tests/test_apt.py (+5/-1)
uaclient/tests/test_cli.py (+2/-0)
uaclient/tests/test_cli_attach.py (+33/-3)
uaclient/tests/test_cli_auto_attach.py (+28/-0)
uaclient/tests/test_cli_detach.py (+31/-2)
uaclient/tests/test_cli_disable.py (+27/-3)
uaclient/tests/test_cli_enable.py (+31/-7)
uaclient/tests/test_cli_fix.py (+78/-0)
uaclient/tests/test_cli_refresh.py (+20/-1)
uaclient/tests/test_cli_status.py (+81/-7)
uaclient/tests/test_config.py (+162/-31)
uaclient/tests/test_contract.py (+1/-8)
uaclient/tests/test_reboot_cmds.py (+48/-1)
uaclient/tests/test_security.py (+2344/-0)
uaclient/tests/test_serviceclient.py (+24/-0)
uaclient/tests/test_status.py (+49/-1)
uaclient/tests/test_ua_update_messaging.py (+469/-0)
uaclient/tests/test_util.py (+237/-9)
uaclient/tests/test_version.py (+10/-3)
uaclient/util.py (+101/-18)
uaclient/version.py (+2/-2)
update-motd.d/88-esm-announce (+4/-0)
update-motd.d/91-contract-ua-esm-status (+4/-0)

~lamoura/ubuntu/+source/ubuntu-advantage-tools:hirsute-devel-release-27

Ready for review for merging into ubuntu/+source/ubuntu-advantage-tools:ubuntu/hirsute-devel

Bryce Harrington (community): Approve on 2021-04-27

Diff: 12025 lines (+8488/-712)

87 files modified

Jenkinsfile (+28/-35)
README.md (+29/-12)
RELEASES.md (+63/-4)
apt-hook/20apt-esm-hook.conf (+10/-2)
apt-hook/Makefile (+11/-4)
apt-hook/hook.cc (+264/-74)
apt-hook/json-hook-src/go.mod (+3/-0)
apt-hook/json-hook-src/json-hook.go (+253/-0)
apt-hook/json-hook-src/json-hook_test.go (+410/-0)
debian/changelog (+158/-1)
debian/control (+8/-2)
debian/lintian-overrides (+5/-0)
debian/po/templates.pot (+2/-2)
debian/rules (+10/-2)
debian/ubuntu-advantage-tools.config (+14/-0)
debian/ubuntu-advantage-tools.postinst (+150/-40)
debian/ubuntu-advantage-tools.templates (+1/-1)
dev/null (+0/-0)
features/attach_invalidtoken.feature (+1/-1)
features/attach_validtoken.feature (+63/-28)
features/attached_commands.feature (+12/-12)
features/attached_enable.feature (+62/-118)
features/cloud.py (+0/-12)
features/environment.py (+27/-17)
features/gcp-ids.yaml (+3/-3)
features/staging_commands.feature (+50/-5)
features/steps/steps.py (+75/-3)
features/ubuntu_pro.feature (+39/-9)
features/unattached_commands.feature (+388/-3)
features/util.py (+0/-81)
integration-requirements.txt (+1/-1)
lib/reboot_cmds.py (+12/-8)
lib/ua_update_messaging.py (+302/-0)
setup.py (+1/-0)
systemd/ua-messaging.service (+8/-0)
systemd/ua-messaging.timer (+11/-0)
tools/test_xenial_upgrade.sh (+224/-0)
tools/tox-lxd-runner (+2/-2)
tox.ini (+2/-2)
uaclient-devel.conf (+1/-0)
uaclient.conf (+1/-0)
uaclient/apt.py (+1/-0)
uaclient/cli.py (+87/-18)
uaclient/clouds/identity.py (+12/-0)
uaclient/clouds/tests/test_identity.py (+31/-0)
uaclient/config.py (+136/-8)
uaclient/contract.py (+1/-2)
uaclient/defaults.py (+10/-1)
uaclient/entitlements/esm.py (+53/-7)
uaclient/entitlements/fips.py (+9/-3)
uaclient/entitlements/livepatch.py (+3/-3)
uaclient/entitlements/repo.py (+3/-3)
uaclient/entitlements/tests/test_base.py (+2/-2)
uaclient/entitlements/tests/test_cc.py (+1/-1)
uaclient/entitlements/tests/test_esm.py (+145/-34)
uaclient/entitlements/tests/test_fips.py (+38/-1)
uaclient/entitlements/tests/test_livepatch.py (+8/-6)
uaclient/entitlements/tests/test_repo.py (+1/-1)
uaclient/exceptions.py (+12/-0)
uaclient/gpg.py (+1/-1)
uaclient/security.py (+1179/-0)
uaclient/serviceclient.py (+19/-2)
uaclient/status.py (+237/-37)
uaclient/testing/fakes.py (+4/-1)
uaclient/tests/test_apt.py (+5/-1)
uaclient/tests/test_cli.py (+2/-0)
uaclient/tests/test_cli_attach.py (+33/-3)
uaclient/tests/test_cli_auto_attach.py (+28/-0)
uaclient/tests/test_cli_detach.py (+31/-2)
uaclient/tests/test_cli_disable.py (+27/-3)
uaclient/tests/test_cli_enable.py (+31/-7)
uaclient/tests/test_cli_fix.py (+78/-0)
uaclient/tests/test_cli_refresh.py (+20/-1)
uaclient/tests/test_cli_status.py (+81/-7)
uaclient/tests/test_config.py (+162/-31)
uaclient/tests/test_contract.py (+1/-8)
uaclient/tests/test_reboot_cmds.py (+48/-1)
uaclient/tests/test_security.py (+2344/-0)
uaclient/tests/test_serviceclient.py (+24/-0)
uaclient/tests/test_status.py (+49/-1)
uaclient/tests/test_ua_update_messaging.py (+469/-0)
uaclient/tests/test_util.py (+237/-9)
uaclient/tests/test_version.py (+10/-3)
uaclient/util.py (+101/-18)
uaclient/version.py (+2/-2)
update-motd.d/88-esm-announce (+4/-0)
update-motd.d/91-contract-ua-esm-status (+4/-0)

CVE References

Revision history for this message

James Troup (elmo) wrote on 2021-04-26:

ubuntu-advantage-tools 27.0~20.10.1~beta3 on 20.10/amd64.

Revision history for this message

Richard Harding (rharding) wrote on 2021-04-26:

Thanks for the report.

Yes I can see the reboot conflicting there. We generally are showing that if the system indicates a reboot is required to try to get the user to an all-green state, but here in ua fix it is distracting.

The fact that it says it was not resolved though is completely incorrect and so that we will address it.

Revision history for this message

Grant Orndorff (orndorffgrant) wrote on 2021-04-27:

We have a PR up addressing this bug here: https://github.com/canonical/ubuntu-advantage-client/pull/1577

After that PR is merged, ua will not print "A reboot is required to complete fix operation. ✘ CVE-2021-3410 is not resolved." when the update is already installed. It will instead only print: "✔ CVE-2021-3410 is resolved", even if the global 'needs reboot' flag is set.

Chad Smith (chad.smith) on 2021-04-27

Changed in ubuntu-advantage-tools (Ubuntu):
status:	New → In Progress
assignee:	nobody → Grant Orndorff (orndorffgrant)
importance:	Undecided → Medium

Grant Orndorff (orndorffgrant) on 2021-04-27

Changed in ubuntu-advantage-tools (Ubuntu):
status:	In Progress → Fix Committed

Grant Orndorff (orndorffgrant) on 2021-04-27

description:

updated

Grant Orndorff (orndorffgrant) on 2021-04-27

description:

updated

Grant Orndorff (orndorffgrant) on 2021-04-27

description:	updated
description:	updated

Grant Orndorff (orndorffgrant) on 2021-04-27

description:

updated

Grant Orndorff (orndorffgrant) on 2021-04-27

description:

updated

Grant Orndorff (orndorffgrant) on 2021-04-27

description:

updated

Grant Orndorff (orndorffgrant) on 2021-04-27

description:

updated

Bryce Harrington (bryce) on 2021-04-27

Changed in ubuntu-advantage-tools (Ubuntu Hirsute):
importance:	Undecided → Medium
Changed in ubuntu-advantage-tools (Ubuntu Groovy):
importance:	Undecided → Medium
Changed in ubuntu-advantage-tools (Ubuntu Focal):
importance:	Undecided → Medium
Changed in ubuntu-advantage-tools (Ubuntu Bionic):
importance:	Undecided → Medium
Changed in ubuntu-advantage-tools (Ubuntu Xenial):
importance:	Undecided → Medium
Changed in ubuntu-advantage-tools (Ubuntu Groovy):
importance:	Medium → Undecided
Changed in ubuntu-advantage-tools (Ubuntu Impish):
status:	Fix Committed → In Progress

Grant Orndorff (orndorffgrant) on 2021-04-28

description:

updated

Revision history for this message

Robie Basak (racb) wrote on 2021-04-29: Please test proposed package

Hello James, or anyone else affected,

Accepted ubuntu-advantage-tools into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ubuntu-advantage-tools/27.0~16.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in ubuntu-advantage-tools (Ubuntu Xenial):
status:	New → Fix Committed
tags:	added: verification-needed verification-needed-xenial

Revision history for this message

Robie Basak (racb) wrote on 2021-04-29:

Hello James, or anyone else affected,

Accepted ubuntu-advantage-tools into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ubuntu-advantage-tools/27.0~18.04.1 in a few hours, and then in the -proposed repository.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in ubuntu-advantage-tools (Ubuntu Bionic):
status:	New → Fix Committed
tags:	added: verification-needed-bionic
Changed in ubuntu-advantage-tools (Ubuntu Focal):
status:	New → Fix Committed
tags:	added: verification-needed-focal

Revision history for this message

Robie Basak (racb) wrote on 2021-04-29:

Hello James, or anyone else affected,

Accepted ubuntu-advantage-tools into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ubuntu-advantage-tools/27.0~20.04.1 in a few hours, and then in the -proposed repository.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in ubuntu-advantage-tools (Ubuntu Groovy):
status:	New → Fix Committed
tags:	added: verification-needed-groovy

Revision history for this message

Robie Basak (racb) wrote on 2021-04-29:

Hello James, or anyone else affected,

Accepted ubuntu-advantage-tools into groovy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ubuntu-advantage-tools/27.0~20.10.1 in a few hours, and then in the -proposed repository.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-groovy to verification-done-groovy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-groovy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in ubuntu-advantage-tools (Ubuntu Hirsute):
status:	New → Fix Committed
tags:	added: verification-needed-hirsute

Revision history for this message

Robie Basak (racb) wrote on 2021-04-29:

Hello James, or anyone else affected,

Accepted ubuntu-advantage-tools into hirsute-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/ubuntu-advantage-tools/27.0~21.04.1 in a few hours, and then in the -proposed repository.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-hirsute to verification-done-hirsute. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-hirsute. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Chad Smith (chad.smith) on 2021-04-29

Changed in ubuntu-advantage-tools (Ubuntu Impish):
status:	In Progress → Fix Committed

Richard Harding (rharding) on 2021-04-29

tags:

added: verification-done-xenial
removed: verification-needed-xenial

Revision history for this message

Chad Smith (chad.smith) wrote on 2021-04-29:

Logs from Xenial test run asserting that no reboot needed message reported:
csmith@uptown:~/src/ubuntu-advantage-client$ cat proposed.yaml
#cloud-config
write_files:
- content: ZGViIGh0dHA6Ly9hcmNoaXZlLnVidW50dS5jb20vdWJ1bnR1LyB4ZW5pYWwtcHJvcG9zZWQgcmVzdHJpY3RlZCBtYWluIG11bHRpdmVyc2UgdW5pdmVyc2UK
  encoding: b64
  owner: root:root
  path: /etc/apt/sources.list.d/proposed-ua.list
  permissions: '0644'

package_update: true
packages: [ubuntu-advantage-tools]
csmith@uptown:~/src/ubuntu-advantage-client$ lxc launch ubuntu-daily:xenial sru-test-1926183 -c user.user-data="$(cat proposed.yaml)"
Creating sru-test-1926183
Starting sru-test-1926183
csmith@uptown:~/src/ubuntu-advantage-client$ lxc exec sru-test-1926183 bash
root@sru-test-1926183:~# touch /var/run/reboot-required
root@sru-test-1926183:~# cloud-init status --wait --long

status: done
time: Thu, 29 Apr 2021 23:07:07 +0000
detail:
DataSourceNoCloud [seed=/var/lib/cloud/seed/nocloud-net][dsmode=net]
root@sru-test-1926183:~# ua version
27.0~16.04.1
root@sru-test-1926183:~# apt policy ubuntu-advantage-tools
ubuntu-advantage-tools:
  Installed: 27.0~16.04.1
  Candidate: 27.0~16.04.1
  Version table:
*** 27.0~16.04.1 500
        500 http://archive.ubuntu.com/ubuntu xenial-proposed/main amd64 Packages
        100 /var/lib/dpkg/status
     10ubuntu0.16.04.1 500
        500 http://archive.ubuntu.com/ubuntu xenial-updates/main amd64 Packages
root@sru-test-1926183:~# ua fix USN-4898-1
USN-4898-1: curl vulnerabilities
Found CVEs:
https://ubuntu.com/security/CVE-2021-22890
https://ubuntu.com/security/CVE-2021-22876
1 affected package is installed: curl
(1/1) curl:
A fix is available in Ubuntu standard updates.
The update is already installed.
✔ USN-4898-1 is resolved.

Revision history for this message

Launchpad Janitor (janitor) wrote on 2021-04-29:

#10

This bug was fixed in the package ubuntu-advantage-tools - 27.0~16.04.1

---------------
ubuntu-advantage-tools (27.0~16.04.1) xenial; urgency=medium

  * New upstream release 27.0: (LP: #1926361)
    - apt-hook: mitigate failures with true
    - messages: add optional (s) to apt messaging to include
      singular/plural pkgs
    - apt-hook: avoid reporting and counting duplicate package
      names (GH: #1578)
    - fix: don't say reboot required when unnecessary (LP: #1926183)
    - test: uncomment additional xenial upgrade tests

-- Lucas Moura <email address hidden> Tue, 27 Apr 2021 15:31:06 -0300

Changed in ubuntu-advantage-tools (Ubuntu Xenial):
status:	Fix Committed → Fix Released

Revision history for this message

Steve Langasek (vorlon) wrote on 2021-04-29: Update Released

#11

The verification of the Stable Release Update for ubuntu-advantage-tools has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message

Ubuntu SRU Bot (ubuntu-sru-bot) wrote on 2021-04-30: Autopkgtest regression report (ubuntu-advantage-tools/27.0~21.04.1)

#12

All autopkgtests for the newly accepted ubuntu-advantage-tools (27.0~21.04.1) for hirsute have finished running.
The following regressions have been reported in tests triggered by the package:

ubuntu-advantage-tools/27.0~21.04.1 (i386)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/hirsute/update_excuses.html#ubuntu-advantage-tools

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Revision history for this message

Ubuntu SRU Bot (ubuntu-sru-bot) wrote on 2021-04-30: Autopkgtest regression report (ubuntu-advantage-tools/27.0~20.04.1)

#13

All autopkgtests for the newly accepted ubuntu-advantage-tools (27.0~20.04.1) for focal have finished running.
The following regressions have been reported in tests triggered by the package:

ubuntu-advantage-tools/27.0~20.04.1 (i386)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/focal/update_excuses.html#ubuntu-advantage-tools

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Revision history for this message

Chad Smith (chad.smith) wrote on 2021-05-01:

#14

Download full text (22.0 KiB)

Bionic Focal, Groovy and Hirsute test runs:

Test procedure:
1. install u-a-tools from <release>-proposed pocket using cloud-init
2. touch external reboot-required flag file to simulate a system which already needs a reboot from an unrelated package install.
3. run ua fix on an issue that will not install any packages
4. confirm ua tooling doesn't report reboot required.
5. Expect SUCCESS if no reboot suggested FAILURE otherwise

TLDR: All SUCCESS msgs, no reboot required messaging if ua fix hasn't installing debs.

==== test script ======

#!/bin/bash
set -e

for release in bionic focal groovy hirsute; do
echo "======= START $release ========"

  name=test-sru-1926183-$release
  case "${release}" in
      hirsute) lxc exec $name apt install samba; issue="CVE-2021-20254";;
      *) issue="CVE-2020-8285";;
  esac
  lxc stop $name || true
  lxc delete $name || true
  lxc launch ubuntu-daily:$release $name -c user.user-data="$( cat proposed-$release.yaml )"
  sleep 3;
  lxc exec $name -- cloud-init status --wait --long
  lxc exec $name -- ua version
  echo "====== Check ua tools 27.0 ====="
  lxc exec $name -- apt policy ubuntu-advantage-tools
  lxc exec $name -- apt install ${downgrade}
  lxc exec $name -- touch /var/run/reboot-required
  echo "====== Check no reboot required message on NOOP ===="
  MSG=`lxc exec $name -- ua fix $issue`
  echo $MSG
  echo $MSG| grep -q reboot && echo "FAILURE: reboot required message found when no pkg changes made" || echo "SUCCESS: no reboot required message"
  echo "======= END $release ========"
done

Bionic Focal, Groovy and Hirsute test runs:

Test procedure: 
1. install u-a-tools from <release>-proposed pocket using cloud-init
2. touch external reboot-required flag file to simulate a system which already needs a reboot from an unrelated package install.
3. run ua fix on an issue that will not install any packages
4. confirm ua tooling doesn't report reboot required.
5. Expect SUCCESS if no reboot suggested FAILURE otherwise

TLDR: All SUCCESS msgs, no reboot required messaging if ua fix hasn't installing debs.

==== test script ======

#!/bin/bash
set -e

for release in bionic focal groovy hirsute; do 
  echo "======= START $release ========"

======= START bionic ========
Creating test-sru-1926183-bionic
Starting test-sru-1926183-bionic
..............................................................................
status: done
time: Fri, 30 Apr 2021 23:26:23 +0000
detail:
DataSourceNoCloud [seed=/var/lib/cloud/seed/nocloud-net][dsmode=net]
27.0~18.04.1
====== Check ua tools 27.0 =====
ubuntu-advantage-tools:
  Installed: 27.0~18.04.1
  Candidate: 27.0~18.04.1
  Version table:
 *** 27.0~18.04.1 500
        500 http://archive.ubuntu.com/ubuntu bionic-proposed/main amd64 Packages
        100 /var/lib/dpkg/status
     17 500
        500 http://archive.ubuntu.com/ubuntu bionic/main amd64 Packages
Reading package lists... Done
Building dependency tree       
Reading state information... Done
The following package was automatically installed and is no longer required:
  libfreetype6
Use 'apt autoremove' to remove it.
0 upgraded, 0 newly installed, 0 to remove and 33 not upgraded.
====== Check no reboot required message on NOOP ====
CVE-2020-8285: curl vulnerabilities https://ubuntu.com/security/CVE-2020-8285 1 affected package is installed: curl (1/1) curl: A fix is available in Ubuntu standard updates. The update is already installed. ✔ CVE-2020-8285 is resolved.
SUCCESS: no reboot required message
======= END bionic ========
======= START focal ========
Creating test-sru-1926183-focal
Starting test-sru-1926183-focal
........................................................................................................................
status: done
time: Fri, 30 Apr 2021 23:27:07 +0000
detail:
DataSourceNoCloud [seed=/var/lib/cloud/seed/nocloud-net][dsmode=net]
27.0~20.04.1
====== Check ua tools 27.0 =====
ubuntu-advantage-tools:
  Installed: 27.0~20.04.1
  Candidate: 27.0~20.04.1
  Version table:
 *** 27.0~20.04.1 500
        500 http://archive.ubuntu.com/ubuntu focal-proposed/main amd64 Packages
        100 /var/lib/dpkg/status
     20.3 500
        500 http://archive.ubuntu.com/ubuntu focal/main amd64 Packages
Reading package lists... Done
Building dependency tree       
Reading state information... Done
The following package was automatically installed and is no longer required:
  libfreetype6
Use 'apt autoremove' to remove it.
0 upgraded, 0 newly installed, 0 to remove and 22 not upgraded.
====== Check no reboot required message on NOOP ====
CVE-2020-8285: curl vulnerabilities https://ubuntu.com/security/CVE-2020-8285 1 affected package is installed: curl (1/1) curl: A fix is available in Ubuntu standard updates. The update is already installed. ✔ CVE-2020-8285 is resolved.
SUCCESS: no reboot required message
======= END focal ========
======= START groovy ========
Creating test-sru-1926183-groovy
Starting test-sru-1926183-groovy
.................................................................................................................
status: done
time: Fri, 30 Apr 2021 23:27:48 +0000
detail:
DataSourceNoCloud [seed=/var/lib/cloud/seed/nocloud-net][dsmode=net]
27.0~20.10.1
====== Check ua tools 27.0 =====
ubuntu-advantage-tools:
  Installed: 27.0~20.10.1
  Candidate: 27.0~20.10.1
  Version table:
 *** 27.0~20.10.1 500
        500 http://archive.ubuntu.com/ubuntu groovy-proposed/main amd64 Packages
        100 /var/lib/dpkg/status
     24.4 500
        500 http://archive.ubuntu.com/ubuntu groovy/main amd64 Packages
Reading package lists... Done
Building dependency tree       
Reading state information... Done
The following package was automatically installed and is no longer required:
  libfreetype6
Use 'apt autoremove' to remove it.
0 upgraded, 0 newly installed, 0 to remove and 28 not upgraded.
====== Check no reboot required message on NOOP ====
CVE-2020-8285: curl vulnerabilities https://ubuntu.com/security/CVE-2020-8285 1 affected package is installed: curl (1/1) curl: A fix is available in Ubuntu standard updates. The update is already installed. ✔ CVE-2020-8285 is resolved.
SUCCESS: no reboot required message
======= END groovy ========

======= START hirsute ========
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
The following package was automatically installed and is no longer required:
  libfreetype6
Use 'apt autoremove' to remove it.
The following additional packages will be installed:
  attr ibverbs-providers libavahi-client3 libavahi-common-data
  libavahi-common3 libboost-iostreams1.74.0 libboost-thread1.74.0 libcephfs2
  libcups2 libibverbs1 libjansson4 libldb2 libnl-route-3-200 librados2
  librdmacm1 libtalloc2 libtevent0 liburing1 libwbclient0 python3-dnspython
  python3-ecdsa python3-gpg python3-ldb python3-markdown python3-pycryptodome
  python3-pygments python3-samba python3-talloc python3-tdb samba-common
  samba-common-bin samba-dsdb-modules samba-libs samba-vfs-modules tdb-tools
Suggested packages:
  cups-common python-markdown-doc python-pygments-doc ttf-bitstream-vera bind9
  bind9utils ctdb ldb-tools ntp | chrony smbldap-tools winbind heimdal-clients
The following NEW packages will be installed:
  attr ibverbs-providers libavahi-client3 libavahi-common-data
  libavahi-common3 libboost-iostreams1.74.0 libboost-thread1.74.0 libcephfs2
  libcups2 libibverbs1 libjansson4 libldb2 libnl-route-3-200 librados2
  librdmacm1 libtalloc2 libtevent0 liburing1 libwbclient0 python3-dnspython
  python3-ecdsa python3-gpg python3-ldb python3-markdown python3-pycryptodome
  python3-pygments python3-samba python3-talloc python3-tdb samba samba-common
  samba-common-bin samba-dsdb-modules samba-libs samba-vfs-modules tdb-tools
0 upgraded, 36 newly installed, 0 to remove and 16 not upgraded.
Need to get 27.3 MB of archives.
After this operation, 137 MB of additional disk space will be used.
Do you want to continue? [Y/n] y
Get:1 http://archive.ubuntu.com/ubuntu hirsute/main amd64 libtalloc2 amd64 2.3.1-2ubuntu1 [24.4 kB]
Get:2 http://archive.ubuntu.com/ubuntu hirsute/main amd64 libtevent0 amd64 0.10.2-1 [35.5 kB]
Get:3 http://archive.ubuntu.com/ubuntu hirsute-updates/main amd64 libwbclient0 amd64 2:4.13.3+dfsg-1ubuntu2.1 [209 kB]
Get:4 http://archive.ubuntu.com/ubuntu hirsute/main amd64 python3-dnspython all 2.0.0+really1.16.0-2ubuntu2 [96.9 kB]
Get:5 http://archive.ubuntu.com/ubuntu hirsute/main amd64 libldb2 amd64 2:2.2.0-3ubuntu2 [141 kB]
Get:6 http://archive.ubuntu.com/ubuntu hirsute/main amd64 python3-ldb amd64 2:2.2.0-3ubuntu2 [38.0 kB]
Get:7 http://archive.ubuntu.com/ubuntu hirsute/main amd64 python3-tdb amd64 1.4.3-1build1 [13.8 kB]
Get:8 http://archive.ubuntu.com/ubuntu hirsute/main amd64 libavahi-common-data amd64 0.8-5ubuntu3 [24.0 kB]
Get:9 http://archive.ubuntu.com/ubuntu hirsute/main amd64 libavahi-common3 amd64 0.8-5ubuntu3 [21.9 kB]
Get:10 http://archive.ubuntu.com/ubuntu hirsute/main amd64 libavahi-client3 amd64 0.8-5ubuntu3 [25.7 kB]
Get:11 http://archive.ubuntu.com/ubuntu hirsute/main amd64 libcups2 amd64 2.3.3op2-3ubuntu3 [234 kB]
Get:12 http://archive.ubuntu.com/ubuntu hirsute/main amd64 libjansson4 amd64 2.13.1-1.1build1 [30.2 kB]
Get:13 http://archive.ubuntu.com/ubuntu hirsute/main amd64 python3-talloc amd64 2.3.1-2ubuntu1 [12.2 kB]
Get:14 http://archive.ubuntu.com/ubuntu hirsute-updates/main amd64 samba-libs amd64 2:4.13.3+dfsg-1ubuntu2.1 [5597 kB]
Get:15 http://archive.ubuntu.com/ubuntu hirsute-updates/main amd64 python3-samba amd64 2:4.13.3+dfsg-1ubuntu2.1 [2623 kB]
Get:16 http://archive.ubuntu.com/ubuntu hirsute-updates/main amd64 samba-common all 2:4.13.3+dfsg-1ubuntu2.1 [64.6 kB]
Get:17 http://archive.ubuntu.com/ubuntu hirsute-updates/main amd64 samba-common-bin amd64 2:4.13.3+dfsg-1ubuntu2.1 [559 kB]
Get:18 http://archive.ubuntu.com/ubuntu hirsute/main amd64 tdb-tools amd64 1.4.3-1build1 [24.9 kB]
Get:19 http://archive.ubuntu.com/ubuntu hirsute-updates/main amd64 samba amd64 2:4.13.3+dfsg-1ubuntu2.1 [1046 kB]
Get:20 http://archive.ubuntu.com/ubuntu hirsute/main amd64 attr amd64 1:2.4.48-6build1 [22.0 kB]
Get:21 http://archive.ubuntu.com/ubuntu hirsute/main amd64 libnl-route-3-200 amd64 3.4.0-1build2 [151 kB]
Get:22 http://archive.ubuntu.com/ubuntu hirsute/main amd64 libibverbs1 amd64 33.1-1ubuntu1 [57.5 kB]
Get:23 http://archive.ubuntu.com/ubuntu hirsute/main amd64 ibverbs-providers amd64 33.1-1ubuntu1 [250 kB]
Get:24 http://archive.ubuntu.com/ubuntu hirsute/main amd64 libboost-iostreams1.74.0 amd64 1.74.0-8ubuntu2 [238 kB]
Get:25 http://archive.ubuntu.com/ubuntu hirsute/main amd64 libboost-thread1.74.0 amd64 1.74.0-8ubuntu2 [253 kB]
Get:26 http://archive.ubuntu.com/ubuntu hirsute/main amd64 librdmacm1 amd64 33.1-1ubuntu1 [65.9 kB]
Get:27 http://archive.ubuntu.com/ubuntu hirsute-proposed/main amd64 librados2 amd64 16.2.1-0ubuntu0.21.04.1 [3189 kB]
Get:28 http://archive.ubuntu.com/ubuntu hirsute-proposed/main amd64 libcephfs2 amd64 16.2.1-0ubuntu0.21.04.1 [676 kB]
Get:29 http://archive.ubuntu.com/ubuntu hirsute/main amd64 liburing1 amd64 0.7-3ubuntu1 [9028 B]
Get:30 http://archive.ubuntu.com/ubuntu hirsute/main amd64 python3-ecdsa all 0.16.1-1 [82.9 kB]
Get:31 http://archive.ubuntu.com/ubuntu hirsute/main amd64 python3-gpg amd64 1.14.0-1ubuntu3 [173 kB]
Get:32 http://archive.ubuntu.com/ubuntu hirsute/main amd64 python3-markdown all 3.3.4-1 [67.2 kB]
Get:33 http://archive.ubuntu.com/ubuntu hirsute/main amd64 python3-pycryptodome amd64 3.9.7+dfsg1-1build3 [9939 kB]
Get:34 http://archive.ubuntu.com/ubuntu hirsute/main amd64 python3-pygments all 2.7.1+dfsg-2ubuntu1 [639 kB]
Get:35 http://archive.ubuntu.com/ubuntu hirsute-updates/main amd64 samba-dsdb-modules amd64 2:4.13.3+dfsg-1ubuntu2.1 [282 kB]
Get:36 http://archive.ubuntu.com/ubuntu hirsute-updates/main amd64 samba-vfs-modules amd64 2:4.13.3+dfsg-1ubuntu2.1 [376 kB]
Fetched 27.3 MB in 4s (6759 kB/s)           
Extracting templates from packages: 100%
Preconfiguring packages ...
Selecting previously unselected package libtalloc2:amd64.
(Reading database ... 32901 files and directories currently installed.)
Preparing to unpack .../00-libtalloc2_2.3.1-2ubuntu1_amd64.deb ...
Unpacking libtalloc2:amd64 (2.3.1-2ubuntu1) ...
Selecting previously unselected package libtevent0:amd64.
Preparing to unpack .../01-libtevent0_0.10.2-1_amd64.deb ...
Unpacking libtevent0:amd64 (0.10.2-1) ...
Selecting previously unselected package libwbclient0:amd64.
Preparing to unpack .../02-libwbclient0_2%3a4.13.3+dfsg-1ubuntu2.1_amd64.deb ...
Unpacking libwbclient0:amd64 (2:4.13.3+dfsg-1ubuntu2.1) ...
Selecting previously unselected package python3-dnspython.
Preparing to unpack .../03-python3-dnspython_2.0.0+really1.16.0-2ubuntu2_all.deb
 ...
Unpacking python3-dnspython (2.0.0+really1.16.0-2ubuntu2) ...
Selecting previously unselected package libldb2:amd64.
Preparing to unpack .../04-libldb2_2%3a2.2.0-3ubuntu2_amd64.deb ...
Unpacking libldb2:amd64 (2:2.2.0-3ubuntu2) ...
Selecting previously unselected package python3-ldb.
Preparing to unpack .../05-python3-ldb_2%3a2.2.0-3ubuntu2_amd64.deb ...
Unpacking python3-ldb (2:2.2.0-3ubuntu2) ...
Selecting previously unselected package python3-tdb.
Preparing to unpack .../06-python3-tdb_1.4.3-1build1_amd64.deb ...
Unpacking python3-tdb (1.4.3-1build1) ...
Selecting previously unselected package libavahi-common-data:amd64.
Preparing to unpack .../07-libavahi-common-data_0.8-5ubuntu3_amd64.deb ...
Unpacking libavahi-common-data:amd64 (0.8-5ubuntu3) ...
Selecting previously unselected package libavahi-common3:amd64.
Preparing to unpack .../08-libavahi-common3_0.8-5ubuntu3_amd64.deb ...
Unpacking libavahi-common3:amd64 (0.8-5ubuntu3) ...
Selecting previously unselected package libavahi-client3:amd64.
Preparing to unpack .../09-libavahi-client3_0.8-5ubuntu3_amd64.deb ...
Unpacking libavahi-client3:amd64 (0.8-5ubuntu3) ...
Selecting previously unselected package libcups2:amd64.
Preparing to unpack .../10-libcups2_2.3.3op2-3ubuntu3_amd64.deb ...
Unpacking libcups2:amd64 (2.3.3op2-3ubuntu3) ...
Selecting previously unselected package libjansson4:amd64.
Preparing to unpack .../11-libjansson4_2.13.1-1.1build1_amd64.deb ...
Unpacking libjansson4:amd64 (2.13.1-1.1build1) ...
Selecting previously unselected package python3-talloc:amd64.
Preparing to unpack .../12-python3-talloc_2.3.1-2ubuntu1_amd64.deb ...
Unpacking python3-talloc:amd64 (2.3.1-2ubuntu1) ...
Selecting previously unselected package samba-libs:amd64.
Preparing to unpack .../13-samba-libs_2%3a4.13.3+dfsg-1ubuntu2.1_amd64.deb ...
Unpacking samba-libs:amd64 (2:4.13.3+dfsg-1ubuntu2.1) ...
Selecting previously unselected package python3-samba.
Preparing to unpack .../14-python3-samba_2%3a4.13.3+dfsg-1ubuntu2.1_amd64.deb ..
.
Unpacking python3-samba (2:4.13.3+dfsg-1ubuntu2.1) ...
Selecting previously unselected package samba-common.
Preparing to unpack .../15-samba-common_2%3a4.13.3+dfsg-1ubuntu2.1_all.deb ...
Unpacking samba-common (2:4.13.3+dfsg-1ubuntu2.1) ...
Selecting previously unselected package samba-common-bin.
Preparing to unpack .../16-samba-common-bin_2%3a4.13.3+dfsg-1ubuntu2.1_amd64.deb
 ...
Unpacking samba-common-bin (2:4.13.3+dfsg-1ubuntu2.1) ...
Selecting previously unselected package tdb-tools.
Preparing to unpack .../17-tdb-tools_1.4.3-1build1_amd64.deb ...
Unpacking tdb-tools (1.4.3-1build1) ...
Selecting previously unselected package samba.
Preparing to unpack .../18-samba_2%3a4.13.3+dfsg-1ubuntu2.1_amd64.deb ...
Unpacking samba (2:4.13.3+dfsg-1ubuntu2.1) ...
Selecting previously unselected package attr.
Preparing to unpack .../19-attr_1%3a2.4.48-6build1_amd64.deb ...
Unpacking attr (1:2.4.48-6build1) ...
Selecting previously unselected package libnl-route-3-200:amd64.
Preparing to unpack .../20-libnl-route-3-200_3.4.0-1build2_amd64.deb ...
Unpacking libnl-route-3-200:amd64 (3.4.0-1build2) ...
Selecting previously unselected package libibverbs1:amd64.
Preparing to unpack .../21-libibverbs1_33.1-1ubuntu1_amd64.deb ...
Unpacking libibverbs1:amd64 (33.1-1ubuntu1) ...
Selecting previously unselected package ibverbs-providers:amd64.
Preparing to unpack .../22-ibverbs-providers_33.1-1ubuntu1_amd64.deb ...
Unpacking ibverbs-providers:amd64 (33.1-1ubuntu1) ...
Selecting previously unselected package libboost-iostreams1.74.0:amd64.
Preparing to unpack .../23-libboost-iostreams1.74.0_1.74.0-8ubuntu2_amd64.deb ..
.
Unpacking libboost-iostreams1.74.0:amd64 (1.74.0-8ubuntu2) ...
Selecting previously unselected package libboost-thread1.74.0:amd64.
Preparing to unpack .../24-libboost-thread1.74.0_1.74.0-8ubuntu2_amd64.deb ...
Unpacking libboost-thread1.74.0:amd64 (1.74.0-8ubuntu2) ...
Selecting previously unselected package librdmacm1:amd64.
Preparing to unpack .../25-librdmacm1_33.1-1ubuntu1_amd64.deb ...
Unpacking librdmacm1:amd64 (33.1-1ubuntu1) ...
Selecting previously unselected package librados2.
Preparing to unpack .../26-librados2_16.2.1-0ubuntu0.21.04.1_amd64.deb ...
Unpacking librados2 (16.2.1-0ubuntu0.21.04.1) ...
Selecting previously unselected package libcephfs2.
Preparing to unpack .../27-libcephfs2_16.2.1-0ubuntu0.21.04.1_amd64.deb ...
Unpacking libcephfs2 (16.2.1-0ubuntu0.21.04.1) ...
Selecting previously unselected package liburing1:amd64.
Preparing to unpack .../28-liburing1_0.7-3ubuntu1_amd64.deb ...
Unpacking liburing1:amd64 (0.7-3ubuntu1) ...
Selecting previously unselected package python3-ecdsa.
Preparing to unpack .../29-python3-ecdsa_0.16.1-1_all.deb ...
Unpacking python3-ecdsa (0.16.1-1) ...
Selecting previously unselected package python3-gpg.
Preparing to unpack .../30-python3-gpg_1.14.0-1ubuntu3_amd64.deb ...
Unpacking python3-gpg (1.14.0-1ubuntu3) ...
Selecting previously unselected package python3-markdown.
Preparing to unpack .../31-python3-markdown_3.3.4-1_all.deb ...
Unpacking python3-markdown (3.3.4-1) ...
Selecting previously unselected package python3-pycryptodome.
Preparing to unpack .../32-python3-pycryptodome_3.9.7+dfsg1-1build3_amd64.deb ..
.
Unpacking python3-pycryptodome (3.9.7+dfsg1-1build3) ...
Selecting previously unselected package python3-pygments.
Preparing to unpack .../33-python3-pygments_2.7.1+dfsg-2ubuntu1_all.deb ...
Unpacking python3-pygments (2.7.1+dfsg-2ubuntu1) ...
Selecting previously unselected package samba-dsdb-modules:amd64.
Preparing to unpack .../34-samba-dsdb-modules_2%3a4.13.3+dfsg-1ubuntu2.1_amd64.d
eb ...
Unpacking samba-dsdb-modules:amd64 (2:4.13.3+dfsg-1ubuntu2.1) ...
Selecting previously unselected package samba-vfs-modules:amd64.
Preparing to unpack .../35-samba-vfs-modules_2%3a4.13.3+dfsg-1ubuntu2.1_amd64.de
b ...
Unpacking samba-vfs-modules:amd64 (2:4.13.3+dfsg-1ubuntu2.1) ...
Setting up attr (1:2.4.48-6build1) ...
Setting up libboost-iostreams1.74.0:amd64 (1.74.0-8ubuntu2) ...
Setting up python3-pycryptodome (3.9.7+dfsg1-1build3) ...
Setting up samba-common (2:4.13.3+dfsg-1ubuntu2.1) ...

Creating config file /etc/samba/smb.conf with new version
Setting up libjansson4:amd64 (2.13.1-1.1build1) ...
Setting up libnl-route-3-200:amd64 (3.4.0-1build2) ...
Setting up libtalloc2:amd64 (2.3.1-2ubuntu1) ...
Setting up python3-ecdsa (0.16.1-1) ...
Setting up python3-tdb (1.4.3-1build1) ...
Setting up python3-pygments (2.7.1+dfsg-2ubuntu1) ...
Setting up libtevent0:amd64 (0.10.2-1) ...
Setting up python3-gpg (1.14.0-1ubuntu3) ...
Setting up libavahi-common-data:amd64 (0.8-5ubuntu3) ...
Setting up tdb-tools (1.4.3-1build1) ...
update-alternatives: using /usr/bin/tdbbackup.tdbtools to provide /usr/bin/tdbba
ckup (tdbbackup) in auto mode
Setting up python3-markdown (3.3.4-1) ...
Setting up liburing1:amd64 (0.7-3ubuntu1) ...
Setting up python3-dnspython (2.0.0+really1.16.0-2ubuntu2) ...
Setting up libldb2:amd64 (2:2.2.0-3ubuntu2) ...
Setting up libboost-thread1.74.0:amd64 (1.74.0-8ubuntu2) ...
Setting up libibverbs1:amd64 (33.1-1ubuntu1) ...
Setting up ibverbs-providers:amd64 (33.1-1ubuntu1) ...
Setting up python3-talloc:amd64 (2.3.1-2ubuntu1) ...
Setting up libavahi-common3:amd64 (0.8-5ubuntu3) ...
Setting up libwbclient0:amd64 (2:4.13.3+dfsg-1ubuntu2.1) ...
Setting up python3-ldb (2:2.2.0-3ubuntu2) ...
Setting up libavahi-client3:amd64 (0.8-5ubuntu3) ...
Setting up librdmacm1:amd64 (33.1-1ubuntu1) ...
Setting up librados2 (16.2.1-0ubuntu0.21.04.1) ...
Setting up libcephfs2 (16.2.1-0ubuntu0.21.04.1) ...
Setting up libcups2:amd64 (2.3.3op2-3ubuntu3) ...
Setting up samba-libs:amd64 (2:4.13.3+dfsg-1ubuntu2.1) ...
Setting up samba-dsdb-modules:amd64 (2:4.13.3+dfsg-1ubuntu2.1) ...
Setting up python3-samba (2:4.13.3+dfsg-1ubuntu2.1) ...
Setting up samba-vfs-modules:amd64 (2:4.13.3+dfsg-1ubuntu2.1) ...
Setting up samba-common-bin (2:4.13.3+dfsg-1ubuntu2.1) ...
Checking smb.conf with testparm
Load smb config files from /etc/samba/smb.conf
Loaded services file OK.
Weak crypto is allowed
WARNING: The 'netbios name' is too long (max. 15 chars).

Server role: ROLE_STANDALONE

Done
Setting up samba (2:4.13.3+dfsg-1ubuntu2.1) ...
Adding group `sambashare' (GID 120) ...
Done.
Samba is not being run as an AD Domain Controller: Masking samba-ad-dc.service
Please ignore the following error about deb-systemd-helper not finding those ser
vices.
(samba-ad-dc.service masked)
Created symlink /etc/systemd/system/multi-user.target.wants/nmbd.service → /lib/
systemd/system/nmbd.service.
Failed to preset unit: Unit file /etc/systemd/system/samba-ad-dc.service is mask
ed.
/usr/bin/deb-systemd-helper: error: systemctl preset failed on samba-ad-dc.servi
ce: No such file or directory
Created symlink /etc/systemd/system/multi-user.target.wants/smbd.service → /lib/
systemd/system/smbd.service.
samba-ad-dc.service is a disabled or a static unit, not starting it.
Processing triggers for ufw (0.36-7.1) ...
Processing triggers for man-db (2.9.4-2) ...
Processing triggers for libc-bin (2.33-0ubuntu5) ...
Scanning processes...

No services need to be restarted.

No containers need to be restarted.

No user sessions are running outdated binaries.
Creating test-sru-1926183-hirsute
Starting test-sru-1926183-hirsute
...............................................................................................
status: done
time: Fri, 30 Apr 2021 23:32:52 +0000
detail:
DataSourceNoCloud [seed=/var/lib/cloud/seed/nocloud-net][dsmode=net]
27.0~21.04.1
====== Check ua tools 27.0 =====
ubuntu-advantage-tools:
  Installed: 27.0~21.04.1
  Candidate: 27.0~21.04.1
  Version table:
 *** 27.0~21.04.1 500
        500 http://archive.ubuntu.com/ubuntu hirsute-proposed/main amd64 Packages
        100 /var/lib/dpkg/status
     26.2 500
        500 http://archive.ubuntu.com/ubuntu hirsute/main amd64 Packages
Reading package lists... Done
Building dependency tree... Done
Reading state information... Done
The following package was automatically installed and is no longer required:
  libfreetype6
Use 'apt autoremove' to remove it.
0 upgraded, 0 newly installed, 0 to remove and 15 not upgraded.
====== Check no reboot required message on NOOP ====
CVE-2021-20254: Samba vulnerability https://ubuntu.com/security/CVE-2021-20254 No affected packages are installed. ✔ CVE-2021-20254 does not affect your system.
SUCCESS: no reboot required message
======= END hirsute ========

tags:

added: verification-done verification-done-bionic verification-done-focal verification-done-groovy verification-done-hirsute
removed: verification-needed verification-needed-bionic verification-needed-focal verification-needed-groovy verification-needed-hirsute

Revision history for this message

Chad Smith (chad.smith) wrote on 2021-05-01:

#15

proposed-bionic.yaml Edit (322 bytes, text/plain)

sample cloud-config setting up proposed-bionic.yaml

Mathew Hodson (mhodson) on 2021-05-02

Changed in ubuntu-advantage-tools (Ubuntu Groovy):
importance:	Undecided → Medium

Revision history for this message

Ubuntu SRU Bot (ubuntu-sru-bot) wrote on 2021-05-03: Autopkgtest regression report (ubuntu-advantage-tools/27.0~20.10.1)

#16

All autopkgtests for the newly accepted ubuntu-advantage-tools (27.0~20.10.1) for groovy have finished running.
The following regressions have been reported in tests triggered by the package:

ubuntu-advantage-tools/27.0~20.10.1 (i386)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/groovy/update_excuses.html#ubuntu-advantage-tools

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Revision history for this message

Launchpad Janitor (janitor) wrote on 2021-05-11:

#17

This bug was fixed in the package ubuntu-advantage-tools - 27.0.1

---------------
ubuntu-advantage-tools (27.0.1) impish; urgency=medium

* Add .gitignore and cleanup ignored directory .pytest_cache
* apt-hook: mitigate failures with true

-- Chad Smith <email address hidden> Wed, 28 Apr 2021 13:55:28 -0600

Changed in ubuntu-advantage-tools (Ubuntu Impish):
status:	Fix Committed → Fix Released

Revision history for this message

Brian Murray (brian-murray) wrote on 2021-07-28:

#18

The Groovy Gorilla has reached end of life, so this bug will not be fixed for that release

Changed in ubuntu-advantage-tools (Ubuntu Groovy):
status:	Fix Committed → Won't Fix

Revision history for this message

Brian Murray (brian-murray) wrote on 2022-01-26:

#19

The Hirsute Hippo has reached End of Life, so this bug will not be fixed for that release.

Changed in ubuntu-advantage-tools (Ubuntu Hirsute):
status:	Fix Committed → Won't Fix

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Bug attachments

proposed-bionic.yaml Edit

Add attachment

Remote bug watches

Bug watches keep track of this bug in other bug trackers.

Ubuntuubuntu-advantage-tools package

'ua fix' tells me to reboot with inaccurate message

Bug Description

Related branches

CVE References

Other bug subscribers

Bug attachments

Remote bug watches

Ubuntu
ubuntu-advantage-tools package