DEP8 run-test-suite not really running
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
apache2 (Ubuntu) |
Fix Released
|
Low
|
Unassigned | ||
Bionic |
Triaged
|
Low
|
Unassigned |
Bug Description
Up until 2.4.37-1, the d/t/run-test-suite test isn't running because it's called as root:
(...)
make[1]: Leaving directory '/tmp/autopkgte
[ error] Apache cannot spawn child processes as root, therefore the test suite must be run as a non-privileged user.
+ rm apache2.conf.debian
+ run_tests mpm_worker
(...)
This was fixed in 2.4.37-1:
* Fix test suite to actually run by creating a test user. It turns out
the test suite refuses to run as root but returns true even in that
case. It seems this has been broken since 2.4.27-4, where the test suite
had been updated and the debci test duration dropped from 15min to
3min. Also, don't rely on the exit status anymore but parse the test
output.
We should prepare this for bionic, so the next time a bionic SRU comes, it can be incorporated.
Note that a patch is introducing a failure in that suite:
# Test 2 got: "68" (t/apache/mmn.t at line 42)
# Expected: "75"
t/apache/mmn.t .......
Failed 1/2 subtests
The patch that introduces this failure is debian/
--- 2.4.x/include/
+++ 2.4.x/include/
@@ -496,6 +496,7 @@
* to ap_[r]getline()
* 20120211.68 (2.4.26-dev) Add ap_get_
* ap_get_
+ * 20120211.75 (2.4.30-dev) Add hostname_ex to proxy_worker_shared
*/
The test compares the version in the comment to the actual #define that happens later on. Since that #define wasn't changed, the test errors.
summary: |
- test-suite DEP8 not really running + DEP8 run-test-suite not really running |
Changed in apache2 (Ubuntu): | |
status: | New → Triaged |
importance: | Undecided → Low |
Changed in apache2 (Ubuntu Bionic): | |
status: | New → Triaged |
importance: | Undecided → Low |
Changed in apache2 (Ubuntu): | |
status: | Triaged → Fix Released |
patched run-test-suite so that the suite actually runs, and this is the output