Commit d9018976cdb6 missing in Kernels <4.14.x preventing lasting fix of Intel SPI bug on certain serial flash
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
linux (Ubuntu) |
Fix Released
|
Critical
|
Joseph Salisbury | ||
Artful |
Fix Released
|
Critical
|
Joseph Salisbury |
Bug Description
== SRU Justification ==
New bug forked out of Bug #1734147 "corrupted BIOS due to Intel SPI bug in kernel Edit"
When trying to apply the proposed fix in Bug #1734147 to a Lenovo Yoga with Serial Flash s25fl064k, the actual fix works, however reverting back to original available Kernel <4.14.x again locks the BIOS for write.
How to identify chip: Using the Fix Kernel from Bug #1734147 the kernel log will show intel-spi entries.
In lower part serial is shown as below:
intel-spi intel-spi: s25fl064k (8192 Kbytes)
Additional Information:
Lenovo Yoga running Linux Mint 18.3 (based on Xenial 16.04)
Bug #1734147 occured when trying Ubuntu 17.10
Explanation by Mika Westerberg (Bug #1734147, Comment #524)
"commit d9018976cdb6 is missing with this particular BIOS/system because every time you boot the system, the BIOS resets to default when it finds BCR register is changed. This is different issue than the CMP=1 issue most of the users have reported. This one also is not permanent so everything is fine as long as you don't touch that BCR register. In this case you either need to always boot to a kernel where that fix (d9018976cdb6) is included or blacklist lpc_ich.ko. Ubuntu v4.14.x kernels have that fix included so you might want to take one of them or build your own."
== Fixes ==
d9018976cdb6 ("mfd: lpc_ich: Do not touch SPI-NOR write protection bit on Haswell/Broadwell")
9d63f17661e2 ("spi-nor: intel-spi: Fix broken software sequencing codes")
== Regression Potential ==
Low, these patches fix an existing critical regression.
New bug requested to discuss this separate from main Bug #1734147
Anthony Wong (Bug #1734147, Comment #525)
"Looks like we need to cherry-pick it to 4.13 after all.
Christian, do you mind opening a new bug for your issue? We should continue the discussion and fix over there."
Changed in linux (Ubuntu): | |
status: | Incomplete → Confirmed |
Changed in linux (Ubuntu): | |
importance: | Undecided → Medium |
tags: | added: kernel-da-key |
Changed in linux (Ubuntu): | |
status: | Confirmed → Triaged |
Changed in linux (Ubuntu Artful): | |
status: | New → Triaged |
importance: | Undecided → Medium |
Changed in linux (Ubuntu): | |
assignee: | nobody → Joseph Salisbury (jsalisbury) |
Changed in linux (Ubuntu Artful): | |
assignee: | nobody → Joseph Salisbury (jsalisbury) |
status: | Triaged → In Progress |
Changed in linux (Ubuntu): | |
status: | Triaged → In Progress |
description: | updated |
Changed in linux (Ubuntu): | |
importance: | Medium → Critical |
Changed in linux (Ubuntu Artful): | |
importance: | Medium → Critical |
Changed in linux (Ubuntu Artful): | |
status: | In Progress → Fix Committed |
Changed in linux (Ubuntu): | |
status: | In Progress → Fix Released |
tags: |
added: verification-done-artful removed: verification-needed-artful |
This bug is missing log files that will aid in diagnosing the problem. While running an Ubuntu kernel (not a mainline or third-party kernel) please enter the following command in a terminal window:
apport-collect 1742696
and then change the status of the bug to 'Confirmed'.
If, due to the nature of the issue you have encountered, you are unable to run this command, please add a comment stating that fact and change the bug status to 'Confirmed'.
This change has been made by an automated script, maintained by the Ubuntu Kernel Team.