Ubuntu
yelp package

Images referenced by absolute path don't load

Bug #1559070 reported by Gunnar Hjalmarsson on 2016-03-18

This bug affects 5 people

	Status	Importance	Assigned to	Milestone
Yelp	Expired	High	gnome-bugs #763875
ubuntu-docs (Ubuntu)	Fix Released	High	Gunnar Hjalmarsson
yelp (Ubuntu)	Confirmed	High	Unassigned	Ubuntu ubuntu-16.04

Bug Description

The latest yelp version in Xenial doesn't show SVG icons in Ubuntu Help. Example icon:

/usr/share/icons/ubuntu-mono-light/status/22/system-devices-panel.svg

SVG files are displayed in GNOME Help, but there they use relative paths to the files (included in package). Don't understand why that would make a difference, though.

Another issue is that calling yelp with the path to a .page file as argument fails with: "Unknown Error - URL cannot be shown".

Downgrading to the Wily version 3.16.1-1ubuntu1 of yelp and libyelp0 fixes both issues.

Tags:

Related branches

lp://staging/~ubuntu-core-doc/ubuntu-docs/trunk2017-07-10

lp://staging/~ubuntu-desktop/yelp/ubuntu

Revision history for this message

Launchpad Janitor (janitor) wrote on 2016-03-18:

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in yelp (Ubuntu):
status:	New → Confirmed

Bug Watch Updater (bug-watch-updater) on 2016-03-18

Changed in yelp:
importance:	Unknown → High
status:	Unknown → Confirmed

Revision history for this message

Gunnar Hjalmarsson (gunnarhj) wrote on 2016-03-18:

yelp-local-paths.patch Edit (21.6 KiB, text/plain)

The issue with calling yelp with a file path as argument has been fixed upstream:

https://git.gnome.org/browse/yelp/commit/?id=e5f3a147aec6aeb4629194e1d3a3eefc1d4716e9

The attached patch cherry picks that fix.

I also committed a change to ubuntu-docs which replaces absolute paths to ubuntu-mono icons with relative paths to icons within the ubuntu-docs package. That's apparently not a real fix, but a workaround which may fix Ubuntu Help for 16.04.

@Doug: The latter includes changes of translatable strings, so we'll need to upload again very soon to update the translation template. Would appreciate if you could take a look first, though.

Changed in yelp (Ubuntu):
assignee:	nobody → Gunnar Hjalmarsson (gunnarhj)
status:	Confirmed → In Progress
Changed in ubuntu-docs (Ubuntu):
assignee:	nobody → Gunnar Hjalmarsson (gunnarhj)
importance:	Undecided → High
status:	New → Fix Committed
tags:	added: patch

Revision history for this message

Launchpad Janitor (janitor) wrote on 2016-03-19:

This bug was fixed in the package ubuntu-docs - 16.04.2

---------------
ubuntu-docs (16.04.2) xenial; urgency=medium

  * Use relative paths to SVG icons within this package instead of
    absolute paths to icons of the ubuntu-mono package (LP: #1559070).
  * Updated ubuntu-help.pot.

-- Gunnar Hjalmarsson <email address hidden> Fri, 18 Mar 2016 23:38:00 +0100

Changed in ubuntu-docs (Ubuntu):
status:	Fix Committed → Fix Released

Revision history for this message

Gunnar Hjalmarsson (gunnarhj) wrote on 2016-03-19:

Well, it was not quite fixed in ubuntu-docs 16.04.2. Forgot to update ubuntu-help/Makefile.am, so the icons in question were not installed.

Committed the missing piece to bzr, and confirmed that it now works by uploading to this PPA:

https://launchpad.net/~ubuntu-core-doc/+archive/ubuntu/ppa

Revision history for this message

Iain Lane (laney) wrote on 2016-03-21:

Done yelp. Please upload the docs to workaround this.

Changed in yelp (Ubuntu):
status:	In Progress → Fix Committed

Revision history for this message

Launchpad Janitor (janitor) wrote on 2016-03-21:

This bug was fixed in the package yelp - 3.18.1-1ubuntu4

---------------
yelp (3.18.1-1ubuntu4) xenial; urgency=medium

  * debian/patches/0001-libyelp-fix-handling-of-documents-using-local-paths.patch:
    Cherry-pick from upstream to fix absolute paths given as parameters. (LP:
    #1559070)

-- Iain Lane <email address hidden> Mon, 21 Mar 2016 09:18:46 +0000

Changed in yelp (Ubuntu):
status:	Fix Committed → Fix Released

Revision history for this message

Gunnar Hjalmarsson (gunnarhj) wrote on 2016-03-21:

Changed the title to reflect the upstream bug report, and re-opened the yelp (ubuntu) task. Even if we work around the problem with absolute paths to images in ubuntu-docs, other packages which rely on yelp might be affected of this issue.

summary:	- SVG icons not shown / "yelp </path/to/file.page>" fails + Images referenced by absolute path don't load
Changed in yelp (Ubuntu):
assignee:	Gunnar Hjalmarsson (gunnarhj) → nobody
status:	Fix Released → Confirmed