Timeout error while renaming a file

Bug #1845828 reported by spike speigel
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Xfce4 Desktop
Fix Released
Medium
xfdesktop4 (Ubuntu)
Incomplete
Undecided
Unassigned

Bug Description

If a user starts renaming a file (via F2 for instance) they will see the file rename dialog as they should. If the user takes roughly more than 30 seconds to decide on a file name, then they are greeted with an error dialog box that complains a timeout has been reached.

"The requested operation could not be completed"
"Timeout was reached"

The error is reproducible every time.
The error is reproducible through reboots.
The error occurs 25 secs after the "Rename" dialog is opened (timed using stopwatch multiple times).
The files being tested with are on the desktop located on local storage.
File type and initial naming complexity do not seem to matter.

ProblemType: Bug
DistroRelease: Ubuntu 19.10
Package: thunar 1.8.9-1
ProcVersionSignature: Ubuntu 5.3.0-13.14-generic 5.3.0
Uname: Linux 5.3.0-13-generic x86_64
NonfreeKernelModules: nvidia_modeset nvidia
ApportVersion: 2.20.11-0ubuntu7
Architecture: amd64
CurrentDesktop: XFCE
Date: Sun Sep 29 02:35:55 2019
ExecutablePath: /usr/bin/thunar
InstallationDate: Installed on 2019-03-07 (206 days ago)
InstallationMedia: Xubuntu 18.10 "Cosmic Cuttlefish" - Release amd64 (20181017.2)
ProcEnviron:
 LANGUAGE=en_US
 PATH=(custom, user)
 XDG_RUNTIME_DIR=<set>
 LANG=en_US.UTF-8
 SHELL=/bin/bash
SourcePackage: thunar
UpgradeStatus: Upgraded to eoan on 2019-08-19 (40 days ago)

Revision history for this message
In , Jussi (jussi-lahtinen-gmail) wrote :

Way to reproduce the problem:

1. Choose file from your desktop.
2. Open menu with right mouse button.
3. Choose rename.
4. Do not change the name or close the dialog, but wait for 15 seconds.
5. The error message appears and trash can will be disabled until you close the dialog.

xfdesktop version 4.11.8 and earlier are affected.

For more detail see:
https://bugs.launchpad.net/ubuntu/+source/xfdesktop4/+bug/1388946

Revision history for this message
In , Eric Koegel (eric-koegel) wrote :

We're hitting DBUS's reply timeout. We'll have to find a way to perform the call without a timeout to fix this. The code in question is in:
http://git.xfce.org/xfce/xfdesktop/tree/src/xfdesktop-file-utils.c#n691
which calls xfdesktop_file_manager_proxy_rename_file_async
There's a dbus_g_proxy_call_with_timeout
http://dbus.freedesktop.org/doc/dbus-glib/dbus-glib-DBusGProxy.html#dbus-g-proxy-call-with-timeout
But the timeout is an int representing milliseconds which only gets up to 32 seconds (unless my math is off). Maybe dbus_g_proxy_call_no_reply? ...If that's not possible then we may have to not use dbus/thunar for renames and write the renaming dialog and operation ourselves to fix this issue.

Revision history for this message
In , Jussi (jussi-lahtinen-gmail) wrote :

Maybe I haven't understand this, if so, sorry about the noise...
It seem the event is called in wrong time, is it possible call the event only after user has given new name for the file?

Revision history for this message
In , Eric Koegel (eric-koegel) wrote :

Well right now xfdesktop doesn't have code to display the rename dialog. The good news is it's not hard, it's just a matter of adding it in.

Revision history for this message
In , Thaddaeus Tintenfisch (thad-fisch-deactivatedaccount) wrote :

The same applies to the "Create New Folder" and "Create New File" dialog windows.

Revision history for this message
In , Thaddaeus Tintenfisch (thad-fisch-deactivatedaccount) wrote :

As of now, we simply ignore this type of error while not breaking any functionality.

http://git.xfce.org/xfce/xfdesktop/commit/?id=b0388120725ff485e5ae40fde4017aa8c7efb9cf

Revision history for this message
In , Hudd (hededrk) wrote :

*** Bug 11780 has been marked as a duplicate of this bug. ***

Revision history for this message
spike speigel (frail-knight) wrote :
description: updated
Revision history for this message
Chris Guiver (guiverc) wrote :

Thank you for taking the time to report this bug and helping to make Ubuntu better.

Is it a local file you are trying to rename? or a file on a network share?

I opened thunar on this running 19.10 box (amd64), selected a file and pressed <F2> to have the "Rename" dialog box appear. It was left for more than 90 seconds and nothing changed, no error dialog about timeout.

I booted a different 19.10 test box [x86], opened thunar and selected a file and pressed <F2> to have the "Rename" dialog box appear. It again was left for 90+ seconds and nothing changed or no timeout dialog.

I booted the Xubuntu 19.10 daily (2019-09-26.1) opened thunar, created a odt file, selected it, pressed <F2> to rename and waited 3 minutes - no timeout errors occurred, it's still waiting now 10+ minutes since F2 was pressed (though I've had to stop screensaver now twice), and at the "Enter the new name:" dialog

I was unable to recreate this issue sorry. Not with local files.

Revision history for this message
spike speigel (frail-knight) wrote :

Hi Chris,

Yes, this is with local files. I encountered it while trying to rename screenshots I'd taken moments earlier. The images were sitting on my desktop.

Revision history for this message
spike speigel (frail-knight) wrote :

I don't know if the type of local storage could affect thunar, but here's the drive info if it helps any:

Samsung SSD 970 EVO
2TB, NVMe, PCIe, M.2 2280

description: updated
Revision history for this message
Paul White (paulw2u) wrote :

Hi spike, I can confirm this timeout by renaming a desktop short-cut with the F2 key.

Changed in thunar (Ubuntu):
status: New → Confirmed
Revision history for this message
Theo Linkspfeifer (lastonestanding) wrote :
affects: thunar (Ubuntu) → xfdesktop4 (Ubuntu)
Revision history for this message
In , spike speigel (frail-knight) wrote :

It appears this is happening again. Can this issue be reopened, or should a new one be created?

Xubuntu 19.10
xfdesktop4 4.14.1-1

Revision history for this message
In , Alexxcons-x (alexxcons-x) wrote :

Reopened ... I as well can reproduce the bug. Thanks for finding that old bug !

Revision history for this message
In , spike speigel (frail-knight) wrote :

You're welcome, thank you for verifying :)

Changed in xfdesktop:
importance: Unknown → Medium
status: Unknown → Confirmed
Revision history for this message
In , Theo Linkspfeifer (lastonestanding) wrote :
Revision history for this message
In , Gitbot (gitbot) wrote :

Andre Miranda referenced this bugreport in commit 999cbcbaa4b9ce44815b37180da944a8347254a9

Reintroduce workaround for Bug #11283

https://git.xfce.org/xfce/xfdesktop/commit?id=999cbcbaa4b9ce44815b37180da944a8347254a9

Revision history for this message
In , Gitbot (gitbot) wrote :

Andre Miranda referenced this bugreport in commit 850d3aec523467b2fe3eb22dcdbd7ff55ac3c66c

Reintroduce workaround for Bug #11283

https://git.xfce.org/xfce/xfdesktop/commit?id=850d3aec523467b2fe3eb22dcdbd7ff55ac3c66c

Changed in xfdesktop:
status: Confirmed → Fix Released
Revision history for this message
nulesus (nulesus) wrote :

Tested today and this is NOT fixed 2020-05-12
Xfce v4.14 eoan ermine UBuntuStudio 19.10 and also
tested in focal fossa UbuntuStudio 20.04

Revision history for this message
In , Graham Smith (graham-u) wrote :

No we don't. The ignore fails on Desktop. Please check reality before posted theory.

Revision history for this message
Graham Smith (graham-u) wrote :

nulesus (nulesus) wrote on 2020-05-12:
     Tested today and this is NOT fixed 2020-05-12

[GS] Tested today (2021-03-03) STILL not fixed...... 🙄

Revision history for this message
Sean Davis (bluesabre) wrote (last edit ):

Are you still able to reproduce this in Xubuntu 22.04 or 22.10? I'm not seeing this behavior on 22.04.

Changed in xfdesktop4 (Ubuntu):
status: Confirmed → Incomplete
Revision history for this message
spike speigel (frail-knight) wrote :

I cannot reproduce the error at the moment running 22.10.

However, I don't know if the potential cause of the issue talked about in https://bugs.launchpad.net/ubuntu/+source/xfdesktop4/+bug/1845828/comments/8 was actually addressed, or if we are still just masking the issue with a workaround as mentioned in https://bugs.launchpad.net/ubuntu/+source/xfdesktop4/+bug/1845828/comments/19

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.