[SRU] webbrowser-app bug fixes
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
webbrowser-app (Ubuntu) |
Fix Released
|
High
|
Olivier Tilloy | ||
Bug Description
[Impact]
This SRU groups 9 separate bug fixes that went into bug:webbrowser-app since xenial was released. Those were carefully picked because of their impact on desktop users of webbrowser-app and webapp-container (images for phones and tablets are built with the stable-
- bug #1565055: support for google hangouts (manual test case in bug description)
- bug #1573017: SAML detection logic broken in webapp container (changeset has autopilot tests)
- bug #1572673: invalid variable access error in webapp container (changeset has autopilot tests)
- bug #1466427: dynamic Ubuntu version in default UA string (manual test case in bug description)
- bug #1576639: fine-tune the custom memory-pressure handler (manual test case in bug description)
- bug #1581025: secure connection icon not showing (manual test case in bug description)
- bug #1580290: only load the current tab when the session is restored (manual test case in bug description)
- bug #1577806: browser and container open under the same instance (changeset has autopilot tests + manual test case in bug description)
- bug #1565063: dynamic Chromium version in default UA string (manual test case in bug description)
[Test Case]
Each individual bug report has details of how to reproduce the bug and how to verify it is fixed, along with additional unit/autopilot tests where possible/
All unit tests are being run at package build time.
To run autopilot tests, install the {webbrowser-
autopilot3 run webbrowser_app
autopilot3 run webapp_container
Beware that this is time-consuming and that it takes over user input (keyboard and mouse), so better to run those in a spare machine on the side.
All webapp_container tests should pass.
Of the 184 tests in the webbrowser_app test suite, 3 are known to fail. Those are test issues, not actual functional issues with the app, so they can be safely ignored:
test_
test_
test_
[Regression Potential]
General UX regressions should be caught by existing autopilot tests (both apps have quite an extensive test suite). The most intrusive change in this SRU is also the most critical one, it’s the fix for bug #1577806. As such, it has been particularly carefully tested.
Related branches
- Ubuntu Phablet Team: Pending requested
-
Diff: 905 lines (+274/-86)27 files modifieddebian/changelog (+15/-0)
debian/control (+2/-1)
src/Ubuntu/CMakeLists.txt (+4/-0)
src/Ubuntu/Web/UserAgent02.qml (+4/-10)
src/Ubuntu/Web/plugin.cpp (+7/-0)
src/Ubuntu/Web/ua-overrides-desktop.js (+5/-0)
src/Ubuntu/Web/ua-overrides-mobile.js (+6/-1)
src/app/browserapplication.cpp (+32/-24)
src/app/browserapplication.h (+1/-2)
src/app/config.h.in (+0/-1)
src/app/single-instance-manager.cpp (+39/-3)
src/app/single-instance-manager.h (+1/-1)
src/app/webbrowser/Browser.qml (+21/-15)
src/app/webbrowser/BrowserTab.qml (+3/-2)
src/app/webbrowser/NavigationBar.qml (+1/-2)
src/app/webbrowser/webbrowser-app.cpp (+1/-1)
src/app/webcontainer/WebApp.qml (+1/-0)
src/app/webcontainer/WebViewImplOxide.qml (+28/-14)
src/app/webcontainer/WebappContainerWebview.qml (+3/-1)
src/app/webcontainer/webapp-container.cpp (+32/-1)
src/app/webcontainer/webapp-container.h (+1/-0)
src/app/webcontainer/webapp-container.qml (+2/-0)
tests/autopilot/webapp_container/tests/__init__.py (+4/-0)
tests/autopilot/webapp_container/tests/fake_servers.py (+29/-0)
tests/autopilot/webapp_container/tests/test_popup_webview_overlay.py (+19/-0)
tests/autopilot/webapp_container/tests/test_saml_url_patterns.py (+9/-3)
tests/unittests/single-instance-manager/tst_SingleInstanceManagerTests.cpp (+4/-4)
Changed in webbrowser-app (Ubuntu): | |
milestone: | none → ubuntu-16.04.1 |
importance: | Undecided → High |
Changed in webbrowser-app (Ubuntu): | |
milestone: | ubuntu-16.04.1 → none |
description: | updated |
description: | updated |
description: | updated |
Changed in webbrowser-app (Ubuntu): | |
assignee: | nobody → Olivier Tilloy (osomon) |
status: | New → Fix Released |