Ubuntu
webbrowser-app package

First tab is always reloaded when the session is restored

Bug #1580290 reported by Michal Predotka
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Canonical System Image
Fix Released
High
Bill Filler
Canonical System Image 12 "OTA12"
webbrowser-app (Ubuntu)
Fix Released
High
Olivier Tilloy
Xenial
Fix Released
Undecided
Unassigned

Bug Description

bq M10 rc-proposed OS build 100
If I have few tabs open and in the first tab is a youtube video, it will start playing even if that tap is in the background after restarting the Browser.

Steps to reproduce:
1. Start Browser
2. Open a tab with a youtube video in it, for example http://summit.ubuntu.com/uos-1605/meeting/22651/convergent-ubuntu-apps
3. Open few more tabs with other websites
4. If necessary move the tab with the video so it's the first from the left
5. Select any other tab
6. Close Browser
7. Start Browser again

Expected result:
I don't hear the sound from the video in the background tab.

What happens instead:
I hear the sound from the video in the background tab.

Related branches

lp://staging/~osomon/webbrowser-app/session-restore-tab-load
system-apps-ci-bot: Needs Fixing (continuous-integration)
Ubuntu Phablet Team: Pending requested
Diff: 51 lines (+12/-4)
1 file modified
src/app/webbrowser/Browser.qml (+12/-4)
lp://staging/~osomon/webbrowser-app/xenial-sru-1
Ubuntu Phablet Team: Pending requested
Diff: 905 lines (+274/-86)
27 files modified
debian/changelog (+15/-0)
debian/control (+2/-1)
src/Ubuntu/CMakeLists.txt (+4/-0)
src/Ubuntu/Web/UserAgent02.qml (+4/-10)
src/Ubuntu/Web/plugin.cpp (+7/-0)
src/Ubuntu/Web/ua-overrides-desktop.js (+5/-0)
src/Ubuntu/Web/ua-overrides-mobile.js (+6/-1)
src/app/browserapplication.cpp (+32/-24)
src/app/browserapplication.h (+1/-2)
src/app/config.h.in (+0/-1)
src/app/single-instance-manager.cpp (+39/-3)
src/app/single-instance-manager.h (+1/-1)
src/app/webbrowser/Browser.qml (+21/-15)
src/app/webbrowser/BrowserTab.qml (+3/-2)
src/app/webbrowser/NavigationBar.qml (+1/-2)
src/app/webbrowser/webbrowser-app.cpp (+1/-1)
src/app/webcontainer/WebApp.qml (+1/-0)
src/app/webcontainer/WebViewImplOxide.qml (+28/-14)
src/app/webcontainer/WebappContainerWebview.qml (+3/-1)
src/app/webcontainer/webapp-container.cpp (+32/-1)
src/app/webcontainer/webapp-container.h (+1/-0)
src/app/webcontainer/webapp-container.qml (+2/-0)
tests/autopilot/webapp_container/tests/__init__.py (+4/-0)
tests/autopilot/webapp_container/tests/fake_servers.py (+29/-0)
tests/autopilot/webapp_container/tests/test_popup_webview_overlay.py (+19/-0)
tests/autopilot/webapp_container/tests/test_saml_url_patterns.py (+9/-3)
tests/unittests/single-instance-manager/tst_SingleInstanceManagerTests.cpp (+4/-4)
Revision history for this message
Olivier Tilloy (osomon) wrote :

I can reliably reproduce the issue. What seems to happen is that the first tab in the list is always loaded at startup, regardless of whether there are other open tabs and regardless of the current tab index. This is an unexpected behaviour, only the current tab should be reloaded.

Changed in webbrowser-app (Ubuntu):
status: New → Confirmed
importance: Undecided → High
assignee: nobody → Olivier Tilloy (osomon)
summary: - Video plays in background tab
+ First tab is always reloaded when the session is restored
Olivier Tilloy (osomon)
Changed in webbrowser-app (Ubuntu):
status: Confirmed → In Progress
Jean-Baptiste Lallement (jibel)
Changed in canonical-devices-system-image:
status: New → Fix Committed
importance: Undecided → High
assignee: nobody → Bill Filler (bfiller)
milestone: none → 12
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package webbrowser-app - 0.23+16.10.20160519-0ubuntu1

---------------
webbrowser-app (0.23+16.10.20160519-0ubuntu1) yakkety; urgency=medium

  * Display the currently hovered hyperlink’s target URL in an overlay.
    (LP: #1499775)
  * Introduce a BrowserPage type for consistency between all pages, and
    use the UITK Page and PageHeader types. (LP: #1511137)
  * Keep the securityStatus property of the address bar always in sync
    with the current webview. (LP: #1581025)
  * Minor packaging updates.
  * Only load the current tab when the session is restored. (LP:
    #1580290)
  * Set a minimum width and height on the browser window. (LP: #1581259)
  * Use QStringLiteral instead of QString in config.h.in.

 -- Olivier Tilloy <email address hidden> Thu, 19 May 2016 18:39:35 +0000

Changed in webbrowser-app (Ubuntu):
status: In Progress → Fix Released
Pat McGowan (pat-mcgowan)
Changed in canonical-devices-system-image:
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Michal, or anyone else affected,

Accepted webbrowser-app into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/webbrowser-app/0.23+16.04.20161028-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in webbrowser-app (Ubuntu Xenial):
status: New → Fix Committed
tags: added: verification-needed
Revision history for this message
Michal Predotka (mpredotka) wrote :

Hi.
I'm not sure how can I do the testing as that bug was affecting me on Ubuntu tablet. I don't use this app on Ubuntu desktop.

Revision history for this message
Olivier Tilloy (osomon) wrote :

@Michal: the bug is not device-specific, it’s also affecting desktop users. You can help validating the fix if you have a desktop/laptop running xenial. Thanks!

Revision history for this message
Olivier Tilloy (osomon) wrote :

Tested and verified in an up-to-date xenial amd64 VM, with webbrowser-app 0.23+16.04.20161028-0ubuntu1.

I verified that the first tab doesn’t get reloaded at startup if another tab was previously selected.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Steve Langasek (vorlon) wrote :

Hello Michal, or anyone else affected,

Accepted webbrowser-app into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/webbrowser-app/0.23+16.04.20161028-0ubuntu2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: removed: verification-done
tags: added: verification-needed
Revision history for this message
Michal Predotka (mpredotka) wrote :

Hi,

I've just tested this version on my Ubuntu desktop running 16.04LTS. The bug seems to be fixed :)

Revision history for this message
Olivier Tilloy (osomon) wrote :

Tested and verified in an up-to-date xenial amd64 VM, with webbrowser-app 0.23+16.04.20161028-0ubuntu2.

I verified that the first tab doesn’t get reloaded at startup if another tab was previously selected.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package webbrowser-app - 0.23+16.04.20161028-0ubuntu2

---------------
webbrowser-app (0.23+16.04.20161028-0ubuntu2) xenial; urgency=medium

  * SRU for selected bug fixes:
    - LP: #1565055: support for google hangouts
    - LP: #1573017: SAML detection logic broken in webapp container
    - LP: #1572673: invalid variable access error in webapp container
    - LP: #1466427: dynamic Ubuntu version in default UA string
    - LP: #1576639: fine-tune the custom memory-pressure handler
    - LP: #1581025: secure connection icon not showing
    - LP: #1580290: only load the current tab when the session is restored
    - LP: #1577806: browser and container open under the same instance
    - LP: #1565063: dynamic Chromium version in default UA string

 -- Olivier Tilloy <email address hidden> Fri, 28 Oct 2016 09:17:33 +0000

Changed in webbrowser-app (Ubuntu Xenial):
status: Fix Committed → Fix Released
Revision history for this message
Steve Langasek (vorlon) wrote : Update Released

The verification of the Stable Release Update for webbrowser-app has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.