[desktop] Dragging a bookmark to a folder activates the bookmark
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| webbrowser-app (Ubuntu) |
In Progress
|
Undecided
|
Ugo Riboni | ||
Bug Description
I’m consistently seeing this on my desktop (running vivid + UITK from the overlay PPA), and it makes the following autopilot test fail: webbrowser_
It seems to be a recent regression (maybe the latest landing of the UITK), although I can’t tell for sure.
Steps to reproduce:
1) Open a new tab
2) Open the bookmarks section of the new tab view if not open already
3) Hover the mouse over the second bookmark in the list in the right panel (the first bookmark is a special case, it can’t be dragged)
4) Move the cursor to the grip that appears on the right of the list item
5) Press the left mouse button and start dragging leftwards
Expected result: the drag actually starts, the bookmark can be moved to another folder.
Current result: the drag doesn’t start, instead releasing the mouse button activates the bookmark, thus opening it in the tab.
Note: in step 5, if you start dragging downward (or upward) first, then leftward, the drag is correctly initiated.
Related branches
- Cris Dywan: Approve
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 238 lines (+140/-2)5 files modifiedcomponents.api (+1/-0)
src/Ubuntu/Components/plugin/uclistitem.cpp (+53/-2)
src/Ubuntu/Components/plugin/uclistitem.h (+4/-0)
src/Ubuntu/Components/plugin/uclistitem_p.h (+1/-0)
tests/unit_x11/tst_components/tst_listitem_extras.qml (+81/-0)
- system-apps-ci-bot: Needs Fixing (continuous-integration)
- PS Jenkins bot: Needs Fixing (continuous-integration)
- Ubuntu Phablet Team: Pending requested
-
Diff: 94 lines (+13/-16)3 files modifiedsrc/app/webbrowser/BookmarksFoldersViewWide.qml (+2/-3)
src/app/webbrowser/DraggableUrlDelegateWide.qml (+5/-1)
tests/autopilot/webbrowser_app/tests/test_new_tab_view.py (+6/-12)
| Ugo Riboni (uriboni) wrote | #1 |
| Changed in webbrowser-app (Ubuntu): | |
| status: | New → In Progress |
This seems to be caused by a recent change in the UITK, as things worked correctly before and to my knowledge there has been no relevant changes to the app that might have caused this regression.
I reported a minimal example as bug #1500409 (which is actually a similar and related problem which when fixed will also solve this issue)