Ubuntu
webbrowser-app package

Implement Do Not Track

Bug #1178002 reported by Adnane Belmadiaf
68
This bug affects 13 people
Affects Status Importance Assigned to Milestone
Oxide
Fix Released
Low
Alexandre Abreu
Oxide branch-1.9
webbrowser-app (Ubuntu)
Confirmed
Wishlist
Unassigned

Bug Description

Add an option to send DNT HTTP header, something like this :
request.setRawHeader ("DNT", dnt ? "1" : "0");

See original description

Related branches

lp://staging/~abreu-alexandre/oxide/donottrack
Chris Coulson: Approve
Diff: 438 lines (+212/-1) (has conflicts)
13 files modified
qt/core/browser/oxide_qt_web_context.cc (+24/-0)
qt/core/browser/oxide_qt_web_context.h (+3/-0)
qt/core/glue/oxide_qt_web_context_proxy.h (+3/-0)
qt/quick/api/oxideqquickwebcontext.cc (+19/-0)
qt/quick/api/oxideqquickwebcontext_p.h (+6/-0)
qt/tests/qmltests/api/tst_WebContext_doNotTrack.py (+18/-0)
qt/tests/qmltests/api/tst_WebContext_doNotTrack.qml (+74/-0)
shared/browser/oxide_browser_context.cc (+33/-1)
shared/browser/oxide_browser_context.h (+5/-0)
shared/browser/oxide_browser_context_observer.h (+2/-0)
shared/browser/oxide_network_delegate.cc (+10/-0)
shared/browser/oxide_web_view_contents_helper.cc (+14/-0)
shared/browser/oxide_web_view_contents_helper.h (+1/-0)
lp://staging/~oxide-developers/oxide/packaging.wily.next
lp://staging/~oxide-developers/oxide/packaging.vivid.next
lp://staging/~oxide-developers/oxide/packaging.trusty.next
lp://staging/~oxide-developers/oxide/packaging.wily
lp://staging/~oxide-developers/oxide/packaging.vivid
Revision history for this message
Olivier Tilloy (osomon) wrote :

See https://trac.webkit.org/wiki/Fingerprinting#vi.DoNotTrackHeader.

description: updated
Changed in webbrowser-app:
status: New → Confirmed
Bill Filler (bfiller)
Changed in webbrowser-app (Ubuntu):
status: New → Confirmed
importance: Undecided → Wishlist
Changed in webbrowser-app:
importance: Undecided → Wishlist
Revision history for this message
Adnane Belmadiaf (daker) wrote :

Adding Oxide since this should be done using QML

Revision history for this message
Chris Coulson (chrisccoulson) wrote :

This will happen in Oxide when I add the WebSettings API

Changed in oxide:
assignee: nobody → Chris Coulson (chrisccoulson)
Chris Coulson (chrisccoulson)
Changed in oxide:
status: New → Triaged
importance: Undecided → Low
Revision history for this message
Chris Coulson (chrisccoulson) wrote :

Sorry I've not had a chance to work on this yet.

There are 2 places we need to set DNT settings:

1) content::RendererPreferences::enable_do_not_track, which sets what navigator.doNotTrack returns.
2) Manually adding the DNT header to outgoing network requests in oxide::NetworkDelegate.

Because 2) happens on Chromium's IO thread, we can't have a per-WebView setting or a property in WebPreferences for this (as there's no safe way to map a render process ID and render view ID to a WebView on the IO thread, and WebView + everything it encapsulates in Chromium is not thread safe). This would need to be a new property on WebContext, which provides a mechanism to access various properties on the IO thread (via oxide::BrowserContextIOData).

This should be fairly simple to implement

Revision history for this message
Chris Coulson (chrisccoulson) wrote :

I'd happily mentor a new contributor to implement this...

Chris Coulson (chrisccoulson)
Changed in oxide:
assignee: Chris Coulson (chrisccoulson) → nobody
Alexandre Abreu (abreu-alexandre)
Changed in oxide:
assignee: nobody → Alexandre Abreu (abreu-alexandre)
Alexandre Abreu (abreu-alexandre)
Changed in oxide:
milestone: none → branch-1.9
Olivier Tilloy (osomon)
no longer affects: webbrowser-app
Alexandre Abreu (abreu-alexandre)
Changed in oxide:
status: Triaged → In Progress
Alexandre Abreu (abreu-alexandre)
Changed in oxide:
status: In Progress → Fix Committed
Olivier Tilloy (osomon)
Changed in oxide:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.