Ubuntu
vm-builder package

grub2 support for guests >= karmic

Bug #509609 reported by Loïc Minier
24
This bug affects 4 people
Affects Status Importance Assigned to Milestone
VMBuilder
Triaged
Medium
Unassigned
vm-builder (Ubuntu)
Triaged
Wishlist
Unassigned

Bug Description

Hi

For >= karmic guests, grub2 should be installed and used in the guest instead of grub (same logic as for ext4).

cjwatson has a preliminary patch.

Thanks,

Related branches

lp://staging/~lool/vmbuilder/grub2
lp://staging/~guilhem-fr/vmbuilder/oneiric-support
Scott Moser: Pending requested
VMBuilder: Pending requested
Diff: 1849 lines (+729/-243)
26 files modified
VMBuilder/contrib/cli.py (+35/-22)
VMBuilder/disk.py (+90/-39)
VMBuilder/distro.py (+23/-15)
VMBuilder/hypervisor.py (+33/-18)
VMBuilder/plugins/__init__.py (+3/-1)
VMBuilder/plugins/ec2/__init__.py (+11/-11)
VMBuilder/plugins/kvm/__init__.py (+1/-1)
VMBuilder/plugins/kvm/disk.py (+38/-0)
VMBuilder/plugins/kvm/qemu_nbd.py (+117/-0)
VMBuilder/plugins/kvm/vm.py (+4/-0)
VMBuilder/plugins/ubuntu/dapper.py (+138/-34)
VMBuilder/plugins/ubuntu/distro.py (+76/-59)
VMBuilder/plugins/ubuntu/intrepid.py (+1/-0)
VMBuilder/plugins/ubuntu/karmic.py (+1/-0)
VMBuilder/plugins/ubuntu/lucid.py (+29/-1)
VMBuilder/plugins/ubuntu/oneiric.py (+22/-1)
VMBuilder/plugins/ubuntu/precise.py (+22/-0)
VMBuilder/plugins/ubuntu/templates/Copy of devicemap.tmpl (+17/-0)
VMBuilder/plugins/ubuntu/templates/devicemap.tmpl (+9/-3)
VMBuilder/plugins/ubuntu/templates/grubcfg.tmpl (+8/-0)
VMBuilder/plugins/ubuntu/templates/loadcfg.tmpl (+3/-0)
VMBuilder/plugins/ubuntu/templates/sources.list.tmpl (+10/-0)
VMBuilder/tests/disk_tests.py (+7/-7)
VMBuilder/tests/plugin_tests.py (+28/-28)
VMBuilder/util.py (+1/-1)
VMBuilder/vm.py (+2/-2)
Revision history for this message
Loïc Minier (lool) wrote :
Revision history for this message
Colin Watson (cjwatson) wrote :

Definitely not ready to go yet though; note e.g. the sh -x in there for testing. I don't have time to work on this further so anyone else should feel free to pick it up given this basis.

Thierry Carrez (ttx)
Changed in vm-builder (Ubuntu):
importance: Undecided → Wishlist
status: New → Triaged
Revision history for this message
Loïc Minier (lool) wrote :

So after some tweaks this is apparently almost working, but I get a segfault in grub:
2010-01-22 01:05:24,516 INFO : + path=/boot/grub
2010-01-22 01:05:24,516 INFO : + uname
2010-01-22 01:05:24,517 INFO : + echo /boot/grub
2010-01-22 01:05:24,517 INFO : + relative_grubdir=/boot/grub
2010-01-22 01:05:24,518 INFO : + [ x/boot/grub = x ]
2010-01-22 01:05:24,518 INFO : + [ i386-pc = i386-pc ]
2010-01-22 01:05:24,527 INFO : + /usr/bin/grub-mkimage --output=/boot/grub/core.img --prefix=/boot/grub biosdisk ext2 part_msdos
2010-01-22 01:05:24,538 INFO : + /usr/sbin/grub-setup --force --directory=/boot/grub --device-map=/boot/grub/device.map (hd0)
2010-01-22 01:05:24,666 INFO : Segmentation fault (core dumped)
2010-01-22 01:05:24,667 INFO : + exit 1
2010-01-22 01:05:24,667 DEBUG : Oh, dear, an exception occurred
2010-01-22 01:05:24,667 INFO : Cleaning up

I'm pushing my WIP branch to lp:~lool/vmbuilder/grub2.

Revision history for this message
Loïc Minier (lool) wrote :

(I typoed the --author in the last commit of the branch; will fix this in another branch upload next time)

Revision history for this message
Soren Hansen (soren) wrote :

I'm kind of hesitant accept that branch before this seems to be working. I'm not clued enough to really blame grub2 rather than this integration code. If you can justify that it indeed is grub2, please do so (and open a bug against it).

Soren Hansen (soren)
Changed in vmbuilder:
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
Guilhem Lettron (guilhem-fr) wrote :

I do a lot of work in my branch :
lp:~guilhem-fr/vmbuilder/oneiric-support

You can test on recipe.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.