Ubuntu
usb-creator package

[SRU] cannot format when no partition table is present

Bug #1300361 reported by Dimitri John Ledkov
114
This bug affects 23 people
Affects Status Importance Assigned to Milestone
OEM Priority Project
Fix Released
High
Unassigned
Trusty
Fix Released
High
Unassigned
usb-creator (Ubuntu)
Fix Released
Critical
Dimitri John Ledkov
Trusty
Fix Released
High
Yu Ning

Bug Description

[Impact]
cannot erase the disk when no partition table is present

[Test Case]
cat /dev/zero >> /dev/sdX to erase the partition table (you can ctrl-c immediately, it's enough that the first bits are erased)

[Regression Potential]
Should not affect negatively the normal use case (=usb stick with partition table, one partition vfat formatted).

See original description

Related branches

lp://staging/~yuningdodo/usb-creator/usb-creator.lp1300361-format-parent-device-to-erase-correctly
Yu Ning (community): Disapprove
usb-creator hackers: Pending requested
Diff: 96 lines (+33/-26)
2 files modified
bin/usb-creator-helper (+26/-26)
debian/changelog (+7/-0)
lp://staging/usb-creator
lp://staging/ubuntu/utopic-proposed/usb-creator
lp://staging/~yuningdodo/usb-creator/usb-creator.lp1361474+lp1300361-recreate-udisks-client
Brian Murray: Approve
Diff: 68811 lines (+67798/-0) (has conflicts)
191 files modified
.bzr-builddeb/default.conf (+2/-0)
Makefile (+57/-0)
Messages.sh (+24/-0)
TODO (+27/-0)
bin/usb-creator-gtk (+93/-0)
bin/usb-creator-helper (+357/-0)
bin/usb-creator-kde (+110/-0)
dbus/com.ubuntu.USBCreator.conf (+23/-0)
dbus/com.ubuntu.USBCreator.service (+4/-0)
dbus/com.ubuntu.usbcreator.policy.in (+48/-0)
debian/Debian/usb-creator-gtk-16x16.xpm (+115/-0)
debian/Debian/usb-creator-gtk-32x32.xpm (+254/-0)
debian/Debian/usb-creator-gtk.svg (+440/-0)
debian/Debian/usb-creator-kde-16x16.xpm (+155/-0)
debian/Debian/usb-creator-kde-32x32.xpm (+466/-0)
debian/Debian/usb-creator-kde.svg (+1608/-0)
debian/Ubuntu/usb-creator-gtk.svg (+622/-0)
debian/Ubuntu/usb-creator-kde.svg (+1584/-0)
debian/changelog (+1222/-0)
debian/compat (+1/-0)
debian/control (+67/-0)
debian/copyright (+39/-0)
debian/pycompat (+1/-0)
debian/rules (+44/-0)
debian/source/format (+1/-0)
debian/source_usb-creator.py (+17/-0)
debian/usb-creator-common.install (+13/-0)
debian/usb-creator-gtk.conf (+31/-0)
debian/usb-creator-gtk.install (+5/-0)
debian/usb-creator-gtk.maintscript (+1/-0)
debian/usb-creator-gtk.manpages (+1/-0)
debian/usb-creator-gtk.menu (+6/-0)
debian/usb-creator-kde.install (+5/-0)
debian/usb-creator-kde.manpages (+1/-0)
debian/usb-creator-kde.menu (+6/-0)
desktop/usb-creator-gtk.desktop.in (+10/-0)
desktop/usb-creator-gtk.svg (+658/-0)
desktop/usb-creator-kde.desktop.in (+10/-0)
desktop/usb-creator-kde.svg (+1554/-0)
gui/ubuntu-nexus7-USAGE-NOTICE-en.txt (+21/-0)
gui/usbcreator-gtk.ui (+973/-0)
gui/usbcreator-kde.ui (+395/-0)
main.py (+58/-0)
man/usb-creator-gtk.8 (+66/-0)
man/usb-creator-kde.8 (+62/-0)
po/POTFILES.in (+38/-0)
po/af.po (+492/-0)
po/ar.po (+530/-0)
po/ast.po (+539/-0)
po/be.po (+530/-0)
po/bg.po (+541/-0)
po/bn.po (+508/-0)
po/bs.po (+500/-0)
po/ca.po (+543/-0)
po/cs.po (+533/-0)
po/csb.po (+534/-0)
po/cv.po (+499/-0)
po/da.po (+536/-0)
po/de.po (+549/-0)
po/dv.po (+496/-0)
po/ee.po (+492/-0)
po/el.po (+552/-0)
po/en_AU.po (+531/-0)
po/en_CA.po (+529/-0)
po/en_GB.po (+539/-0)
po/eo.po (+533/-0)
po/es.po (+538/-0)
po/et.po (+532/-0)
po/eu.po (+526/-0)
po/fa.po (+492/-0)
po/fi.po (+540/-0)
po/fo.po (+502/-0)
po/fr.po (+546/-0)
po/gl.po (+539/-0)
po/gu.po (+500/-0)
po/he.po (+535/-0)
po/hi.po (+492/-0)
po/hr.po (+534/-0)
po/hu.po (+541/-0)
po/id.po (+540/-0)
po/is.po (+520/-0)
po/it.po (+547/-0)
po/ja.po (+536/-0)
po/jv.po (+493/-0)
po/kk.po (+492/-0)
po/kn.po (+492/-0)
po/ko.po (+538/-0)
po/lt.po (+540/-0)
po/lv.po (+535/-0)
po/ml.po (+495/-0)
po/mr.po (+492/-0)
po/ms.po (+536/-0)
po/nap.po (+499/-0)
po/nb.po (+538/-0)
po/nds.po (+495/-0)
po/ne.po (+494/-0)
po/nl.po (+539/-0)
po/oc.po (+540/-0)
po/pl.po (+536/-0)
po/pt.po (+540/-0)
po/pt_BR.po (+546/-0)
po/ro.po (+537/-0)
po/ru.po (+540/-0)
po/si.po (+498/-0)
po/sk.po (+539/-0)
po/sl.po (+530/-0)
po/sq.po (+537/-0)
po/sr.po (+536/-0)
po/sv.po (+544/-0)
po/te.po (+492/-0)
po/th.po (+505/-0)
po/tr.po (+540/-0)
po/ug.po (+496/-0)
po/uk.po (+534/-0)
po/usbcreator.pot (+519/-0)
po/uz.po (+493/-0)
po/vi.po (+530/-0)
po/zh_CN.po (+523/-0)
po/zh_HK.po (+520/-0)
po/zh_TW.po (+522/-0)
setup.cfg (+7/-0)
setup.py (+42/-0)
tests/dbus-session.conf (+64/-0)
tests/dbus-session/org.freedesktop.UDisks.service (+3/-0)
tests/fake_udisks.py (+176/-0)
tests/run (+22/-0)
tests/run-win (+13/-0)
tests/test_udisks_backend.py (+93/-0)
tests/test_windows_backend.py (+12/-0)
tests/test_windows_frontend.py (+8/-0)
tools/_include.py (+3/-0)
tools/check_external_deps (+49/-0)
tools/pylauncher/Makefile (+102/-0)
tools/pylauncher/deletedir.c (+108/-0)
tools/pylauncher/deletedir.h (+28/-0)
tools/pylauncher/header.c (+121/-0)
tools/pylauncher/pack.py (+76/-0)
tools/pylauncher/pylauncher.c (+97/-0)
tools/pylauncher/pylauncher.exe.manifest (+26/-0)
tools/pylauncher/pyrun.c (+135/-0)
tools/pylauncher/resources.h (+6/-0)
tools/pylauncher/resources.rc (+13/-0)
tools/pylauncher/str.c (+34/-0)
tools/pylauncher/str.h (+9/-0)
tools/pylauncher/unpack.c (+416/-0)
tools/pylauncher/unpack.h (+38/-0)
tools/pypack/LICENSE (+339/-0)
tools/pypack/README (+69/-0)
tools/pypack/altgraph/Dot.py (+252/-0)
tools/pypack/altgraph/Graph.py (+626/-0)
tools/pypack/altgraph/GraphAlgo.py (+148/-0)
tools/pypack/altgraph/GraphStat.py (+78/-0)
tools/pypack/altgraph/GraphUtil.py (+122/-0)
tools/pypack/altgraph/ObjectGraph.py (+173/-0)
tools/pypack/altgraph/__init__.py (+133/-0)
tools/pypack/altgraph/compat.py (+183/-0)
tools/pypack/libpypack/__init__.py (+1/-0)
tools/pypack/libpypack/application.py (+217/-0)
tools/pypack/libpypack/version.py (+4/-0)
tools/pypack/modulegraph/__init__.py (+1/-0)
tools/pypack/modulegraph/find_modules.py (+280/-0)
tools/pypack/modulegraph/modulegraph.py (+969/-0)
tools/pypack/modulegraph/pkg_resources.py (+2584/-0)
tools/pypack/modulegraph/util.py (+82/-0)
tools/pypack/pypack (+27/-0)
usbcreator/backends/base/__init__.py (+1/-0)
usbcreator/backends/base/backend.py (+212/-0)
usbcreator/backends/fastboot/__init__.py (+1/-0)
usbcreator/backends/fastboot/backend.py (+68/-0)
usbcreator/backends/udisks/__init__.py (+1/-0)
usbcreator/backends/udisks/backend.py (+368/-0)
usbcreator/backends/windows/__init__.py (+1/-0)
usbcreator/backends/windows/backend.py (+194/-0)
usbcreator/frontends/base/__init__.py (+1/-0)
usbcreator/frontends/base/frontend.py (+2/-0)
usbcreator/frontends/gtk/__init__.py (+1/-0)
usbcreator/frontends/gtk/frontend.py (+819/-0)
usbcreator/frontends/gtk/unitysupport.py (+57/-0)
usbcreator/frontends/kde/__init__.py (+1/-0)
usbcreator/frontends/kde/frontend.py (+580/-0)
usbcreator/frontends/kde/kde_about.py (+68/-0)
usbcreator/frontends/kde/translate.py (+39/-0)
usbcreator/frontends/winui/__init__.py (+1/-0)
usbcreator/frontends/winui/frontend.py (+205/-0)
usbcreator/frontends/winui/install_window.py (+32/-0)
usbcreator/frontends/winui/main_dialog.py (+58/-0)
usbcreator/frontends/winui/winui/defs.py (+5326/-0)
usbcreator/frontends/winui/winui/ui.py (+759/-0)
usbcreator/install.py (+692/-0)
usbcreator/misc.py (+201/-0)
usbcreator/remtimest.py (+85/-0)
lp://staging/~yuningdodo/ubuntu/trusty/usb-creator/usb-creator.lp1361474+lp1300361-recreate-udisks-client
Brian Murray: Approve
Timo Jyrinki: Approve
Martin Pitt: Pending requested
Diff: 55 lines (+25/-2)
2 files modified
bin/usb-creator-helper (+13/-2)
debian/changelog (+12/-0)
lp://staging/ubuntu/trusty-proposed/usb-creator
Dimitri John Ledkov (xnox)
Changed in usb-creator (Ubuntu):
status: New → Confirmed
importance: Undecided → Critical
assignee: nobody → Dimitri John Ledkov (xnox)
Revision history for this message
Yu Ning (yuningdodo) wrote :

I can reproduce this issue in my side, and the backtrace is the same with bug #1305020

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

In my case the backtrace was "AttributeError: 'NoneType' object has no attribute 'get_cached_property'" (bug #1307622) in the case of no partition table, and it changed to the same backtrace as bug #1305020 after I added a (DOS) partition table: bug #1307627

Ara Pulido (ara)
Changed in oem-priority:
status: New → Triaged
importance: Undecided → High
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package usb-creator - 0.2.60

---------------
usb-creator (0.2.60) utopic; urgency=medium

  * Correctly detect partition-table less parent devices.
  * Rescan partitions, after creating fresh partition table.
  * Ignore errors from synchronisations after wipefs calls. (LP: #1300361)
  * Allow operation over loop devices, for ease of testing.
 -- Dimitri John Ledkov <email address hidden> Fri, 25 Jul 2014 14:22:02 +0100

Changed in usb-creator (Ubuntu):
status: Confirmed → Fix Released
Revision history for this message
Ara Pulido (ara) wrote :

Can we have this fix SRUed in Trusty, please?

Changed in oem-priority:
status: Triaged → In Progress
Revision history for this message
Dimitri John Ledkov (xnox) wrote : Re: [Bug 1300361] Re: cannot format when no partition table is present

On 30 July 2014 15:54, Ara Pulido <email address hidden> wrote:
> Can we have this fix SRUed in Trusty, please?
>

It's fixed for me, but please do test it on up-to-date usb-creator &
udisks2 on utopic.

And one of certification and/or sustaining engineers would need to
handle SRUs for the above two patches / packages, as I will not have
time to complete them by end of next week. I'm happy to review &
sponsor SRUs if someone prepares them.

--
Regards,

Dimitri.

Revision history for this message
Launchpad Janitor (janitor) wrote : Re: cannot format when no partition table is present

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in usb-creator (Ubuntu Trusty):
status: New → Confirmed
Revision history for this message
Yu Ning (yuningdodo) wrote :

I am attempt to backport Dimitri's patches to trusty. His patches are for usb-creator and udisks2, the udisks2 patch was already reverted in utopic, so I didn't backport it; and with the usb-creator patch only, the issue still can be reproduced. Could anyone help to verify if the issue is still fixed in utopic?

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Yu: I'm not sure so this is pure guessing, but bug #1059872 mentions another package, util-linux, in a related problem that has a fix in utopic but not yet in trusty. Of course, the whole new util-linux can't be SRU:d to trusty, but I wonder if that single fix "wipefs properly cleans up fs signatures" could be found, and would it help with this?

Or maybe there's something else in https://code.launchpad.net/~usb-creator-hackers/usb-creator/trunk needed that hasn't been backported to trusty, since there are quite many commits.

Revision history for this message
Yu Ning (yuningdodo) wrote :

@Timo, thanks for the reminder, let me check if I can locate and backport the util-linux patch.

Revision history for this message
Yu Ning (yuningdodo) wrote :

I verified with utopic, this issue is still reproduced with usb-creator 0.2.62 (as well as latest udisks2, util-linux, etc.).

Revision history for this message
Yu Ning (yuningdodo) wrote :

I have proposed a patch which should fix this issue:
https://code.launchpad.net/~yuningdodo/usb-creator/usb-creator.lp1361474+lp1300361-recreate-udisks-client/+merge/232693

Will anyone give it a try?

Revision history for this message
Yu Ning (yuningdodo) wrote :

Anyway, I think the util-linux patches are necessary for this bug, otherwise it will popup the timed out error.

Revision history for this message
Yu Ning (yuningdodo) wrote :

Hi, I have proposed two patches for this issue on trusty:

https://code.launchpad.net/~yuningdodo/ubuntu/trusty/usb-creator/usb-creator.lp1361474+lp1300361-recreate-udisks-client/+merge/232852
https://code.launchpad.net/~yuningdodo/ubuntu/trusty/util-linux/util-linux.backport-utopic-2.25-8ubuntu1/+merge/232848

With these two patches I can erase the usb stick successfully in below situations on trusty:
1. dos partition table and at least one partition
2. dos partition table without any partition
3. no partition table

For anyone who would like to give them a try, please refer to bug #1059872 comment #49 on how to build the backported util-linux.

Timo Jyrinki (timo-jyrinki)
Changed in usb-creator (Ubuntu Trusty):
importance: Undecided → High
Timo Jyrinki (timo-jyrinki)
description: updated
summary: - cannot format when no partition table is present
+ [SRU] cannot format when no partition table is present
Changed in usb-creator (Ubuntu Trusty):
assignee: nobody → Yu Ning (yuningdodo)
status: Confirmed → In Progress
Revision history for this message
Chris J Arges (arges) wrote : Please test proposed package

Hello Dimitri, or anyone else affected,

Accepted usb-creator into trusty-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/usb-creator/0.2.56.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in usb-creator (Ubuntu Trusty):
status: In Progress → Fix Committed
tags: added: verification-needed
Revision history for this message
Yu Ning (yuningdodo) wrote :

I made some tests on trusty with usb-creator-{common,gtk} 0.2.56.3.

1. create a usbstick with no partition table
2. erase it with usb-creator-gtk

I can erase it without popup error, but after the erasing it prompt "There is not enough free space for this image." and the "Make Startup Disk" button is inactivated. But if I erase it again now the prompt disappears and the button is activated, and I can burn the ISO image successfully.

So I think the issue is properly fixed. I'll update the tags for Trusty.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package usb-creator - 0.2.56.3

---------------
usb-creator (0.2.56.3) trusty-proposed; urgency=medium

  [ Brian Murray ]
  * udisks/backend.py: fix some calls to mount_sync that were missed in the
    port to the UDisks2 API. Thanks to Marc Culler for the patch.
    (LP: #1279987)

  [ Yu Ning ]
  * usb-creator-helper: use parent object only if there is a parent.
    (LP: #1380041)
  * usb-creator-helper: re-create the udisks client otherwise it will not
    return the newly created device or partition. (LP: #1361474, #1300361)
  * usb-creator-helper: use parted instead of udisks2 to create the new
    partition table since udisks2 uses wipefs to erase the old partition
    table, however partition table erasing is not supported in wipefs yet in
    trusty, and that would cause a timed out error.
 -- Brian Murray <email address hidden> Thu, 18 Dec 2014 14:48:14 -0800

Changed in usb-creator (Ubuntu Trusty):
status: Fix Committed → Fix Released
Revision history for this message
Chris J Arges (arges) wrote : Update Released

The verification of the Stable Release Update for usb-creator has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Ara Pulido (ara)
Changed in oem-priority:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.