| 2022-07-21 12:59:10 |
Dan Watkins |
bug |
|
|
added bug |
| 2022-07-27 14:24:56 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~oddbloke/update-notifier/+git/update-notifier/+merge/427497 |
|
| 2022-07-27 14:25:14 |
Dan Watkins |
update-notifier (Ubuntu): assignee |
|
Dan Watkins (oddbloke) |
|
| 2022-07-27 14:25:22 |
Dan Watkins |
update-notifier (Ubuntu): status |
New |
In Progress |
|
| 2022-07-27 14:33:42 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~oddbloke/update-notifier/+git/update-notifier/+merge/427498 |
|
| 2022-07-27 14:42:17 |
Dan Watkins |
description |
I've ended up in a situation where a machine's /dev/nbd* devices are in a broken state: the easiest way for me to fix this is to reboot the system. However, the reboot is blocked by update-motd-fsck-at-reboot trying to run dumpe2fs against one of the broken partitions:
$ ps faux
...
root 191396 0.0 0.2 37864 8672 ? Ss 12:37 0:00 sshd: dwatkins [priv]
root 191421 0.0 0.0 2608 480 ? S 12:37 0:00 \_ sh -c /usr/bin/env -i PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin run-parts --ls
root 191422 0.0 0.0 2496 508 ? S 12:37 0:00 \_ run-parts --lsbsysinit /etc/update-motd.d
root 191455 0.0 0.0 2608 1748 ? S 12:37 0:00 \_ /bin/sh /usr/lib/update-notifier/update-motd-fsck-at-reboot
root 191483 0.0 0.0 3480 944 ? D 12:37 0:00 \_ dumpe2fs -h /dev/nbd0p2
...
These NBD devices will not be present after a reboot, so I think the script would probably be more correct if it omitted operating on these devices. |
[Impact]
* update-motd-fsck-at-reboot will block shutdown if a broken NBD device is present in the system when it executes. In some configurations (e.g. when sudo authorisation is provided via sssd, which stops before this task completes), this can result in a hard power cycle being required to return a machine to service.
* Users with NBD devices will erroneously see them reported as devices that will be fsck'd at next boot.
[Test Plan]
* Get a QEMU image containing an ext4 partition (e.g. https://cloud-images.ubuntu.com/releases/focal/release/ubuntu-20.04-server-cloudimg-amd64.img)
* `qemu-nbd -c /dev/nbd0 <that image>`
* `mount /dev/nbd0p2 /mnt` (partition number may vary depending on your image)
* Execute `update-motd-fsck-at-reboot`
* Observe NBD device not included
[Where problems could occur]
If the one-line fix is incorrect, users may not receive notification of fsck'ing that is going to happen, which they may rely on.
[Original Report]
I've ended up in a situation where a machine's /dev/nbd* devices are in a broken state: the easiest way for me to fix this is to reboot the system. However, the reboot is blocked by update-motd-fsck-at-reboot trying to run dumpe2fs against one of the broken partitions:
$ ps faux
...
root 191396 0.0 0.2 37864 8672 ? Ss 12:37 0:00 sshd: dwatkins [priv]
root 191421 0.0 0.0 2608 480 ? S 12:37 0:00 \_ sh -c /usr/bin/env -i PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin run-parts --ls
root 191422 0.0 0.0 2496 508 ? S 12:37 0:00 \_ run-parts --lsbsysinit /etc/update-motd.d
root 191455 0.0 0.0 2608 1748 ? S 12:37 0:00 \_ /bin/sh /usr/lib/update-notifier/update-motd-fsck-at-reboot
root 191483 0.0 0.0 3480 944 ? D 12:37 0:00 \_ dumpe2fs -h /dev/nbd0p2
...
These NBD devices will not be present after a reboot, so I think the script would probably be more correct if it omitted operating on these devices. |
|
| 2022-07-27 15:49:31 |
Brian Murray |
tags |
|
rls-kk-incoming |
|
| 2022-07-28 15:21:14 |
Brian Murray |
update-notifier (Ubuntu): importance |
Undecided |
High |
|
| 2022-07-28 15:21:34 |
Matthieu Clemenceau |
tags |
rls-kk-incoming |
fr-2579 rls-kk-incoming |
|
| 2022-07-28 15:22:05 |
Lukas Märdian |
nominated for series |
|
Ubuntu Focal |
|
| 2022-07-28 15:22:05 |
Lukas Märdian |
bug task added |
|
update-notifier (Ubuntu Focal) |
|
| 2022-07-28 15:22:05 |
Lukas Märdian |
nominated for series |
|
Ubuntu Kinetic |
|
| 2022-07-28 15:22:05 |
Lukas Märdian |
bug task added |
|
update-notifier (Ubuntu Kinetic) |
|
| 2022-07-28 15:22:05 |
Lukas Märdian |
nominated for series |
|
Ubuntu Jammy |
|
| 2022-07-28 15:22:05 |
Lukas Märdian |
bug task added |
|
update-notifier (Ubuntu Jammy) |
|
| 2022-08-04 15:14:43 |
Brian Murray |
tags |
fr-2579 rls-kk-incoming |
fr-2579 |
|
| 2022-08-30 23:42:52 |
Launchpad Janitor |
update-notifier (Ubuntu Kinetic): status |
In Progress |
Fix Released |
|
| 2022-09-29 20:07:34 |
Matthieu Clemenceau |
bug |
|
|
added subscriber Ubuntu Foundations Bugs |
| 2022-09-30 12:21:55 |
Brian Murray |
update-notifier (Ubuntu Jammy): importance |
Undecided |
Medium |
|
| 2022-09-30 12:21:58 |
Brian Murray |
update-notifier (Ubuntu Jammy): status |
New |
Triaged |
|
| 2022-09-30 12:22:00 |
Brian Murray |
update-notifier (Ubuntu Focal): status |
New |
Triaged |
|
| 2022-09-30 12:22:03 |
Brian Murray |
update-notifier (Ubuntu Focal): importance |
Undecided |
Medium |
|
