| 2020-10-26 23:13:09 |
Chad Smith |
bug |
|
|
added bug |
| 2020-10-26 23:16:11 |
Chad Smith |
description |
Message of the day text should align with the messaging that is being surfaced by apt command line hook messaging.
This request for product naming changes/consolidation is also represented as a request against UA-Client tooling/apt-hooks/status messaging.
https://github.com/canonical/ubuntu-advantage-client/issues/1212#issuecomment-713735291 |
Message of the day text should align with the messaging that is being surfaced by apt command line hook messaging.
Expected product names:
UA Infra: Extended Security Maintenance (ESM)
or
UA Infra: ESM # for short.
This request for product naming changes/consolidation is also represented as a request against UA-Client tooling/apt-hooks/status messaging.
https://github.com/canonical/ubuntu-advantage-client/issues/1212#issuecomment-713735291 |
|
| 2020-10-26 23:16:25 |
Chad Smith |
description |
Message of the day text should align with the messaging that is being surfaced by apt command line hook messaging.
Expected product names:
UA Infra: Extended Security Maintenance (ESM)
or
UA Infra: ESM # for short.
This request for product naming changes/consolidation is also represented as a request against UA-Client tooling/apt-hooks/status messaging.
https://github.com/canonical/ubuntu-advantage-client/issues/1212#issuecomment-713735291 |
Message of the day text should align with the messaging that is being surfaced by apt command line hook messaging.
Expected product names:
UA Infra: Extended Security Maintenance (ESM)
or
UA Infra: ESM # for short.
This request for product naming changes and standardization is also represented as a request against UA-Client tooling/apt-hooks/status messaging.
https://github.com/canonical/ubuntu-advantage-client/issues/1212#issuecomment-713735291 |
|
| 2020-10-27 16:31:26 |
Chad Smith |
description |
Message of the day text should align with the messaging that is being surfaced by apt command line hook messaging.
Expected product names:
UA Infra: Extended Security Maintenance (ESM)
or
UA Infra: ESM # for short.
This request for product naming changes and standardization is also represented as a request against UA-Client tooling/apt-hooks/status messaging.
https://github.com/canonical/ubuntu-advantage-client/issues/1212#issuecomment-713735291 |
Message of the day text should align with the messaging that is being surfaced by apt command line hook messaging.
Current ESM product name is represent in MOTD as the following messages when logging into a VM:
### Current ESM-relatedMOTD messaging
# When ESM is disabled:
UA Infrastructure Extended Security Maintenance \(ESM\) is not enabled.
Enable UA Infrastructure ESM to receive 14 additional security updates.
# When ESM is enabled:
UA Infrastructure Extended Security Maintenance \(ESM\) is enabled.
14 of these updates are provided through UA Infrastructure ESM.
#### Expected new ESM messaging:
# When ESM is disabled:
UA Infra: Extended Security Maintenance \(ESM\) is not enabled.
Enable UA Infra: ESM to receive 14 additional security updates.
# When ESM is enabled:
UA Infra: Extended Security Maintenance \(ESM\) is enabled.
14 of these updates are provided through UA Infrastructure
UA Infra: Extended Security Maintenance \(ESM\) is not enabled.
Enable UA Infra: ESM to receive 14 additional security updates.
This request for product naming changes and standardization is also represented as a request against UA-Client tooling/apt-hooks/status messaging.
https://github.com/canonical/ubuntu-advantage-client/issues/1212#issuecomment-713735291 |
|
| 2020-10-27 16:31:45 |
Chad Smith |
description |
Message of the day text should align with the messaging that is being surfaced by apt command line hook messaging.
Current ESM product name is represent in MOTD as the following messages when logging into a VM:
### Current ESM-relatedMOTD messaging
# When ESM is disabled:
UA Infrastructure Extended Security Maintenance \(ESM\) is not enabled.
Enable UA Infrastructure ESM to receive 14 additional security updates.
# When ESM is enabled:
UA Infrastructure Extended Security Maintenance \(ESM\) is enabled.
14 of these updates are provided through UA Infrastructure ESM.
#### Expected new ESM messaging:
# When ESM is disabled:
UA Infra: Extended Security Maintenance \(ESM\) is not enabled.
Enable UA Infra: ESM to receive 14 additional security updates.
# When ESM is enabled:
UA Infra: Extended Security Maintenance \(ESM\) is enabled.
14 of these updates are provided through UA Infrastructure
UA Infra: Extended Security Maintenance \(ESM\) is not enabled.
Enable UA Infra: ESM to receive 14 additional security updates.
This request for product naming changes and standardization is also represented as a request against UA-Client tooling/apt-hooks/status messaging.
https://github.com/canonical/ubuntu-advantage-client/issues/1212#issuecomment-713735291 |
MOTD text should align with the messaging that is being surfaced by apt command line hook messaging.
Current ESM product name is represent in MOTD as the following messages when logging into a VM:
### Current ESM-relatedMOTD messaging
# When ESM is disabled:
UA Infrastructure Extended Security Maintenance \(ESM\) is not enabled.
Enable UA Infrastructure ESM to receive 14 additional security updates.
# When ESM is enabled:
UA Infrastructure Extended Security Maintenance \(ESM\) is enabled.
14 of these updates are provided through UA Infrastructure ESM.
#### Expected new ESM messaging:
# When ESM is disabled:
UA Infra: Extended Security Maintenance \(ESM\) is not enabled.
Enable UA Infra: ESM to receive 14 additional security updates.
# When ESM is enabled:
UA Infra: Extended Security Maintenance \(ESM\) is enabled.
14 of these updates are provided through UA Infrastructure
UA Infra: Extended Security Maintenance \(ESM\) is not enabled.
Enable UA Infra: ESM to receive 14 additional security updates.
This request for product naming changes and standardization is also represented as a request against UA-Client tooling/apt-hooks/status messaging.
https://github.com/canonical/ubuntu-advantage-client/issues/1212#issuecomment-713735291 |
|
| 2020-10-27 16:32:02 |
Chad Smith |
description |
MOTD text should align with the messaging that is being surfaced by apt command line hook messaging.
Current ESM product name is represent in MOTD as the following messages when logging into a VM:
### Current ESM-relatedMOTD messaging
# When ESM is disabled:
UA Infrastructure Extended Security Maintenance \(ESM\) is not enabled.
Enable UA Infrastructure ESM to receive 14 additional security updates.
# When ESM is enabled:
UA Infrastructure Extended Security Maintenance \(ESM\) is enabled.
14 of these updates are provided through UA Infrastructure ESM.
#### Expected new ESM messaging:
# When ESM is disabled:
UA Infra: Extended Security Maintenance \(ESM\) is not enabled.
Enable UA Infra: ESM to receive 14 additional security updates.
# When ESM is enabled:
UA Infra: Extended Security Maintenance \(ESM\) is enabled.
14 of these updates are provided through UA Infrastructure
UA Infra: Extended Security Maintenance \(ESM\) is not enabled.
Enable UA Infra: ESM to receive 14 additional security updates.
This request for product naming changes and standardization is also represented as a request against UA-Client tooling/apt-hooks/status messaging.
https://github.com/canonical/ubuntu-advantage-client/issues/1212#issuecomment-713735291 |
MOTD text should align with the messaging that is being surfaced by ubuntu-advantage-tools and apt command line hook messaging.
Current ESM product name is represent in MOTD as the following messages when logging into a VM:
### Current ESM-relatedMOTD messaging
# When ESM is disabled:
UA Infrastructure Extended Security Maintenance \(ESM\) is not enabled.
Enable UA Infrastructure ESM to receive 14 additional security updates.
# When ESM is enabled:
UA Infrastructure Extended Security Maintenance \(ESM\) is enabled.
14 of these updates are provided through UA Infrastructure ESM.
#### Expected new ESM messaging:
# When ESM is disabled:
UA Infra: Extended Security Maintenance \(ESM\) is not enabled.
Enable UA Infra: ESM to receive 14 additional security updates.
# When ESM is enabled:
UA Infra: Extended Security Maintenance \(ESM\) is enabled.
14 of these updates are provided through UA Infrastructure
UA Infra: Extended Security Maintenance \(ESM\) is not enabled.
Enable UA Infra: ESM to receive 14 additional security updates.
This request for product naming changes and standardization is also represented as a request against UA-Client tooling/apt-hooks/status messaging.
https://github.com/canonical/ubuntu-advantage-client/issues/1212#issuecomment-713735291 |
|
| 2020-10-27 16:32:18 |
Chad Smith |
description |
MOTD text should align with the messaging that is being surfaced by ubuntu-advantage-tools and apt command line hook messaging.
Current ESM product name is represent in MOTD as the following messages when logging into a VM:
### Current ESM-relatedMOTD messaging
# When ESM is disabled:
UA Infrastructure Extended Security Maintenance \(ESM\) is not enabled.
Enable UA Infrastructure ESM to receive 14 additional security updates.
# When ESM is enabled:
UA Infrastructure Extended Security Maintenance \(ESM\) is enabled.
14 of these updates are provided through UA Infrastructure ESM.
#### Expected new ESM messaging:
# When ESM is disabled:
UA Infra: Extended Security Maintenance \(ESM\) is not enabled.
Enable UA Infra: ESM to receive 14 additional security updates.
# When ESM is enabled:
UA Infra: Extended Security Maintenance \(ESM\) is enabled.
14 of these updates are provided through UA Infrastructure
UA Infra: Extended Security Maintenance \(ESM\) is not enabled.
Enable UA Infra: ESM to receive 14 additional security updates.
This request for product naming changes and standardization is also represented as a request against UA-Client tooling/apt-hooks/status messaging.
https://github.com/canonical/ubuntu-advantage-client/issues/1212#issuecomment-713735291 |
MOTD text should align with the messaging that is being surfaced by ubuntu-advantage-tools and apt command line hook messaging.
Current ESM product name is represented in MOTD as the following when logging into a VM:
### Current ESM-relatedMOTD messaging
# When ESM is disabled:
UA Infrastructure Extended Security Maintenance \(ESM\) is not enabled.
Enable UA Infrastructure ESM to receive 14 additional security updates.
# When ESM is enabled:
UA Infrastructure Extended Security Maintenance \(ESM\) is enabled.
14 of these updates are provided through UA Infrastructure ESM.
#### Expected new ESM messaging:
# When ESM is disabled:
UA Infra: Extended Security Maintenance \(ESM\) is not enabled.
Enable UA Infra: ESM to receive 14 additional security updates.
# When ESM is enabled:
UA Infra: Extended Security Maintenance \(ESM\) is enabled.
14 of these updates are provided through UA Infrastructure
UA Infra: Extended Security Maintenance \(ESM\) is not enabled.
Enable UA Infra: ESM to receive 14 additional security updates.
This request for product naming changes and standardization is also represented as a request against UA-Client tooling/apt-hooks/status messaging.
https://github.com/canonical/ubuntu-advantage-client/issues/1212#issuecomment-713735291 |
|
| 2020-11-05 20:58:02 |
Chad Smith |
update-notifier (Ubuntu): assignee |
|
Chad Smith (chad.smith) |
|
| 2020-11-05 20:58:57 |
Chad Smith |
description |
MOTD text should align with the messaging that is being surfaced by ubuntu-advantage-tools and apt command line hook messaging.
Current ESM product name is represented in MOTD as the following when logging into a VM:
### Current ESM-relatedMOTD messaging
# When ESM is disabled:
UA Infrastructure Extended Security Maintenance \(ESM\) is not enabled.
Enable UA Infrastructure ESM to receive 14 additional security updates.
# When ESM is enabled:
UA Infrastructure Extended Security Maintenance \(ESM\) is enabled.
14 of these updates are provided through UA Infrastructure ESM.
#### Expected new ESM messaging:
# When ESM is disabled:
UA Infra: Extended Security Maintenance \(ESM\) is not enabled.
Enable UA Infra: ESM to receive 14 additional security updates.
# When ESM is enabled:
UA Infra: Extended Security Maintenance \(ESM\) is enabled.
14 of these updates are provided through UA Infrastructure
UA Infra: Extended Security Maintenance \(ESM\) is not enabled.
Enable UA Infra: ESM to receive 14 additional security updates.
This request for product naming changes and standardization is also represented as a request against UA-Client tooling/apt-hooks/status messaging.
https://github.com/canonical/ubuntu-advantage-client/issues/1212#issuecomment-713735291 |
MOTD text should align with the messaging that is being surfaced by ubuntu-advantage-tools and apt command line hook messaging.
Current ESM product name is represented in MOTD as the following when logging into a VM:
### Current ESM-relatedMOTD messaging
# When ESM is disabled:
UA Infrastructure Extended Security Maintenance \(ESM\) is not enabled.
Enable UA Infrastructure ESM to receive 14 additional security updates.
# When ESM is enabled:
UA Infrastructure Extended Security Maintenance \(ESM\) is enabled.
14 of these updates are provided through UA Infrastructure ESM.
#### Expected new ESM messaging:
# When ESM is disabled:
UA Infra: Extended Security Maintenance \(ESM\) is not enabled.
Enable UA Infra: ESM to receive 14 additional security updates.
# When ESM is enabled:
UA Infra: Extended Security Maintenance \(ESM\) is enabled.
14 of these updates are provided through UA Infrastructure
UA Infra: Extended Security Maintenance \(ESM\) is not enabled.
Enable UA Infra: ESM to receive 14 additional security updates.
This request for product naming changes and standardization is also represented as a request against UA-Client tooling/apt-hooks/status messaging.
https://github.com/canonical/ubuntu-advantage-client/issues/1212#issuecomment-713735291
Additionally documentation URLs for esm are updated from ubuntu.com/esm -> ubuntu.com/security/esm. |
|
| 2020-11-05 20:59:03 |
Chad Smith |
update-notifier (Ubuntu): status |
New |
In Progress |
|
| 2020-11-05 20:59:06 |
Chad Smith |
update-notifier (Ubuntu): importance |
Undecided |
Low |
|
| 2020-11-05 21:11:25 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~chad.smith/update-notifier/+git/update-notifier/+merge/393418 |
|
| 2020-11-05 21:13:46 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~chad.smith/update-notifier/+git/update-notifier/+merge/393419 |
|
| 2020-11-17 04:08:03 |
Launchpad Janitor |
update-notifier (Ubuntu): status |
In Progress |
Fix Released |
|
| 2020-11-19 05:41:10 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~chad.smith/ubuntu/+source/update-notifier/+git/update-notifier/+merge/394160 |
|
| 2020-11-19 05:41:43 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~chad.smith/ubuntu/+source/update-notifier/+git/update-notifier/+merge/394161 |
|
| 2020-11-19 05:42:17 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~chad.smith/ubuntu/+source/update-notifier/+git/update-notifier/+merge/394162 |
|
| 2020-11-19 05:43:14 |
Chad Smith |
nominated for series |
|
Ubuntu Bionic |
|
| 2020-11-19 05:43:14 |
Chad Smith |
bug task added |
|
update-notifier (Ubuntu Bionic) |
|
| 2020-11-19 05:43:14 |
Chad Smith |
nominated for series |
|
Ubuntu Focal |
|
| 2020-11-19 05:43:14 |
Chad Smith |
bug task added |
|
update-notifier (Ubuntu Focal) |
|
| 2020-11-19 05:43:14 |
Chad Smith |
nominated for series |
|
Ubuntu Xenial |
|
| 2020-11-19 05:43:14 |
Chad Smith |
bug task added |
|
update-notifier (Ubuntu Xenial) |
|
| 2020-11-19 05:46:56 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~chad.smith/ubuntu/+source/update-notifier/+git/update-notifier/+merge/394164 |
|
| 2020-11-25 15:47:40 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~chad.smith/ubuntu/+source/update-notifier/+git/update-notifier/+merge/394468 |
|
| 2020-12-01 06:10:57 |
Chad Smith |
description |
MOTD text should align with the messaging that is being surfaced by ubuntu-advantage-tools and apt command line hook messaging.
Current ESM product name is represented in MOTD as the following when logging into a VM:
### Current ESM-relatedMOTD messaging
# When ESM is disabled:
UA Infrastructure Extended Security Maintenance \(ESM\) is not enabled.
Enable UA Infrastructure ESM to receive 14 additional security updates.
# When ESM is enabled:
UA Infrastructure Extended Security Maintenance \(ESM\) is enabled.
14 of these updates are provided through UA Infrastructure ESM.
#### Expected new ESM messaging:
# When ESM is disabled:
UA Infra: Extended Security Maintenance \(ESM\) is not enabled.
Enable UA Infra: ESM to receive 14 additional security updates.
# When ESM is enabled:
UA Infra: Extended Security Maintenance \(ESM\) is enabled.
14 of these updates are provided through UA Infrastructure
UA Infra: Extended Security Maintenance \(ESM\) is not enabled.
Enable UA Infra: ESM to receive 14 additional security updates.
This request for product naming changes and standardization is also represented as a request against UA-Client tooling/apt-hooks/status messaging.
https://github.com/canonical/ubuntu-advantage-client/issues/1212#issuecomment-713735291
Additionally documentation URLs for esm are updated from ubuntu.com/esm -> ubuntu.com/security/esm. |
[Impact]
The product names and product URLs of Ubuntu Advantage Extended Security Maintenance offerings have been rebranded prior to an official launch of the product ESM product in Ubuntu Xenial, Bionic and Focal. MOTD messages reference the old product name UA Infrastructure: Extended Security Maintenance as well as an invalid product URL https://ubuntu.com/esm.
Correct both the product name "UA Infra: ESM" and the apt URL message
See https://ubuntu.com/security/esm.
Because these text messages are translated using gettext, translations will need to be updated as well.
[Test Case]
* Install unreleased ubuntu-advantage-tools from a PPA
* Run: ua enable <yourToken> to activate UA apt repositories
* Check MOTD messaging related to UA Infra: ESM prior to upgrade to -proposed update-notifier via /usr/lib/update-notifier/apt-check --human-readable
* Upgrade update-notifier to -proposed
* Re-check MOTD messaging related to UA Infra: ESM to see expected messages
#!/bin/bash
#
# SRU Verification update-notifier + ubuntu=advantage-tools
# Test procedure:
# - launch container Trusty, Xenial or Bionic
# - Install ubuntu-advantage-tools from https://launchpad.net/~ua-client/+archive/ubuntu/proposed which supports esm on trusty, xenial, bionic, and focal
# - Attach container to UA subscription (which activates the ESM APT repos
# - run apt_check --human-readable to assert ESM pkg counts ARE NOT reported
# - Upgrade update-notifier to -proposed
# - re-run apt_check --human-readable to assert ESM pkg counts ARE reported
set -e
UA_TOKEN=$1
if [ -z "$1" ]; then
echo "Usage: $0 <contractTOKEN>"
exit 1
fi
# sources:
# ua.proposed:
# source: deb http://ppa.launchpad.net/canonical-server/ua-client-daily/ubuntu \$RELEASE main
# keyid: 94E187AD53A59D1847E4880F8A295C4FB8B190B7
cat > test-un.yaml <<EOF
#cloud-config
ssh_import_id: [chad.smith]
package_update: true
package_upgrade: true
apt:
sources:
ua.proposed:
source: deb http://ppa.launchpad.net/ua-client/staging/ubuntu \$RELEASE main
keyid: 6E34E7116C0BC933
EOF
cat > setup_proposed.sh <<EOF
#/bin/bash
mirror=http://archive.ubuntu.com/ubuntu
echo deb \$mirror \$(lsb_release -sc)-proposed main | tee /etc/apt/sources.list.d/proposed.list
apt-get update -q
apt-get install -qy update-notifier-common
EOF
wait_for_boot() {
local vm=$1 release=$2
echo "--- Wait for cloud-init to finish"
sleep 5
lxc exec ${vm} -- cloud-init status --wait --long
}
for release in xenial bionic focal groovy; do
echo "--- BEGIN $release update-notifier testing"
vm=test-sru-$release
echo "--- Launch cloud-init with ppa:ua-client/proposed enabled"
lxc launch ubuntu-daily:${release} ${vm} -c user.user-data="$(cat test-un.yaml)"
wait_for_boot ${vm} ${release}
echo "--- Attach Ubuntu-Advantage, enabling services"
lxc exec ${vm} -- ua attach ${UA_TOKEN}
echo "--- Install a downgraded hello package which ESM-focal delivers"
lxc exec ${vm} -- apt-get install hello=2.10-2ubuntu2
echo "--- Expect 0 upgradable packages for MOTD from apt_check before upgrade"
lxc exec ${vm} -- /usr/lib/update-notifier/apt-check --human-readable
lxc exec ${vm} -- /usr/lib/update-notifier/apt-check --human-readable | grep '0 of these updates are security updates' && echo "SUCCESS: found 0 ESM security updates pre-upgrade" || echo "FAILURE: did not find expected 0 ESM security updates"
echo "--- Upgrade update-notifier from -proposed"
lxc file push setup_proposed.sh ${vm}/
lxc exec ${vm} -- bash /setup_proposed.sh | grep update-notifier
echo "--- Expect non-zero upgradable packages for MOTD from apt_check AFTER upgrade"
lxc exec ${vm} -- /usr/lib/update-notifier/apt-check --human-readable | grep '1 of these updates is a security update' && echo "SUCCESS: found 1 ESM security updates pre-upgrade" || echo "FAILURE: did not find expected 1 ESM security updates"
done
[Where problems could occur]
* Low risk:
pep8 lint fixes plus MOTD text changes here. Minor logic changes in supplemental MOTD messaging for a product (ESM) that is not yet released and active in the wild on Xenial -> Focal. If messaging falls over the result is a lack of MOTD information about ESM package updates in motd, which is not yet released. If we can ensure we receive MOTD messaging about both ESM and non-ESM package updates without error, then risk of regression is minimal.
[Other Info]
[Original Description]
MOTD text should align with the messaging that is being surfaced by ubuntu-advantage-tools and apt command line hook messaging.
Current ESM product name is represented in MOTD as the following when logging into a VM:
### Current ESM-relatedMOTD messaging
# When ESM is disabled:
UA Infrastructure Extended Security Maintenance \(ESM\) is not enabled.
Enable UA Infrastructure ESM to receive 14 additional security updates.
# When ESM is enabled:
UA Infrastructure Extended Security Maintenance \(ESM\) is enabled.
14 of these updates are provided through UA Infrastructure ESM.
#### Expected new ESM messaging:
# When ESM is disabled:
UA Infra: Extended Security Maintenance \(ESM\) is not enabled.
Enable UA Infra: ESM to receive 14 additional security updates.
# When ESM is enabled:
UA Infra: Extended Security Maintenance \(ESM\) is enabled.
14 of these updates are provided through UA Infrastructure
UA Infra: Extended Security Maintenance \(ESM\) is not enabled.
Enable UA Infra: ESM to receive 14 additional security updates.
This request for product naming changes and standardization is also represented as a request against UA-Client tooling/apt-hooks/status messaging.
https://github.com/canonical/ubuntu-advantage-client/issues/1212#issuecomment-713735291
Additionally documentation URLs for esm are updated from ubuntu.com/esm -> ubuntu.com/security/esm. |
|
| 2020-12-02 04:42:19 |
Launchpad Janitor |
merge proposal unlinked |
https://code.launchpad.net/~chad.smith/ubuntu/+source/update-notifier/+git/update-notifier/+merge/394161 |
|
|
| 2020-12-02 15:29:29 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~chad.smith/ubuntu/+source/update-notifier/+git/update-notifier/+merge/394161 |
|
| 2020-12-03 21:36:20 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~chad.smith/ubuntu/+source/update-notifier/+git/update-notifier/+merge/394853 |
|
| 2020-12-03 21:48:14 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~chad.smith/ubuntu/+source/update-notifier/+git/update-notifier/+merge/394854 |
|
| 2020-12-04 16:58:12 |
Timo Aaltonen |
update-notifier (Ubuntu Groovy): status |
New |
Fix Committed |
|
| 2020-12-04 16:58:14 |
Timo Aaltonen |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2020-12-04 16:58:17 |
Timo Aaltonen |
bug |
|
|
added subscriber SRU Verification |
| 2020-12-04 16:58:21 |
Timo Aaltonen |
tags |
|
verification-needed verification-needed-groovy |
|
| 2020-12-04 17:34:42 |
Timo Aaltonen |
update-notifier (Ubuntu Focal): status |
New |
Fix Committed |
|
| 2020-12-04 17:34:49 |
Timo Aaltonen |
tags |
verification-needed verification-needed-groovy |
verification-needed verification-needed-focal verification-needed-groovy |
|
| 2020-12-04 17:44:33 |
Timo Aaltonen |
update-notifier (Ubuntu Bionic): status |
New |
Fix Committed |
|
| 2020-12-04 17:44:42 |
Timo Aaltonen |
tags |
verification-needed verification-needed-focal verification-needed-groovy |
verification-needed verification-needed-bionic verification-needed-focal verification-needed-groovy |
|
| 2020-12-04 17:56:00 |
Timo Aaltonen |
update-notifier (Ubuntu Xenial): status |
New |
Fix Committed |
|
| 2020-12-04 17:56:06 |
Timo Aaltonen |
tags |
verification-needed verification-needed-bionic verification-needed-focal verification-needed-groovy |
verification-needed verification-needed-bionic verification-needed-focal verification-needed-groovy verification-needed-xenial |
|
| 2020-12-18 23:14:23 |
Chad Smith |
description |
[Impact]
The product names and product URLs of Ubuntu Advantage Extended Security Maintenance offerings have been rebranded prior to an official launch of the product ESM product in Ubuntu Xenial, Bionic and Focal. MOTD messages reference the old product name UA Infrastructure: Extended Security Maintenance as well as an invalid product URL https://ubuntu.com/esm.
Correct both the product name "UA Infra: ESM" and the apt URL message
See https://ubuntu.com/security/esm.
Because these text messages are translated using gettext, translations will need to be updated as well.
[Test Case]
* Install unreleased ubuntu-advantage-tools from a PPA
* Run: ua enable <yourToken> to activate UA apt repositories
* Check MOTD messaging related to UA Infra: ESM prior to upgrade to -proposed update-notifier via /usr/lib/update-notifier/apt-check --human-readable
* Upgrade update-notifier to -proposed
* Re-check MOTD messaging related to UA Infra: ESM to see expected messages
#!/bin/bash
#
# SRU Verification update-notifier + ubuntu=advantage-tools
# Test procedure:
# - launch container Trusty, Xenial or Bionic
# - Install ubuntu-advantage-tools from https://launchpad.net/~ua-client/+archive/ubuntu/proposed which supports esm on trusty, xenial, bionic, and focal
# - Attach container to UA subscription (which activates the ESM APT repos
# - run apt_check --human-readable to assert ESM pkg counts ARE NOT reported
# - Upgrade update-notifier to -proposed
# - re-run apt_check --human-readable to assert ESM pkg counts ARE reported
set -e
UA_TOKEN=$1
if [ -z "$1" ]; then
echo "Usage: $0 <contractTOKEN>"
exit 1
fi
# sources:
# ua.proposed:
# source: deb http://ppa.launchpad.net/canonical-server/ua-client-daily/ubuntu \$RELEASE main
# keyid: 94E187AD53A59D1847E4880F8A295C4FB8B190B7
cat > test-un.yaml <<EOF
#cloud-config
ssh_import_id: [chad.smith]
package_update: true
package_upgrade: true
apt:
sources:
ua.proposed:
source: deb http://ppa.launchpad.net/ua-client/staging/ubuntu \$RELEASE main
keyid: 6E34E7116C0BC933
EOF
cat > setup_proposed.sh <<EOF
#/bin/bash
mirror=http://archive.ubuntu.com/ubuntu
echo deb \$mirror \$(lsb_release -sc)-proposed main | tee /etc/apt/sources.list.d/proposed.list
apt-get update -q
apt-get install -qy update-notifier-common
EOF
wait_for_boot() {
local vm=$1 release=$2
echo "--- Wait for cloud-init to finish"
sleep 5
lxc exec ${vm} -- cloud-init status --wait --long
}
for release in xenial bionic focal groovy; do
echo "--- BEGIN $release update-notifier testing"
vm=test-sru-$release
echo "--- Launch cloud-init with ppa:ua-client/proposed enabled"
lxc launch ubuntu-daily:${release} ${vm} -c user.user-data="$(cat test-un.yaml)"
wait_for_boot ${vm} ${release}
echo "--- Attach Ubuntu-Advantage, enabling services"
lxc exec ${vm} -- ua attach ${UA_TOKEN}
echo "--- Install a downgraded hello package which ESM-focal delivers"
lxc exec ${vm} -- apt-get install hello=2.10-2ubuntu2
echo "--- Expect 0 upgradable packages for MOTD from apt_check before upgrade"
lxc exec ${vm} -- /usr/lib/update-notifier/apt-check --human-readable
lxc exec ${vm} -- /usr/lib/update-notifier/apt-check --human-readable | grep '0 of these updates are security updates' && echo "SUCCESS: found 0 ESM security updates pre-upgrade" || echo "FAILURE: did not find expected 0 ESM security updates"
echo "--- Upgrade update-notifier from -proposed"
lxc file push setup_proposed.sh ${vm}/
lxc exec ${vm} -- bash /setup_proposed.sh | grep update-notifier
echo "--- Expect non-zero upgradable packages for MOTD from apt_check AFTER upgrade"
lxc exec ${vm} -- /usr/lib/update-notifier/apt-check --human-readable | grep '1 of these updates is a security update' && echo "SUCCESS: found 1 ESM security updates pre-upgrade" || echo "FAILURE: did not find expected 1 ESM security updates"
done
[Where problems could occur]
* Low risk:
pep8 lint fixes plus MOTD text changes here. Minor logic changes in supplemental MOTD messaging for a product (ESM) that is not yet released and active in the wild on Xenial -> Focal. If messaging falls over the result is a lack of MOTD information about ESM package updates in motd, which is not yet released. If we can ensure we receive MOTD messaging about both ESM and non-ESM package updates without error, then risk of regression is minimal.
[Other Info]
[Original Description]
MOTD text should align with the messaging that is being surfaced by ubuntu-advantage-tools and apt command line hook messaging.
Current ESM product name is represented in MOTD as the following when logging into a VM:
### Current ESM-relatedMOTD messaging
# When ESM is disabled:
UA Infrastructure Extended Security Maintenance \(ESM\) is not enabled.
Enable UA Infrastructure ESM to receive 14 additional security updates.
# When ESM is enabled:
UA Infrastructure Extended Security Maintenance \(ESM\) is enabled.
14 of these updates are provided through UA Infrastructure ESM.
#### Expected new ESM messaging:
# When ESM is disabled:
UA Infra: Extended Security Maintenance \(ESM\) is not enabled.
Enable UA Infra: ESM to receive 14 additional security updates.
# When ESM is enabled:
UA Infra: Extended Security Maintenance \(ESM\) is enabled.
14 of these updates are provided through UA Infrastructure
UA Infra: Extended Security Maintenance \(ESM\) is not enabled.
Enable UA Infra: ESM to receive 14 additional security updates.
This request for product naming changes and standardization is also represented as a request against UA-Client tooling/apt-hooks/status messaging.
https://github.com/canonical/ubuntu-advantage-client/issues/1212#issuecomment-713735291
Additionally documentation URLs for esm are updated from ubuntu.com/esm -> ubuntu.com/security/esm. |
[Impact]
The product names and product URLs of Ubuntu Advantage Extended Security Maintenance offerings have been rebranded prior to an official launch of the product ESM product in Ubuntu Xenial, Bionic and Focal. MOTD messages reference the old product name UA Infrastructure: Extended Security Maintenance as well as an invalid product URL https://ubuntu.com/esm.
Correct both the product name "UA Infra: ESM" and the apt URL message
See https://ubuntu.com/security/esm.
Because these text messages are translated using gettext, translations will need to be updated as well.
[Test Case]
* Install unreleased ubuntu-advantage-tools from a PPA
* Run: ua enable <yourToken> to activate UA apt repositories
* Check MOTD messaging related to UA Infra: ESM prior to upgrade to -proposed update-notifier via /usr/lib/update-notifier/apt-check --human-readable
* Upgrade update-notifier to -proposed
* Re-check MOTD messaging related to UA Infra: ESM to see expected messages (not on groovy as there are no esm repos)
#!/bin/bash
#
# SRU Verification update-notifier + ubuntu=advantage-tools
# Test procedure:
# - launch container Trusty, Xenial or Bionic
# - Install ubuntu-advantage-tools from https://launchpad.net/~ua-client/+archive/ubuntu/proposed which supports esm on trusty, xenial, bionic, and focal
# - Attach container to UA subscription (which activates the ESM APT repos
# - run apt_check --human-readable to assert ESM pkg counts ARE NOT reported
# - Upgrade update-notifier to -proposed
# - re-run apt_check --human-readable to assert ESM pkg counts ARE reported
set -e
UA_TOKEN=$1
if [ -z "$1" ]; then
echo "Usage: $0 <contractTOKEN>"
exit 1
fi
cat > test-un.yaml <<EOF
#cloud-config
ssh_import_id: [chad.smith]
package_update: true
package_upgrade: true
apt:
sources:
ua.proposed:
source: deb http://ppa.launchpad.net/ua-client/staging/ubuntu \$RELEASE main
keyid: 6E34E7116C0BC933
EOF
cat > setup_proposed.sh <<EOF
#/bin/bash
mirror=http://archive.ubuntu.com/ubuntu
echo deb \$mirror \$(lsb_release -sc)-proposed main | tee /etc/apt/sources.list.d/proposed.list
apt-get update -q
apt-get install -qy update-notifier-common
EOF
wait_for_boot() {
local vm=$1 release=$2
echo "--- Wait for cloud-init to finish"
sleep 5
lxc exec ${vm} -- cloud-init status --wait --long
}
for release in focal; do
echo "--- BEGIN $release update-notifier testing"
vm=test-sru-$release
echo "--- Launch cloud-init with ppa:ua-client/proposed enabled"
lxc launch ubuntu-daily:${release} ${vm} -c user.user-data="$(cat test-un.yaml)"
wait_for_boot ${vm} ${release}
echo "--- Attach Ubuntu-Advantage, enabling services"
lxc exec ${vm} -- ua attach ${UA_TOKEN}
case "$release" in
xenial) downrev_pkg="libkrad0=1.13.2+dfsg-5";;
bionic) downrev_pkg="libkrad0=1.16-2build1";;
focal) downrev_pkg="hello=2.10-2ubuntu2";;
groovy) downrev_pkg="apport-retrace=2.20.11-0ubuntu50";;
esac
echo "-- Downgrading esm package to stable ubuntu release ver $downrev_pkg"
lxc exec ${vm} -- apt-get install $downrev_pkg --yes
lxc exec ${vm} -- dpkg-query --show update-notifier
echo "--- Expect 0 upgradable packages for MOTD from apt_check before upgrade"
lxc exec ${vm} -- /usr/lib/update-notifier/apt-check --human-readable
lxc exec ${vm} -- /usr/lib/update-notifier/apt-check --human-readable | grep '0 of these updates are security updates' && echo "SUCCESS: found 0 ESM security updates pre-upgrade" || echo "FAILURE: did not find expected 0 ESM security updates"
echo "--- Upgrade update-notifier from -proposed"
lxc file push setup_proposed.sh ${vm}/
lxc exec ${vm} -- bash /setup_proposed.sh | grep update-notifier
lxc exec ${vm} -- dpkg-query --show update-notifier
echo "--- Expect non-zero upgradable packages for MOTD from apt_check AFTER upgrade"
lxc exec ${vm} -- /usr/lib/update-notifier/apt-check --human-readable | grep '1 of these updates is a security update' && echo "SUCCESS: found 1 ESM security updates pre-upgrade" || echo "FAILURE: did not find expected 1 ESM security updates"
done
[Where problems could occur]
* Low risk:
pep8 lint fixes plus MOTD text changes here. Minor logic changes in supplemental MOTD messaging for a product (ESM) that is not yet released and active in the wild on Xenial -> Focal. If messaging falls over the result is a lack of MOTD information about ESM package updates in motd, which is not yet released. If we can ensure we receive MOTD messaging about both ESM and non-ESM package updates without error, then risk of regression is minimal.
[Other Info]
[Original Description]
MOTD text should align with the messaging that is being surfaced by ubuntu-advantage-tools and apt command line hook messaging.
Current ESM product name is represented in MOTD as the following when logging into a VM:
### Current ESM-relatedMOTD messaging
# When ESM is disabled:
UA Infrastructure Extended Security Maintenance \(ESM\) is not enabled.
Enable UA Infrastructure ESM to receive 14 additional security updates.
# When ESM is enabled:
UA Infrastructure Extended Security Maintenance \(ESM\) is enabled.
14 of these updates are provided through UA Infrastructure ESM.
#### Expected new ESM messaging:
# When ESM is disabled:
UA Infra: Extended Security Maintenance \(ESM\) is not enabled.
Enable UA Infra: ESM to receive 14 additional security updates.
# When ESM is enabled:
UA Infra: Extended Security Maintenance \(ESM\) is enabled.
14 of these updates are provided through UA Infrastructure
UA Infra: Extended Security Maintenance \(ESM\) is not enabled.
Enable UA Infra: ESM to receive 14 additional security updates.
This request for product naming changes and standardization is also represented as a request against UA-Client tooling/apt-hooks/status messaging.
https://github.com/canonical/ubuntu-advantage-client/issues/1212#issuecomment-713735291
Additionally documentation URLs for esm are updated from ubuntu.com/esm -> ubuntu.com/security/esm. |
|
| 2020-12-18 23:40:07 |
Chad Smith |
description |
[Impact]
The product names and product URLs of Ubuntu Advantage Extended Security Maintenance offerings have been rebranded prior to an official launch of the product ESM product in Ubuntu Xenial, Bionic and Focal. MOTD messages reference the old product name UA Infrastructure: Extended Security Maintenance as well as an invalid product URL https://ubuntu.com/esm.
Correct both the product name "UA Infra: ESM" and the apt URL message
See https://ubuntu.com/security/esm.
Because these text messages are translated using gettext, translations will need to be updated as well.
[Test Case]
* Install unreleased ubuntu-advantage-tools from a PPA
* Run: ua enable <yourToken> to activate UA apt repositories
* Check MOTD messaging related to UA Infra: ESM prior to upgrade to -proposed update-notifier via /usr/lib/update-notifier/apt-check --human-readable
* Upgrade update-notifier to -proposed
* Re-check MOTD messaging related to UA Infra: ESM to see expected messages (not on groovy as there are no esm repos)
#!/bin/bash
#
# SRU Verification update-notifier + ubuntu=advantage-tools
# Test procedure:
# - launch container Trusty, Xenial or Bionic
# - Install ubuntu-advantage-tools from https://launchpad.net/~ua-client/+archive/ubuntu/proposed which supports esm on trusty, xenial, bionic, and focal
# - Attach container to UA subscription (which activates the ESM APT repos
# - run apt_check --human-readable to assert ESM pkg counts ARE NOT reported
# - Upgrade update-notifier to -proposed
# - re-run apt_check --human-readable to assert ESM pkg counts ARE reported
set -e
UA_TOKEN=$1
if [ -z "$1" ]; then
echo "Usage: $0 <contractTOKEN>"
exit 1
fi
cat > test-un.yaml <<EOF
#cloud-config
ssh_import_id: [chad.smith]
package_update: true
package_upgrade: true
apt:
sources:
ua.proposed:
source: deb http://ppa.launchpad.net/ua-client/staging/ubuntu \$RELEASE main
keyid: 6E34E7116C0BC933
EOF
cat > setup_proposed.sh <<EOF
#/bin/bash
mirror=http://archive.ubuntu.com/ubuntu
echo deb \$mirror \$(lsb_release -sc)-proposed main | tee /etc/apt/sources.list.d/proposed.list
apt-get update -q
apt-get install -qy update-notifier-common
EOF
wait_for_boot() {
local vm=$1 release=$2
echo "--- Wait for cloud-init to finish"
sleep 5
lxc exec ${vm} -- cloud-init status --wait --long
}
for release in focal; do
echo "--- BEGIN $release update-notifier testing"
vm=test-sru-$release
echo "--- Launch cloud-init with ppa:ua-client/proposed enabled"
lxc launch ubuntu-daily:${release} ${vm} -c user.user-data="$(cat test-un.yaml)"
wait_for_boot ${vm} ${release}
echo "--- Attach Ubuntu-Advantage, enabling services"
lxc exec ${vm} -- ua attach ${UA_TOKEN}
case "$release" in
xenial) downrev_pkg="libkrad0=1.13.2+dfsg-5";;
bionic) downrev_pkg="libkrad0=1.16-2build1";;
focal) downrev_pkg="hello=2.10-2ubuntu2";;
groovy) downrev_pkg="apport-retrace=2.20.11-0ubuntu50";;
esac
echo "-- Downgrading esm package to stable ubuntu release ver $downrev_pkg"
lxc exec ${vm} -- apt-get install $downrev_pkg --yes
lxc exec ${vm} -- dpkg-query --show update-notifier
echo "--- Expect 0 upgradable packages for MOTD from apt_check before upgrade"
lxc exec ${vm} -- /usr/lib/update-notifier/apt-check --human-readable
lxc exec ${vm} -- /usr/lib/update-notifier/apt-check --human-readable | grep '0 of these updates are security updates' && echo "SUCCESS: found 0 ESM security updates pre-upgrade" || echo "FAILURE: did not find expected 0 ESM security updates"
echo "--- Upgrade update-notifier from -proposed"
lxc file push setup_proposed.sh ${vm}/
lxc exec ${vm} -- bash /setup_proposed.sh | grep update-notifier
lxc exec ${vm} -- dpkg-query --show update-notifier
echo "--- Expect non-zero upgradable packages for MOTD from apt_check AFTER upgrade"
lxc exec ${vm} -- /usr/lib/update-notifier/apt-check --human-readable | grep '1 of these updates is a security update' && echo "SUCCESS: found 1 ESM security updates pre-upgrade" || echo "FAILURE: did not find expected 1 ESM security updates"
done
[Where problems could occur]
* Low risk:
pep8 lint fixes plus MOTD text changes here. Minor logic changes in supplemental MOTD messaging for a product (ESM) that is not yet released and active in the wild on Xenial -> Focal. If messaging falls over the result is a lack of MOTD information about ESM package updates in motd, which is not yet released. If we can ensure we receive MOTD messaging about both ESM and non-ESM package updates without error, then risk of regression is minimal.
[Other Info]
[Original Description]
MOTD text should align with the messaging that is being surfaced by ubuntu-advantage-tools and apt command line hook messaging.
Current ESM product name is represented in MOTD as the following when logging into a VM:
### Current ESM-relatedMOTD messaging
# When ESM is disabled:
UA Infrastructure Extended Security Maintenance \(ESM\) is not enabled.
Enable UA Infrastructure ESM to receive 14 additional security updates.
# When ESM is enabled:
UA Infrastructure Extended Security Maintenance \(ESM\) is enabled.
14 of these updates are provided through UA Infrastructure ESM.
#### Expected new ESM messaging:
# When ESM is disabled:
UA Infra: Extended Security Maintenance \(ESM\) is not enabled.
Enable UA Infra: ESM to receive 14 additional security updates.
# When ESM is enabled:
UA Infra: Extended Security Maintenance \(ESM\) is enabled.
14 of these updates are provided through UA Infrastructure
UA Infra: Extended Security Maintenance \(ESM\) is not enabled.
Enable UA Infra: ESM to receive 14 additional security updates.
This request for product naming changes and standardization is also represented as a request against UA-Client tooling/apt-hooks/status messaging.
https://github.com/canonical/ubuntu-advantage-client/issues/1212#issuecomment-713735291
Additionally documentation URLs for esm are updated from ubuntu.com/esm -> ubuntu.com/security/esm. |
[Impact]
The product names and product URLs of Ubuntu Advantage Extended Security Maintenance offerings have been rebranded prior to an official launch of the product ESM product in Ubuntu Xenial, Bionic and Focal. MOTD messages reference the old product name UA Infrastructure: Extended Security Maintenance as well as an invalid product URL https://ubuntu.com/esm.
Correct both the product name "UA Infra: ESM" and the apt URL message
See https://ubuntu.com/security/esm.
Because these text messages are translated using gettext, translations will need to be updated as well.
[Test Case]
* Install unreleased ubuntu-advantage-tools from a PPA
* Run: ua enable <yourToken> to activate UA apt repositories
* Check MOTD messaging related to UA Infra: ESM prior to upgrade to -proposed update-notifier via /usr/lib/update-notifier/apt-check --human-readable
* Upgrade update-notifier to -proposed
* Re-check MOTD messaging related to UA Infra: ESM to see expected messages (not on groovy as there are no esm repos)
#!/bin/bash
#
# SRU Verification update-notifier + ubuntu=advantage-tools
# Test procedure:
# - launch container Trusty, Xenial or Bionic
# - Install ubuntu-advantage-tools from https://launchpad.net/~ua-client/+archive/ubuntu/proposed which supports esm on trusty, xenial, bionic, and focal
# - Attach container to UA subscription (which activates the ESM APT repos
# - run apt_check --human-readable to assert ESM pkg counts ARE NOT reported
# - Upgrade update-notifier to -proposed
# - re-run apt_check --human-readable to assert ESM pkg counts ARE reported
set -e
UA_TOKEN=$1
if [ -z "$1" ]; then
echo "Usage: $0 <contractTOKEN>"
exit 1
fi
cat > test-un.yaml <<EOF
#cloud-config
ssh_import_id: [chad.smith]
package_update: true
package_upgrade: true
apt:
sources:
ua.proposed:
source: deb http://ppa.launchpad.net/ua-client/staging/ubuntu \$RELEASE main
keyid: 6E34E7116C0BC933
EOF
cat > setup_proposed.sh <<EOF
#/bin/bash
mirror=http://archive.ubuntu.com/ubuntu
echo deb \$mirror \$(lsb_release -sc)-proposed main | tee /etc/apt/sources.list.d/proposed.list
apt-get update -q
apt-get install -qy update-notifier-common
EOF
wait_for_boot() {
local vm=$1 release=$2
echo "--- Wait for cloud-init to finish"
sleep 5
lxc exec ${vm} -- cloud-init status --wait --long
}
for release in groovy; do
echo "--- BEGIN $release update-notifier testing"
vm=test-sru-$release
echo "--- Launch cloud-init with ppa:ua-client/proposed enabled"
lxc launch ubuntu-daily:${release} ${vm} -c user.user-data="$(cat test-un.yaml)"
wait_for_boot ${vm} ${release}
echo "--- Attach Ubuntu-Advantage, enabling services"
lxc exec ${vm} -- ua attach ${UA_TOKEN}
case "$release" in
xenial) downrev_pkg="libkrad0=1.13.2+dfsg-5";;
bionic) downrev_pkg="libkrad0=1.16-2build1";;
focal) downrev_pkg="hello=2.10-2ubuntu2";;
groovy) downrev_pkg="apport-retrace=2.20.11-0ubuntu50";;
esac
echo "-- Downgrading esm package to stable ubuntu release ver $downrev_pkg"
lxc exec ${vm} -- apt-get install $downrev_pkg --yes
lxc exec ${vm} -- dpkg-query --show update-notifier
lxc exec ${vm} -- /usr/lib/update-notifier/apt-check --human-readable
if [ "$release" = "groovy" ]; then
UPGRADE_MATCH="1 of these updates is a security update"
echo "Expect 1 upgradable package due to downgrade of non-esm pkg $downrev_pkg"
else
UPGRADE_MATCH="0 of these updates are security updates"
UPGRADE_COUNT=0
echo "--- Expect 0 upgradable packages for MOTD from apt_check before upgrade"
fi
lxc exec ${vm} -- /usr/lib/update-notifier/apt-check --human-readable
lxc exec ${vm} -- /usr/lib/update-notifier/apt-check --human-readable | grep "${UPGRADE_MATCH}" && echo "SUCCESS: found ${UPGRADE_COUNT} security updates pre-upgrade" || echo "FAILURE: did not find expected ${UPGRADE_COUNT} ESM security updates"
echo "--- Upgrade update-notifier from -proposed"
lxc file push setup_proposed.sh ${vm}/
lxc exec ${vm} -- bash /setup_proposed.sh | grep update-notifier
lxc exec ${vm} -- dpkg-query --show update-notifier
echo "--- Expect non-zero upgradable packages for MOTD from apt_check AFTER upgrade"
lxc exec ${vm} -- /usr/lib/update-notifier/apt-check --human-readable
lxc exec ${vm} -- /usr/lib/update-notifier/apt-check --human-readable | grep '1 of these updates is a security update' && echo "SUCCESS: found 1 ESM security updates pre-upgrade" || echo "FAILURE: did not find expected 1 ESM security updates"
done
[Where problems could occur]
* Low risk:
pep8 lint fixes plus MOTD text changes here. Minor logic changes in supplemental MOTD messaging for a product (ESM) that is not yet released and active in the wild on Xenial -> Focal. If messaging falls over the result is a lack of MOTD information about ESM package updates in motd, which is not yet released. If we can ensure we receive MOTD messaging about both ESM and non-ESM package updates without error, then risk of regression is minimal.
[Other Info]
[Original Description]
MOTD text should align with the messaging that is being surfaced by ubuntu-advantage-tools and apt command line hook messaging.
Current ESM product name is represented in MOTD as the following when logging into a VM:
### Current ESM-relatedMOTD messaging
# When ESM is disabled:
UA Infrastructure Extended Security Maintenance \(ESM\) is not enabled.
Enable UA Infrastructure ESM to receive 14 additional security updates.
# When ESM is enabled:
UA Infrastructure Extended Security Maintenance \(ESM\) is enabled.
14 of these updates are provided through UA Infrastructure ESM.
#### Expected new ESM messaging:
# When ESM is disabled:
UA Infra: Extended Security Maintenance \(ESM\) is not enabled.
Enable UA Infra: ESM to receive 14 additional security updates.
# When ESM is enabled:
UA Infra: Extended Security Maintenance \(ESM\) is enabled.
14 of these updates are provided through UA Infrastructure
UA Infra: Extended Security Maintenance \(ESM\) is not enabled.
Enable UA Infra: ESM to receive 14 additional security updates.
This request for product naming changes and standardization is also represented as a request against UA-Client tooling/apt-hooks/status messaging.
https://github.com/canonical/ubuntu-advantage-client/issues/1212#issuecomment-713735291
Additionally documentation URLs for esm are updated from ubuntu.com/esm -> ubuntu.com/security/esm. |
|
| 2020-12-18 23:40:33 |
Chad Smith |
tags |
verification-needed verification-needed-bionic verification-needed-focal verification-needed-groovy verification-needed-xenial |
verification-done-bionic verification-done-focal verification-done-groovy verification-needed verification-needed-xenial |
|
| 2021-01-04 16:05:29 |
Chad Smith |
tags |
verification-done-bionic verification-done-focal verification-done-groovy verification-needed verification-needed-xenial |
verification-done verification-done-bionic verification-done-focal verification-done-groovy verification-done-xenial |
|
| 2021-01-04 16:06:15 |
Chad Smith |
description |
[Impact]
The product names and product URLs of Ubuntu Advantage Extended Security Maintenance offerings have been rebranded prior to an official launch of the product ESM product in Ubuntu Xenial, Bionic and Focal. MOTD messages reference the old product name UA Infrastructure: Extended Security Maintenance as well as an invalid product URL https://ubuntu.com/esm.
Correct both the product name "UA Infra: ESM" and the apt URL message
See https://ubuntu.com/security/esm.
Because these text messages are translated using gettext, translations will need to be updated as well.
[Test Case]
* Install unreleased ubuntu-advantage-tools from a PPA
* Run: ua enable <yourToken> to activate UA apt repositories
* Check MOTD messaging related to UA Infra: ESM prior to upgrade to -proposed update-notifier via /usr/lib/update-notifier/apt-check --human-readable
* Upgrade update-notifier to -proposed
* Re-check MOTD messaging related to UA Infra: ESM to see expected messages (not on groovy as there are no esm repos)
#!/bin/bash
#
# SRU Verification update-notifier + ubuntu=advantage-tools
# Test procedure:
# - launch container Trusty, Xenial or Bionic
# - Install ubuntu-advantage-tools from https://launchpad.net/~ua-client/+archive/ubuntu/proposed which supports esm on trusty, xenial, bionic, and focal
# - Attach container to UA subscription (which activates the ESM APT repos
# - run apt_check --human-readable to assert ESM pkg counts ARE NOT reported
# - Upgrade update-notifier to -proposed
# - re-run apt_check --human-readable to assert ESM pkg counts ARE reported
set -e
UA_TOKEN=$1
if [ -z "$1" ]; then
echo "Usage: $0 <contractTOKEN>"
exit 1
fi
cat > test-un.yaml <<EOF
#cloud-config
ssh_import_id: [chad.smith]
package_update: true
package_upgrade: true
apt:
sources:
ua.proposed:
source: deb http://ppa.launchpad.net/ua-client/staging/ubuntu \$RELEASE main
keyid: 6E34E7116C0BC933
EOF
cat > setup_proposed.sh <<EOF
#/bin/bash
mirror=http://archive.ubuntu.com/ubuntu
echo deb \$mirror \$(lsb_release -sc)-proposed main | tee /etc/apt/sources.list.d/proposed.list
apt-get update -q
apt-get install -qy update-notifier-common
EOF
wait_for_boot() {
local vm=$1 release=$2
echo "--- Wait for cloud-init to finish"
sleep 5
lxc exec ${vm} -- cloud-init status --wait --long
}
for release in groovy; do
echo "--- BEGIN $release update-notifier testing"
vm=test-sru-$release
echo "--- Launch cloud-init with ppa:ua-client/proposed enabled"
lxc launch ubuntu-daily:${release} ${vm} -c user.user-data="$(cat test-un.yaml)"
wait_for_boot ${vm} ${release}
echo "--- Attach Ubuntu-Advantage, enabling services"
lxc exec ${vm} -- ua attach ${UA_TOKEN}
case "$release" in
xenial) downrev_pkg="libkrad0=1.13.2+dfsg-5";;
bionic) downrev_pkg="libkrad0=1.16-2build1";;
focal) downrev_pkg="hello=2.10-2ubuntu2";;
groovy) downrev_pkg="apport-retrace=2.20.11-0ubuntu50";;
esac
echo "-- Downgrading esm package to stable ubuntu release ver $downrev_pkg"
lxc exec ${vm} -- apt-get install $downrev_pkg --yes
lxc exec ${vm} -- dpkg-query --show update-notifier
lxc exec ${vm} -- /usr/lib/update-notifier/apt-check --human-readable
if [ "$release" = "groovy" ]; then
UPGRADE_MATCH="1 of these updates is a security update"
echo "Expect 1 upgradable package due to downgrade of non-esm pkg $downrev_pkg"
else
UPGRADE_MATCH="0 of these updates are security updates"
UPGRADE_COUNT=0
echo "--- Expect 0 upgradable packages for MOTD from apt_check before upgrade"
fi
lxc exec ${vm} -- /usr/lib/update-notifier/apt-check --human-readable
lxc exec ${vm} -- /usr/lib/update-notifier/apt-check --human-readable | grep "${UPGRADE_MATCH}" && echo "SUCCESS: found ${UPGRADE_COUNT} security updates pre-upgrade" || echo "FAILURE: did not find expected ${UPGRADE_COUNT} ESM security updates"
echo "--- Upgrade update-notifier from -proposed"
lxc file push setup_proposed.sh ${vm}/
lxc exec ${vm} -- bash /setup_proposed.sh | grep update-notifier
lxc exec ${vm} -- dpkg-query --show update-notifier
echo "--- Expect non-zero upgradable packages for MOTD from apt_check AFTER upgrade"
lxc exec ${vm} -- /usr/lib/update-notifier/apt-check --human-readable
lxc exec ${vm} -- /usr/lib/update-notifier/apt-check --human-readable | grep '1 of these updates is a security update' && echo "SUCCESS: found 1 ESM security updates pre-upgrade" || echo "FAILURE: did not find expected 1 ESM security updates"
done
[Where problems could occur]
* Low risk:
pep8 lint fixes plus MOTD text changes here. Minor logic changes in supplemental MOTD messaging for a product (ESM) that is not yet released and active in the wild on Xenial -> Focal. If messaging falls over the result is a lack of MOTD information about ESM package updates in motd, which is not yet released. If we can ensure we receive MOTD messaging about both ESM and non-ESM package updates without error, then risk of regression is minimal.
[Other Info]
[Original Description]
MOTD text should align with the messaging that is being surfaced by ubuntu-advantage-tools and apt command line hook messaging.
Current ESM product name is represented in MOTD as the following when logging into a VM:
### Current ESM-relatedMOTD messaging
# When ESM is disabled:
UA Infrastructure Extended Security Maintenance \(ESM\) is not enabled.
Enable UA Infrastructure ESM to receive 14 additional security updates.
# When ESM is enabled:
UA Infrastructure Extended Security Maintenance \(ESM\) is enabled.
14 of these updates are provided through UA Infrastructure ESM.
#### Expected new ESM messaging:
# When ESM is disabled:
UA Infra: Extended Security Maintenance \(ESM\) is not enabled.
Enable UA Infra: ESM to receive 14 additional security updates.
# When ESM is enabled:
UA Infra: Extended Security Maintenance \(ESM\) is enabled.
14 of these updates are provided through UA Infrastructure
UA Infra: Extended Security Maintenance \(ESM\) is not enabled.
Enable UA Infra: ESM to receive 14 additional security updates.
This request for product naming changes and standardization is also represented as a request against UA-Client tooling/apt-hooks/status messaging.
https://github.com/canonical/ubuntu-advantage-client/issues/1212#issuecomment-713735291
Additionally documentation URLs for esm are updated from ubuntu.com/esm -> ubuntu.com/security/esm. |
[Impact]
The product names and product URLs of Ubuntu Advantage Extended Security Maintenance offerings have been rebranded prior to an official launch of the product ESM product in Ubuntu Xenial, Bionic and Focal. MOTD messages reference the old product name UA Infrastructure: Extended Security Maintenance as well as an invalid product URL https://ubuntu.com/esm.
Correct both the product name "UA Infra: ESM" and the apt URL message
See https://ubuntu.com/security/esm.
Because these text messages are translated using gettext, translations will need to be updated as well.
[Test Case]
* Install unreleased ubuntu-advantage-tools from a PPA
* Run: ua enable <yourToken> to activate UA apt repositories
* Check MOTD messaging related to UA Infra: ESM prior to upgrade to -proposed update-notifier via /usr/lib/update-notifier/apt-check --human-readable
* Upgrade update-notifier to -proposed
* Re-check MOTD messaging related to UA Infra: ESM to see expected messages (not on groovy as there are no esm repos)
#!/bin/bash
#
# SRU Verification update-notifier + ubuntu=advantage-tools
# Test procedure:
# - launch container Trusty, Xenial or Bionic
# - Install ubuntu-advantage-tools from https://launchpad.net/~ua-client/+archive/ubuntu/proposed which supports esm on trusty, xenial, bionic, and focal
# - Attach container to UA subscription (which activates the ESM APT repos
# - run apt_check --human-readable to assert ESM pkg counts ARE NOT reported
# - Upgrade update-notifier to -proposed
# - re-run apt_check --human-readable to assert ESM pkg counts ARE reported
set -e
UA_TOKEN=$1
if [ -z "$1" ]; then
echo "Usage: $0 <contractTOKEN>"
exit 1
fi
cat > test-un.yaml <<EOF
#cloud-config
ssh_import_id: [chad.smith]
package_update: true
package_upgrade: true
apt:
sources:
ua.proposed:
source: deb http://ppa.launchpad.net/ua-client/staging/ubuntu \$RELEASE main
keyid: 6E34E7116C0BC933
EOF
cat > setup_proposed.sh <<EOF
#/bin/bash
mirror=http://archive.ubuntu.com/ubuntu
echo deb \$mirror \$(lsb_release -sc)-proposed main | tee /etc/apt/sources.list.d/proposed.list
apt-get update -q
apt-get install -qy update-notifier-common
EOF
wait_for_boot() {
local vm=$1 release=$2
echo "--- Wait for cloud-init to finish"
sleep 5
lxc exec ${vm} -- cloud-init status --wait --long
}
for release in xenial; do
echo "--- BEGIN $release update-notifier testing"
vm=test-sru-$release
echo "--- Launch cloud-init with ppa:ua-client/proposed enabled"
lxc launch ubuntu-daily:${release} ${vm} -c user.user-data="$(cat test-un.yaml)"
wait_for_boot ${vm} ${release}
echo "--- Attach Ubuntu-Advantage, enabling services"
lxc exec ${vm} -- ua attach ${UA_TOKEN}
case "$release" in
xenial)
UPGRADE_MATCH="0 updates are security updates";
downrev_pkg="libkrad0=1.13.2+dfsg-5";;
bionic)
UPGRADE_MATCH="1 update is a security update"
downrev_pkg="libkrad0=1.16-2build1";;
focal)
UPGRADE_MATCH="0 updates are security updates"
downrev_pkg="hello=2.10-2ubuntu2";;
groovy)
UPGRADE_MATCH="1 of these updates is a security update"
downrev_pkg="apport-retrace=2.20.11-0ubuntu50";;
esac
echo "-- Downgrading package to stable ubuntu release $downrev_pkg"
lxc exec ${vm} -- apt-get install $downrev_pkg --yes -q
lxc exec ${vm} -- dpkg-query --show update-notifier
if [ "$release" = "xenial" ]; then
# Xenial-updates have already included esm package updates.
# Drop the xenial-updates apt source so we can be sure we are seeing only
# available esm updates
lxc exec ${vm} -- sed -e "/xenial-updates/ s/^#*/#/" -i /etc/apt/sources.list
lxc exec ${vm} -- sed -e "/xenial-security/ s/^#*/#/" -i /etc/apt/sources.list
lxc exec ${vm} -- apt-get update
fi
MOTD=`lxc exec ${vm} -- /usr/lib/update-notifier/apt-check --human-readable`
echo ${MOTD}
POST_UPGRADE_MSG="UA Infra: Extended Security Maintenance (ESM) is enabled"
echo $MOTD | grep -q "${POST_UPGRADE_MSG}" && echo "FAILURE: found ${POST_UPGRADE_MSG}" || echo "SUCCESS: did not find ${POST_UPGRADE_MSG=}"
echo $MOTD | grep -q "${UPGRADE_MATCH}" && echo "SUCCESS: found ${UPGRADE_MATCH} security updates pre-upgrade" || echo "FAILURE: did not find expected ${UPGRADE_MATCH} ESM security updates"
echo "--- Upgrade update-notifier from -proposed"
lxc file push setup_proposed.sh ${vm}/
lxc exec ${vm} -- bash /setup_proposed.sh | grep update-notifier
lxc exec ${vm} -- dpkg-query --show update-notifier
MOTD=`lxc exec ${vm} -- /usr/lib/update-notifier/apt-check --human-readable`
echo $MOTD | grep -q "${POST_UPGRADE_MSG}" && echo "SUCCESS: found ${POST_UPGRADE_MSG}" || echo "FAILURE: did not find ${POST_UPGRADE_MSG=}"
echo "--- Expect non-zero upgradable packages for MOTD from apt_check AFTER upgrade"
lxc exec ${vm} -- /usr/lib/update-notifier/apt-check --human-readable
lxc exec ${vm} -- /usr/lib/update-notifier/apt-check --human-readable | grep '1 of these updates is a security update' && echo "SUCCESS: found 1 ESM security updates pre-upgrade" || echo "FAILURE: did not find expected 1 ESM security updates"
done
[Where problems could occur]
* Low risk:
pep8 lint fixes plus MOTD text changes here. Minor logic changes in supplemental MOTD messaging for a product (ESM) that is not yet released and active in the wild on Xenial -> Focal. If messaging falls over the result is a lack of MOTD information about ESM package updates in motd, which is not yet released. If we can ensure we receive MOTD messaging about both ESM and non-ESM package updates without error, then risk of regression is minimal.
[Other Info]
[Original Description]
MOTD text should align with the messaging that is being surfaced by ubuntu-advantage-tools and apt command line hook messaging.
Current ESM product name is represented in MOTD as the following when logging into a VM:
### Current ESM-relatedMOTD messaging
# When ESM is disabled:
UA Infrastructure Extended Security Maintenance \(ESM\) is not enabled.
Enable UA Infrastructure ESM to receive 14 additional security updates.
# When ESM is enabled:
UA Infrastructure Extended Security Maintenance \(ESM\) is enabled.
14 of these updates are provided through UA Infrastructure ESM.
#### Expected new ESM messaging:
# When ESM is disabled:
UA Infra: Extended Security Maintenance \(ESM\) is not enabled.
Enable UA Infra: ESM to receive 14 additional security updates.
# When ESM is enabled:
UA Infra: Extended Security Maintenance \(ESM\) is enabled.
14 of these updates are provided through UA Infrastructure
UA Infra: Extended Security Maintenance \(ESM\) is not enabled.
Enable UA Infra: ESM to receive 14 additional security updates.
This request for product naming changes and standardization is also represented as a request against UA-Client tooling/apt-hooks/status messaging.
https://github.com/canonical/ubuntu-advantage-client/issues/1212#issuecomment-713735291
Additionally documentation URLs for esm are updated from ubuntu.com/esm -> ubuntu.com/security/esm. |
|
| 2021-01-04 19:04:51 |
Launchpad Janitor |
update-notifier (Ubuntu Groovy): status |
Fix Committed |
Fix Released |
|
| 2021-01-04 19:04:59 |
Brian Murray |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
| 2021-01-05 19:13:32 |
Launchpad Janitor |
update-notifier (Ubuntu Focal): status |
Fix Committed |
Fix Released |
|
| 2021-01-05 19:22:48 |
Launchpad Janitor |
update-notifier (Ubuntu Xenial): status |
Fix Committed |
Fix Released |
|
| 2021-01-05 19:25:17 |
Launchpad Janitor |
update-notifier (Ubuntu Bionic): status |
Fix Committed |
Fix Released |
|
| 2022-09-22 16:48:02 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~lamoura/ubuntu/+source/update-notifier/+git/update-notifier/+merge/430317 |
|
| 2022-09-22 16:48:57 |
Launchpad Janitor |
merge proposal linked |
|
https://code.launchpad.net/~lamoura/ubuntu/+source/update-notifier/+git/update-notifier/+merge/430318 |
|
