Ubuntu
update-manager package

apport enabled after a distribution upgrade from Jaunty to Karmic

Bug #465619 reported by Brian Murray
24
This bug affects 4 people
Affects Status Importance Assigned to Milestone
apport (Ubuntu)
Invalid
Undecided
Unassigned
Karmic
Fix Released
High
Martin Pitt
Ubuntu karmic-updates
update-manager (Ubuntu)
Fix Released
High
Michael Vogt
Karmic
Fix Released
High
Unassigned
Ubuntu karmic-updates

Bug Description

Binary package hint: update-manager

After performing a distribution upgrade from Jaunty to Karmic on 20091030 I discovered that apport was enabled. I've attached the file '/var/log/dist-upgrade/main.log' which shows apport being enabled.

This is due to the fact that update-manager doesn't seem to check the value of EnableApport just whether or not it is in the config file.

From DistUpgrade/DistUpgradeController.py:

    def doDistUpgrade(self):
        # check if we want apport running during the upgrade
        if self.config.getWithDefault("Distro","EnableApport", False):
            self.enableApport()

Statement:
Users upgrading from Jaunty to the final version of Karmic will have apport enabled by default which is not what is intended.

TEST CASE:
1) Perform a distribution upgrade from Jaunty to Karmic with update-manager version 0.126.6
2) Observe enabled=1 in /etc/default/apport

1) Perform a distribution with update-manager version 0.126.9 from Jaunty to Karmic
2) Observe enabled=0 in /etc/default/apport

ProblemType: Bug
Architecture: amd64
Date: Fri Oct 30 14:38:15 2009
DistroRelease: Ubuntu 9.10
Package: update-manager 1:0.126.6
PackageArchitecture: all
ProcEnviron:
 LANG=en_US.UTF-8
 SHELL=/bin/bash
ProcVersionSignature: Ubuntu 2.6.31-14.48-generic
SourcePackage: update-manager
Uname: Linux 2.6.31-14-generic x86_64
XsessionErrors:
 (gnome-settings-daemon:1348): GLib-CRITICAL **: g_propagate_error: assertion `src != NULL' failed
 (gnome-settings-daemon:1348): GLib-CRITICAL **: g_propagate_error: assertion `src != NULL' failed
 (nautilus:1393): Eel-CRITICAL **: eel_preferences_get_boolean: assertion `preferences_is_initialized ()' failed
 (polkit-gnome-authentication-agent-1:1414): GLib-CRITICAL **: g_once_init_leave: assertion `initialization_value != 0' failed

See original description
Revision history for this message
Brian Murray (brian-murray) wrote :
description: updated
Brian Murray (brian-murray)
description: updated
description: updated
Changed in update-manager (Ubuntu Karmic):
status: New → Triaged
importance: Undecided → High
Revision history for this message
Brian Murray (brian-murray) wrote :

Something will also likely need to be done to have '/etc/default/apport' enabled set to 0 for the users who have already performed distribution upgrades.

Revision history for this message
Steve Langasek (vorlon) wrote :

The fix proposed here is acknowledged to be a workaround for a bug in the code; getWithDefault() doesn't interpret "EnableApport=no" as false, but as the text string 'no', and there are a number of points in the code where it's assumed that the opposite of 'yes' is False. However, none of these are as high-impact as the apport handling, since none of the others are set to 'no' by default in the config file.

There is also an additional cleanup step needed once the fixed update-manager is available, to go back and correct the /etc/default/apport file of any users that have had it mangled on upgrade. Brian points out that we should be able to reliably detect this case by finding the "release-upgrader version '0.126.6'" and "DEBUG enabling apport" lines in /var/log/dist-upgrade/main.log, so this can be cleaned up out-of-band after update-manager has been fixed, and we can take our time to make sure we get this right and avoid accidentally disabling apport for any users who have explicitly enabled it.

Revision history for this message
Brian Murray (brian-murray) wrote :

Or 0.1.126.5 as that is when it was supposed to be disabled.

Michael Vogt (mvo)
Changed in update-manager (Ubuntu Karmic):
milestone: none → karmic-updates
status: Triaged → In Progress
Revision history for this message
Michael Vogt (mvo) wrote :

Thanks for your bugreport.

I put a fix for the getWithDefault() into the main lp:update-manager code now that should fix the other cases that Steve mentions as well.

Changed in update-manager (Ubuntu):
status: New → Fix Committed
importance: Undecided → High
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package update-manager - 1:0.126.6.1

---------------
update-manager (1:0.126.6.1) karmic-updates; urgency=low

  * DistUpgrade/DistUpgrade.cfg:
    - really stop enabling apport during the upgrade (LP: #465619)

 -- Brian Murray <email address hidden> Fri, 30 Oct 2009 13:54:08 -0700

Changed in update-manager (Ubuntu Karmic):
status: In Progress → Fix Released
Martin Pitt (pitti)
Changed in update-manager (Ubuntu):
assignee: nobody → Michael Vogt (mvo)
Changed in apport (Ubuntu):
status: New → Invalid
Changed in apport (Ubuntu Karmic):
status: New → In Progress
importance: Undecided → High
assignee: nobody → Martin Pitt (pitti)
Revision history for this message
Martin Pitt (pitti) wrote :

Fix committed to karmic branch:
  http://bazaar.launchpad.net/%7Eubuntu-core-dev/ubuntu/karmic/apport/ubuntu/revision/1570

I tested this with a lot of possible situations and it's working fine for me.

Changed in apport (Ubuntu Karmic):
milestone: none → karmic-updates
Revision history for this message
Martin Pitt (pitti) wrote :

0.126.5 was also affected, so I extended the match to this:

http://bazaar.launchpad.net/%7Eubuntu-core-dev/ubuntu/karmic/apport/ubuntu/revision/1572

Uploaded to unapproved now, waiting for review.

Revision history for this message
Steve Langasek (vorlon) wrote : Please test proposed package

Accepted apport into karmic-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in apport (Ubuntu Karmic):
status: In Progress → Fix Committed
tags: added: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package update-manager - 1:0.130

---------------
update-manager (1:0.130) lucid; urgency=low

  * UpdateManager/UpdateManager.py:
    - set heading for the release-upgrader download window
  * DistUpgrade/DistUpgradeController.py:
    - force lts for lucid cdrom upgrades
  * AutoUpgradeTester/profile/:
    - fix missing BaseMetaPackages
  * AutoUpgradeTester/UpgradeTestBackendQemu.py:
    - fix AddRepo code
  * DistUpgrade/DistUpgradeConfigParser.py:
    - fix getWithDefault() to use the correct get{int,float,boolean}
      function based on the type of the default (LP: #465619)
      Thanks to Brian Murray for spotting this bug
  * DistUpgrade/DistUpgradeController.py:
    - fix typo (LP: #470011)
  * updated for karmic->lucid upgrades and hardy->lucid upgrades
  * UpdateManager/Core/utils.py::
    - fix url_downloadable() when a proxy needs to be used
      (LP: #446552)

 -- Michael Vogt <email address hidden> Tue, 03 Nov 2009 14:07:20 +0100

Changed in update-manager (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Michael Vogt (mvo) wrote :

I will do the apport sru-verification.

Revision history for this message
Michael Vogt (mvo) wrote :

I can confirm that that the apport fix works. I did a upgrade 0.126.6 and it enabled apport during the upgrade. After the upgrade apport was still enabled. When I then enabled karmic-proposed and installed apport it disabled apport again (as expected).

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package apport - 1.9.3-0ubuntu4.1

---------------
apport (1.9.3-0ubuntu4.1) karmic-proposed; urgency=low

  * Add debian/apport.preinst: Clean up after update-manager erroneously
    enabling Apport: Check /var/log/dist-upgrade/main.log for indications that
    this happened, and set Apport to disabled in /etc/default/apport then.
    (LP: #465619)
  * apport/report.py: Fix crash when ExecutablePath isn't part of a package.
    Fix cherrypicked from trunk r1629. (LP: #424965)

 -- Martin Pitt <email address hidden> Mon, 02 Nov 2009 10:06:11 +0100

Changed in apport (Ubuntu Karmic):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.