ubuntu-security-status should call pro-security-status as soon as it is available

Bug #1991533 reported by Renan Rodrigo
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
update-manager (Ubuntu)
Fix Released
Undecided
Unassigned
Focal
Fix Released
Medium
Brian Murray
Jammy
Fix Released
Medium
Brian Murray

Bug Description

Merge Proposals for
Focal: https://code.launchpad.net/~renanrodrigo/update-manager/focal-ss/+merge/430919
Jammy: https://code.launchpad.net/~renanrodrigo/update-manager/jammy-ss/+merge/430921

[Impact]
Once `pro security-status` is available as a command, then ubuntu-security-status should start calling it. This was specd out and agreed in https://docs.google.com/document/d/1eWaSXqk6Ih3H7tvJrjRJJjLmRZE0BJh--cKaaW4mQxM

The command will be available from ubuntu-advantage-tools >= 27.11, at the same time of the `pro` renaming.

This change needs to be SRUed to Focaland Jammy so users will see the most recent data and messaging, defined in the Pro Client's side.

Even if Pro is not available, no ESM-Apps information should be shown in ubuntu-security-status at all, unless the service is enabled. ESM-Apps will only be available and advertised to non-attached users on systems with the aforementioned version of ubuntu-advantage-tools.

[Test Case]
(Used for verification)
- On a Focal/Jammy machine:
- Install ubuntu-advantage-tools using the version in the -proposed pocket or the ua-client/stable PPA (not needed anymore, as u-a-t brought the functionality to -updates already)
- Install update-manager from the version in proposed
- Install any package from `universe`
- Make sure ubuntu-security-status has a warning, and then exactly the output of pro security-status
- Delete /usr/bin/pro
- Make sure ubuntu-security-status runs without any errors, showing its own content
- Grep for ESM-Apps (and variants) and see there is no reference to the service.

[Regression Potential]
If users have any custom script in /usr/bin/pro, then this would probably cause errors when the ubuntu-security-status detects it. However, if this is the case, a broader set of errors will be happening in the ubuntu-advantage-tools side anyway. There was a discussion about the Pro namespace in the most recent u-a-t SRU bug (https://bugs.launchpad.net/ubuntu/+source/ubuntu-advantage-tools/+bug/1989279), and there was a decision to rely on `pro` as a name.

[Discussion]
This is a change which was agreed on for the future, but some last-minute decisions from product management increased the priority of this SRU. Due to the release plan of ESM-Apps as beta being modified from the original thoughts, it would be really nice to have this land as soon as possible right after u-a-t 27.11.2 hits -updates.

description: updated
Changed in update-manager (Ubuntu):
status: New → Fix Committed
Jeremy Bícha (jbicha)
Changed in update-manager (Ubuntu Focal):
status: New → Triaged
Changed in update-manager (Ubuntu Jammy):
status: New → Triaged
description: updated
tags: added: rls-jj-incoming
Changed in update-manager (Ubuntu Focal):
assignee: nobody → Brian Murray (brian-murray)
Revision history for this message
Brian Murray (brian-murray) wrote :

update-manager (1:22.10.3) kinetic; urgency=medium

  [ Renan Rodrigo ]
  * ubuntu-security-status: Don't show ESM Apps information when the service
    is disabled, and prefer 'pro security-status' when it is available.

 -- Steve Langasek <email address hidden> Mon, 03 Oct 2022 08:37:28 -0700

Changed in update-manager (Ubuntu):
status: Fix Committed → Fix Released
Changed in update-manager (Ubuntu Focal):
status: Triaged → In Progress
Changed in update-manager (Ubuntu Jammy):
status: Triaged → In Progress
assignee: nobody → Brian Murray (brian-murray)
Changed in update-manager (Ubuntu Focal):
importance: Undecided → Medium
Changed in update-manager (Ubuntu Jammy):
importance: Undecided → Medium
Revision history for this message
Timo Aaltonen (tjaalton) wrote : Please test proposed package

Hello Renan, or anyone else affected,

Accepted update-manager into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/update-manager/1:22.04.10 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in update-manager (Ubuntu Jammy):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-jammy
Changed in update-manager (Ubuntu Focal):
status: In Progress → Fix Committed
tags: added: verification-needed-focal
Revision history for this message
Timo Aaltonen (tjaalton) wrote :

Hello Renan, or anyone else affected,

Accepted update-manager into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/update-manager/1:20.04.10.11 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

description: updated
Revision history for this message
Renan Rodrigo (renanrodrigo) wrote :

Tested and verified the fix works on Jammy and Focal.
The test steps are exactly as read in the description.
Results can be observed below

For Focal:
https://paste.ubuntu.com/p/vVzT7pDZ36/

For Jammy:
https://paste.ubuntu.com/p/4sxsd5jPH4/

I am marking this bug as verification-done.

tags: added: verification-done verification-done-focal verification-done-jammy
removed: verification-needed verification-needed-focal verification-needed-jammy
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package update-manager - 1:22.04.10

---------------
update-manager (1:22.04.10) jammy; urgency=medium

  [ Renan Rodrigo ]
  * ubuntu-security-status: Don't show ESM Apps information when the service
    is disabled, and prefer 'pro security-status' when it is available.
    (LP: #1991533)

 -- Brian Murray <email address hidden> Thu, 01 Dec 2022 10:43:15 -0800

Changed in update-manager (Ubuntu Jammy):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for update-manager has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package update-manager - 1:20.04.10.11

---------------
update-manager (1:20.04.10.11) focal; urgency=medium

  [ Renan Rodrigo ]
  * ubuntu-security-status: Don't show ESM Apps information when the service
    is disabled, and prefer 'pro security-status' when it is available.
    (LP: #1991533)

 -- Brian Murray <email address hidden> Thu, 01 Dec 2022 11:10:57 -0800

Changed in update-manager (Ubuntu Focal):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.