release-upgrade-motd can't update message via apt proxy
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
update-manager (Ubuntu) |
Fix Released
|
High
|
Unassigned | ||
Xenial |
Fix Released
|
Undecided
|
Unassigned | ||
Bionic |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
[Impact]
apt proxy settings are not applied to https urls, and thus the release-
[Test case]
Set acquire:
Do the same with acquire:
(Kind of a reverse check, since I don't have a proxy setup to test against. If there's an actual proxy and otherwise, no internet, it can be verified by setting the actual proxy and checking that it works with it).
[Regression potential]
The fix changes the API of init_proxy() in UpdateManager/
Apart from that, it also allows https proxies now, since we're doing https anyway, which means that a proxy setting ignored before now is not. The same applies to the the new proxy variables used - they were not used before, so things might fail that used to work - like you specify an invalid https proxy but don't actually need one. Low risk, though.
[Original bug report]
I have configured apt proxy in apt.conf.d and apt update and apt install can work correctly. However, when I logged in system everyday, in the login message, it says:
Failed to connect to https:/
After further investigation, I found the the issue is caused in package python3-
python3-
In the init_proxy function of the python script, it only set a http proxy by below code:
proxy_support = ProxyHandler(
after changing the line to add https proxy, it can work:
proxy_support = ProxyHandler(
Related branches
- Brian Murray: Approve
-
Diff: 140 lines (+68/-22)3 files modifiedUpdateManager/Core/utils.py (+18/-10)
debian/changelog (+7/-0)
tests/test_proxy.py (+43/-12)
affects: | diskimage-builder → update-manager (Ubuntu) |
tags: | added: bionic |
tags: | added: rls-bb-incoming |
Changed in update-manager (Ubuntu): | |
status: | New → Triaged |
importance: | Undecided → High |
tags: | added: regression-release |
Changed in update-manager (Ubuntu): | |
milestone: | none → ubuntu-18.04.1 |
tags: | added: id-5b02f3eecd6d6575c1cd9785 |
Changed in update-manager (Ubuntu Bionic): | |
status: | New → Triaged |
description: | updated |
description: | updated |
Changed in update-manager (Ubuntu Bionic): | |
status: | Triaged → In Progress |
I confirm this bug. The fix proposed in the original post fixes the issue.