Menus that fill themselves on QMenu::aboutToShow don't work
Bug #1664578 reported by
Albert Astals Cid
This bug affects 3 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
qtubuntu (Ubuntu) |
Fix Released
|
Undecided
|
Albert Astals Cid | ||
unity8 (Ubuntu) |
Fix Released
|
Undecided
|
Albert Astals Cid |
Bug Description
Our menu implementation doesn't trigger QMenu::aboutToShow so some menus in konsole and kate show up empty.
Related branches
lp://staging/~aacid/qmenumodel/aboutToShow
- Charles Kerr (community): Approve
-
Diff: 96 lines (+51/-2)3 files modifieddebian/changelog (+7/-0)
libqmenumodel/src/unitymenumodel.cpp (+42/-1)
libqmenumodel/src/unitymenumodel.h (+2/-1)
lp://staging/~aacid/qtubuntu/aboutToShow
- Lukáš Tinkl (community): Abstain
- Charles Kerr (community): Approve
- Unity8 CI Bot: Approve (continuous-integration)
-
Diff: 504 lines (+283/-23)6 files modifiedsrc/ubuntuappmenu/gmenumodelexporter.cpp (+111/-13)
src/ubuntuappmenu/gmenumodelexporter.h (+21/-4)
src/ubuntuappmenu/gmenumodelplatformmenu.cpp (+0/-4)
src/ubuntuappmenu/qtubuntuextraactionhandler.cpp (+107/-0)
src/ubuntuappmenu/qtubuntuextraactionhandler.h (+40/-0)
src/ubuntuappmenu/ubuntuappmenu.pro (+4/-2)
lp://staging/~aacid/unity8/aboutToShow
- Lukáš Tinkl (community): Approve
- Unity8 CI Bot: Approve (continuous-integration)
-
Diff: 318 lines (+134/-12)11 files modifieddebian/control (+1/-1)
qml/ApplicationMenus/MenuBar.qml (+3/-1)
qml/ApplicationMenus/MenuPopup.qml (+3/-1)
qml/Panel/Panel.qml (+7/-0)
qml/Panel/PanelMenu.qml (+1/-0)
qml/Panel/PanelMenuPage.qml (+1/-0)
tests/mocks/QMenuModel/unitymenumodel.cpp (+5/-0)
tests/mocks/QMenuModel/unitymenumodel.h (+2/-0)
tests/qmltests/ApplicationMenus/tst_MenuBar.qml (+43/-0)
tests/qmltests/ApplicationMenus/tst_MenuPopup.qml (+34/-9)
tests/qmltests/Panel/tst_Panel.qml (+34/-0)
Changed in qtubuntu (Ubuntu): | |
assignee: | nobody → Nick Dedekind (nick-dedekind) |
Changed in unity8 (Ubuntu): | |
assignee: | nobody → Nick Dedekind (nick-dedekind) |
Changed in unity8 (Ubuntu): | |
assignee: | Nick Dedekind (nick-dedekind) → Albert Astals Cid (aacid) |
Changed in qtubuntu (Ubuntu): | |
assignee: | Nick Dedekind (nick-dedekind) → Albert Astals Cid (aacid) |
description: | updated |
Changed in unity8 (Ubuntu): | |
status: | Confirmed → In Progress |
Changed in qtubuntu (Ubuntu): | |
status: | Confirmed → In Progress |
To post a comment you must log in.
Example application