Ubuntu
unity8 package

unity shell is crashing for apps without icon

Bug #1617348 reported by Renato Araujo Oliveira Filho
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Canonical System Image
Fix Released
High
Unassigned
ubuntu-app-launch (Ubuntu)
Fix Released
High
Unassigned
unity8 (Ubuntu)
Invalid
High
Unassigned

Bug Description

Trying to launch a app from terminal that does not contains a "Icon" etry on it desktop file causes the shell to crash.

How to test
===========

* Create a desktop entry without the icon entry (something like that):
[Desktop Entry]
Name=Sync Monitor
Comment=Ask for online account authentication if the token expires
Exec=/usr/lib/arm-linux-gnueabihf/sync-monitor/sync-monitor-helper %u
Terminal=false
Type=Application
Version=1.0
X-Ubuntu-Gettext-Domain=sync-monitor

* try to launch it from terminal or url launch:
/usr/lib/arm-linux-gnueabihf/sync-monitor/sync-monitor-helper --desktop-file-hint=/usr/share/applications/sync-monitor-helper.desktop

Expected
========

App appears

Current
=======

Shell crashes and go back to login screen.

Related branches

lp://staging/~ted/ubuntu-app-launch/relax-icon-rules
Marcus Tomlinson (community): Approve
unity-api-1-bot: Approve (continuous-integration)
Diff: 540 lines (+211/-121)
4 files modified
libubuntu-app-launch/application-info-desktop.cpp (+62/-29)
libubuntu-app-launch/application-info-desktop.h (+1/-1)
tests/CMakeLists.txt (+1/-0)
tests/application-info-desktop.cpp (+147/-91)
Daniel van Vugt (vanvugt)
Changed in unity8 (Ubuntu):
importance: Undecided → High
tags: added: unity8-desktop
Andrea Azzarone (azzar1)
Changed in unity8 (Ubuntu):
status: New → Triaged
Revision history for this message
Albert Astals Cid (aacid) wrote :

Seems to be a decision by ubuntu-app-launch

The constructor of Desktop throws an exception if no "Icon" entry is found in the desktop file (application-info-desktop.cpp line 230)

I agree it seems too much of an aggressive stance to bring the shell down for a missing Icon in a desktop file.

Changed in unity8 (Ubuntu):
status: Triaged → Incomplete
Changed in ubuntu-app-launch (Ubuntu):
status: New → Triaged
importance: Undecided → High
Jean-Baptiste Lallement (jibel)
Changed in canonical-devices-system-image:
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-app-launch - 0.9+16.10.20161003.1-0ubuntu1

---------------
ubuntu-app-launch (0.9+16.10.20161003.1-0ubuntu1) yakkety; urgency=medium

  * Set a base directory for icons that have a full path specified in
    their desktop file (LP: #1623636)
  * Don't throw an exception when a Desktop file fails to include an
    Icon key (LP: #1617348)
  * Switch from g_atexit to std::atexit to avoid deprecation warnings
  * Use the --id field for launching with libertine-launch and use it
    for setting up other X11 environments
  * Ensure we don't check the length of a nullptr array
  * Make sure we don't check snapd if we know it won't return useful
    results
  * Make use of the instance parameter consistent through all the
    backends (LP: #1626028)

 -- Ted Gould <email address hidden> Mon, 03 Oct 2016 23:55:25 +0000

Changed in ubuntu-app-launch (Ubuntu):
status: Triaged → Fix Released
Michael Zanetti (mzanetti)
Changed in unity8 (Ubuntu):
status: Incomplete → Invalid
Daniel van Vugt (vanvugt)
Changed in canonical-devices-system-image:
status: Fix Committed → Fix Released
importance: Undecided → High
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.