Ubuntu
unity8 package

review input field: send button issues with predictive OSK

Bug #1595910 reported by Michael Zanetti
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ubuntu-ui-toolkit (Ubuntu)
Fix Released
Undecided
Cris Dywan
unity8 (Ubuntu)
Fix Released
Medium
Michael Zanetti

Bug Description

Steps to reproduce:

* Make sure predictive OSK is enabled
* got an app in the store and start writing a review
* Just write one word, no space after it (so that it is underlined for text correction things)

=> actual:
The send button is disabled even though the text field holds a word

=> expected:
The send button should be enabled

Most likely the Send button is enabled/disabled based on inputField.text, while it should be inputField.displayText instead.

Related branches

lp://staging/~mzanetti/unity8/fix-send-button-enabled
Cris Dywan (community): Approve
Unity8 CI Bot: Approve (continuous-integration)
Andrea Cimitan (community): Approve
Michael Terry: Needs Information
Diff: 11 lines (+1/-1)
1 file modified
qml/Dash/Previews/PreviewRatingInput.qml (+1/-1)
lp://staging/~ubuntu-sdk-team/ubuntu-ui-toolkit/TextAreaDisplayTextPreEdit
ubuntu-sdk-build-bot: Approve (continuous-integration)
Zsombor Egri: Approve
Diff: 17 lines (+6/-1)
1 file modified
src/imports/Components/1.3/TextArea.qml (+6/-1)
lp://staging/~ci-train-bot/ubuntu-ui-toolkit/ubuntu-ui-toolkit-ubuntu-zesty-2315
lp://staging/~ci-train-bot/ubuntu-ui-toolkit/ubuntu-ui-toolkit-ubuntu-zesty-2315.1 (Merged)
Revision history for this message
Michael Zanetti (mzanetti) wrote :

The linked branch updates the dash to use displayText, still it doesn't work as TextArea in uitk seems to not handle that correctly either (at least it seems to differ from TextField's behavior)

no longer affects: ubuntu-ui-toolkit
Cris Dywan (kalikiana)
Changed in ubuntu-ui-toolkit (Ubuntu):
assignee: nobody → Christian Dywan (kalikiana)
Michał Sawicz (saviq)
Changed in unity8 (Ubuntu):
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
Cris Dywan (kalikiana) wrote :

You need to be using inputMethodComposing: TextArea.displayText has different semantics - it's the text with no formatting, but not aware of the input method.

Cris Dywan (kalikiana)
Changed in ubuntu-ui-toolkit (Ubuntu):
status: New → Invalid
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-ui-toolkit - 1.3.2151+17.04.20161223

---------------
ubuntu-ui-toolkit (1.3.2151+17.04.20161223) zesty; urgency=medium

  [ Zsombor Egri ]
  * Enable mouse, touchpad and keyboard detection in UITK. Fixes LP: #1536669
  * Colors revisited.
  * Qt5.7 related fix for theming - by Glen Whitney.

  [ Timo Jyrinki ]
  * parent = Q_NULLPTR instead of 0. Fixes LP: #1642617
  * More blank lines. Fixes LP: #1642622
  * Drop tst_pickerpanel.11.qml (deprecated).

  [ Christian Dywan ]
  * Include OSK input in TextArea.displayText. Fixes LP: #1595910

  * Drop questionable color tests from tst_textarea.11.qml. Fixes LP: #1624342

  [ Lukáš Tinkl ]
  * Fix slider progress rect with RTL languages.

 -- Marco Trevisan (Treviño) <mail@3v1n0.net> Fri, 23 Dec 2016 14:52:55 +0000

Changed in ubuntu-ui-toolkit (Ubuntu):
status: Invalid → Fix Released
Michał Sawicz (saviq)
Changed in unity8 (Ubuntu):
status: Triaged → In Progress
assignee: nobody → Michael Zanetti (mzanetti)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity8 - 8.15+17.04.20170110.4-0ubuntu1

---------------
unity8 (8.15+17.04.20170110.4-0ubuntu1) zesty; urgency=medium

  [ Albert Astals Cid ]
  * Give focus to one of the buttons of the dialog
  * tst_WindowResizeArea: Use default values for mouseFlick speed and
    iterations (LP: #1651580)
  * Require Qt 5.6 & misc fixes

  [ Daniel van Vugt ]
  * Deprecate usage of Mir's input resampling, instead opting for: (LP:
    #1497105, #1591328)

  [ Josh Arenson ]
  * Allow the scopes list to automatically scroll when a scope is being
    dragged past the bounds of the screen. (LP: #1575319)

  [ Lukáš Tinkl ]
  * Fix touch window controls being unreachable when the overlay is
    being displayed (LP: #1648167)
  * Fixup paths for window state storage in snappy environment
  * Add Unity.Platform mock for our tests (LP: #1655336)

  [ Michael Zanetti ]
  * PreviewRatingInput: Use displayText instead of text to
    enable/disable the Send button (LP: #1595910)
  * Add a D-Bus interface to control some debug facilities on the fly
  * some launcher workarounds for the snapping

  [ Michał Sawicz ]
  * Nuke leftover Platform in IndicatorsManager

  [ Nick Dedekind ]
  * Added registry for application menus

  [ Michael Terry, Nick Dedekind ]
  * Run the qmluitests.sh autopkg test against the installed package.

  [ Michał Sawicz, Nick Dedekind ]
  * Application menus

  [ Rodney Dawes ]
  * Remove the payments widget and dependency on libpay as no longer
    needed.

 -- Michał Sawicz <email address hidden> Tue, 10 Jan 2017 14:48:42 +0000

Changed in unity8 (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.