[Arale] News aggregator scope has a white scope background in cards

I can reproduce this in vivid too

Is this arale only? I can't reproduce it in a krillin+rtm (nor in the nexus+vivid since doesn't have the news scope)

error snapped

So we have https://code.launchpad.net/~cimi/unity8/fix-1393008/+merge/246138 on vivid (not on rtm-09) which adds the possibility of having backgrounds on some more card types than before, my guess is that the news scope used to specify a white background and we just ignored it and now we don't anymore.

If i'm right this has to be fixed on the scope level and not in unity8

Chris is it you doing the news scope? Do you know who if not?

ssweeny works on the news scope, and there's no background specified in the code

Actually, having a look at https://code.launchpad.net/~cimi/unity8/fix-1393008/+merge/246138 i can see that

  var hasBackground = (hasSummary || !isHorizontal) && (template["card-background"] || components["background"] || artAndSummary);
should be something more like
  var hasBackground = (!isHorizontal && (template["card-background"] || components["background"] || artAndSummary)) || (hasSummary && (template["card-background"] || components["background"]))

Otherwise we're adding a background to all cards with artAndSummary which i'd say is not what https://bugs.launchpad.net/developer-ubuntu-com/+bug/1393008 was about

Note that this should not affect rtm branch.

This bug was fixed in the package unity8 - 8.02+15.04.20150205-0ubuntu1

---------------
unity8 (8.02+15.04.20150205-0ubuntu1) vivid; urgency=medium

  [ Andrea Cimitan ]
  * Fix continue button in wifi wizard page, adds qml-module-
    qtsysteminfo as unity8 dep (LP: #1363400)
  * Background needs to be specified to be visible in horizontal cards
    (LP: #1411748)

  [ CI Train Bot ]
  * Resync trunk

  [ Michał Sawicz ]
  * Add workaround for gcc ICE.

  [ Albert Astals ]
  * Implement proper updateRanges for horizontal items (i.e. Carousel,
    Horizontal List)

  [ Michael Terry ]
  * Don't accept multiple "Finish" clicks during the last step of the
    wizard

  [ Daniel d'Andrada ]
  * Unify all liblightdm mocks
  * Ensure the greeter password field is not covered by the keyboard
  * Don't show() the lockscreen if it's already being shown
 -- Ubuntu daily release <email address hidden> Thu, 05 Feb 2015 10:30:13 +0000

this bug was only in vivid, does it need to go to rtm?

If we backport the fix for bug #1393008, we'll need this as well, as that's where the regression came.

Importance of this can be reduced since it's not actually affecting RTM without the fix for the other bug.

fixed in vivid

This bug was fixed in the package unity8 - 8.02+15.04.20150217~rtm-0ubuntu1

---------------
unity8 (8.02+15.04.20150217~rtm-0ubuntu1) 14.09; urgency=medium

  [ Albert astals ]
  * Preserve the aspect ratio for the card attribute images

  [ Andrea Cimitan ]
  * support background on horizontal cards with summary (LP: #1393008)
  * Background needs to be specified to be visible in horizontal cards
  (LP: #1411748)

  [ Daniel d'Andrada ]
  * Don't show() the lockscreen if it's already being shown

  [ Joshua Arenson ]
  * Create a PhysicalKeyMapper to handle all physical/hardware keys

  [ Michał Sawicz ]
  * Create a PhysicalKeyMapper to handle all physical/hardware keys

  [ Mirco Müller ]
  * Allow swipe-to-dismiss for contracted snap-decision notifications,
    interactive notifications and ephemeral notifications. (LP:
    #1355422, #1334855)
 -- CI Train Bot <email address hidden> Tue, 17 Feb 2015 10:47:19 +0000