Launcher: Icon Backlight Mode "Edge Illumination Toggles" broken (regression)

I've been building various versions and installing them and have found that http://bazaar.launchpad.net/~unity-team/unity/trunk/revision/3047 is the culprit.

I'll look to see what could possibly be the problem here.

Wow, after looking at this some more, the icon edge is illuminated, but it is so very, very subtle - very different than before. The way I was able to tell is to select the edge illumination in CCSM and then close an application (such as Firefox) and you will notice the ever so light edge illumination disappear. I'm not really sure if this is by design or an oversight.

Should probably ask John Lea for guidance.

Christopher Townsend, great you found the faulty commit introducing this. I will update my wrong accusation ;)

If you look at the commit - it seems all textures are commented out.

I am sure it is a bug, I'll ask Trevinho...

Christopher Townsend, I talked to Trevinho, he told me:
"these were commented in a branch still in WIP that was pushed... You can fix them, until I don't change that again"

So I'll do that (if you don't mind) and propose a MP with a fix soon, or do you want to do that ?

@MC Return,

Sure, go ahead if you'd like. Thanks!

@MC Return,

Did you decide not to go forward with this for now? Just wondering if I should go ahead and propose the MP.

Thanks!

Christopher Townsend, yes, please go forward - no problem from my side.
My latest understanding was that Trevinho would look at it himself, I forgot to post this info here,
so maybe you should get in touch with him on IRC to prevent double-fixing the same bug.

@MC Return,

Thanks, I'll check with Trevinho.

I re-enabled the commented out textures and texture loading and the edge illumination still does not show up. I'm wondering if the new .png's are different and don't handle the edge illumination. I will have to check around to see what is going on here.

Christopher, you nailed it -- the new PNGs are the culprit here. See the comments by Marco and myself in this merge proposal: https://code.launchpad.net/~3v1n0/unity/new-launcher-assets/+merge/135522 (tl;dr: border opacity is too low)

We need to ask design to fix the PNGs so they actually match their mockup.

I've let this sit too long. Sent John Lea an email today asking if this is by design, an oversite, or something else.

Hi all, please confirm that this is fixed by the change introduced in bug #1156698.

I don't see any change with respect to edge illumination with the fixes introduced from bug #1156698.

I also tried the fix from bug #1157303 with no change in the edge illumination.

I've looked more closely at the code for this and it is definitely not a matter of uncommenting the squircle textures and waiting on new png's. As a matter of fact, the squircle textures don't seem to be needed any more.

Instead, I made a test branch and fiddled around with this and I think we need to add some logic in IconRender::RenderIcon to handle adding a glow in the Edge Illumination cases. I'll continue working on this and then pass this by design and Marco.

I've linked a branch in this bug that addresses this issue. However, I need to consult with design because I made a couple of assumptions of what the edge illumination is supposed to look like. I'll get this cleared up before submitting an MP.

I'm also attaching what the Launcher looks like with the change in the linked branch with Edge Illumination Toggles enabled.

Fix committed into lp:unity at revision None, scheduled for release in unity, milestone backlog

This bug was fixed in the package unity - 6.12.0daily13.03.25.1-0ubuntu1

---------------
unity (6.12.0daily13.03.25.1-0ubuntu1) raring; urgency=low

  [ Martin Pitt ]
  * Add logind support (ConsoleKit and UPower suspend/resume are being
    deprecated) (LP: #1155021)

  [ Chris Townsend ]
  * Urgent apps need higher glow intensity (LP: #1157866)
  * Launcher: Icon Backlight Mode "Edge Illumination Toggles" broken
    (regression) (LP: #1103742)

  [ Paolo Rotolo ]
  * Shutdown dialog should have correct punctuation (LP: #1157927)

  [ Andrea Azzarone ]
  * Launcher tooltips keeps hanging on Desktop (LP: #1158378)
  * Launcher tooltips don't disappear when dash is open (LP: #1158021)
  * Some tooltip AP tests fail (LP: #1158357)

  [ Didier Roche ]
  * Unity/Libunity unit tests broken by latest glib (LP: #1159677)

  [ Ubuntu daily release ]
  * Automatic snapshot from revision 3252
 -- Ubuntu daily release <email address hidden> Mon, 25 Mar 2013 13:10:17 +0000