Multiple files rebuilt on each run of make
Bug #1060887 reported by
Sam Spilsbury
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Unity |
Confirmed
|
Medium
|
Sam Spilsbury | ||
unity (Ubuntu) |
Confirmed
|
Undecided
|
Unassigned |
Bug Description
[ 97%] Copying and modifying sources under test.
[ 98%] Building CXX object tests/test-
[ 98%] Building CXX object tests/test-
[ 98%] Building CXX object tests/test-
[ 98%] Building CXX object tests/test-
Linking CXX executable test-gestures
It should be possible to have these built only once.
Related branches
lp://staging/~smspillaz/unity/unity.gesture_tests_no_sed
On hold
for merging
into
lp://staging/unity
- Daniel d'Andrada (community): Approve
- Tim Penhey: Pending requested
- Unity Team: Pending requested
-
Diff: 6804 lines (+3279/-1598)62 files modifiedCMakeLists.txt (+1/-0)
gestures/CMakeLists.txt (+59/-0)
gestures/GesturalWindowSwitcher.cpp (+53/-51)
gestures/GesturalWindowSwitcher.h (+40/-6)
gestures/UnityGestureBroker.cpp (+41/-42)
gestures/UnityGestureBroker.h (+35/-6)
gestures/WindowGestureTarget.cpp (+68/-70)
gestures/WindowGestureTarget.h (+103/-10)
launcher/StandaloneSwitcher.cpp (+42/-30)
launcher/SwitcherController.cpp (+159/-44)
launcher/SwitcherController.h (+119/-16)
launcher/SwitcherView.cpp (+205/-37)
launcher/SwitcherView.h (+132/-34)
plugins/unityshell/CMakeLists.txt (+7/-4)
plugins/unityshell/src/unity-switcher-accessible.cpp (+12/-11)
plugins/unityshell/src/unitya11y.cpp (+1/-1)
plugins/unityshell/src/unityshell.cpp (+115/-8)
plugins/unityshell/src/unityshell.h (+5/-1)
tests/CMakeLists.txt (+1/-0)
tests/MockSwitcherController.h (+62/-0)
tests/MockSwitcherController.h.moved (+64/-0)
tests/MockSwitcherView.h (+56/-0)
tests/MockSwitcherView.h.moved (+56/-0)
tests/MockWindowManager.h (+4/-0)
tests/StubSwitcherController.h (+155/-0)
tests/StubSwitcherController.h.moved (+157/-0)
tests/test-gestures/CMakeLists.txt (+10/-64)
tests/test-gestures/FakeGestureEvent.h (+6/-0)
tests/test-gestures/GesturalWindowSwitcherMock.h (+13/-6)
tests/test-gestures/MockGestureManipulatedWindow.h (+57/-0)
tests/test-gestures/MockGestureTarget.h (+15/-0)
tests/test-gestures/MockMousePointer.h (+17/-0)
tests/test-gestures/NuxMock.h (+0/-27)
tests/test-gestures/PluginAdapterMock.cpp (+0/-33)
tests/test-gestures/PluginAdapterMock.h (+0/-38)
tests/test-gestures/SwitcherControllerMock.h (+0/-97)
tests/test-gestures/UnityGestureTargetMock.h (+0/-15)
tests/test-gestures/WindowGestureTargetMock.h (+16/-9)
tests/test-gestures/X11_mock.cpp (+0/-40)
tests/test-gestures/X11_mock.h (+0/-37)
tests/test-gestures/compiz_mock/core/core.h (+0/-29)
tests/test-gestures/compiz_mock/core/screen.h (+0/-77)
tests/test-gestures/compiz_mock/core/timer.h (+0/-79)
tests/test-gestures/compiz_mock/core/window.h (+0/-79)
tests/test-gestures/sed_script_broker (+0/-12)
tests/test-gestures/sed_script_gesture (+0/-18)
tests/test-gestures/sed_script_switcher (+0/-25)
tests/test-gestures/test_gestural_window_switcher.cpp (+291/-177)
tests/test-gestures/test_gesture_broker.cpp (+180/-64)
tests/test-gestures/test_gestures_main.cpp (+9/-7)
tests/test-gestures/test_window_gesture_target.cpp (+194/-86)
tests/test-gestures/ubus-server-mock.cpp (+0/-32)
tests/test-gestures/ubus-server-mock.h (+0/-35)
tests/test-gestures/unityshell_mock.h (+0/-68)
tests/test_abstract_interface_generator.cpp (+175/-0)
tests/test_switcher_controller.cpp (+38/-69)
unity-shared/AbstractInterfaceGenerator.h (+119/-0)
unity-shared/CMakeLists.txt (+6/-4)
unity-shared/CompizGestureManipulatedWindow.cpp (+137/-0)
unity-shared/CompizGestureManipulatedWindow.h (+66/-0)
unity-shared/CompizX11MousePointer.cpp (+123/-0)
unity-shared/CompizX11MousePointer.h (+55/-0)
lp://staging/~smspillaz/unity/switcher_view_interface
Rejected
for merging
into
lp://staging/unity
- Sam Spilsbury (community): Disapprove
- Brandon Schaefer (community): Needs Fixing
-
Diff: 1466 lines (+733/-139)14 files modifiedlauncher/StandaloneSwitcher.cpp (+13/-13)
launcher/SwitcherController.cpp (+25/-18)
launcher/SwitcherController.h (+6/-4)
launcher/SwitcherView.cpp (+407/-32)
launcher/SwitcherView.h (+221/-41)
plugins/unityshell/src/GesturalWindowSwitcher.cpp (+9/-9)
plugins/unityshell/src/unity-switcher-accessible.cpp (+11/-11)
plugins/unityshell/src/unitya11y.cpp (+1/-1)
plugins/unityshell/src/unityshell.cpp (+1/-1)
tests/MockSwitcherController.h (+1/-1)
tests/StubSwitcherController.h (+3/-3)
tests/test-gestures/SwitcherControllerMock.h (+32/-3)
tests/test-gestures/sed_script_switcher (+2/-1)
tests/test-gestures/test_gestural_window_switcher.cpp (+1/-1)
lp://staging/~smspillaz/unity/mock_switcher_view
Rejected
for merging
into
lp://staging/unity
- Sam Spilsbury (community): Disapprove
- Unity Team: Pending requested
-
Diff: 184 lines (+103/-4)5 files modifiedlauncher/SwitcherController.cpp (+8/-2)
launcher/SwitcherView.h (+1/-1)
shortcuts/ShortcutController.cpp (+8/-1)
tests/MockSwitcherView.h (+72/-0)
tests/test_switcher_controller.cpp (+14/-0)
Changed in unity: | |
status: | New → Confirmed |
importance: | Undecided → Medium |
Changed in unity (Ubuntu): | |
status: | New → Confirmed |
To post a comment you must log in.
I've been working on this for a while and have a solution, but I've been waiting on the PS team for feedback on how to split up my work for review.