Removed department stays in the shell
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| unity-scopes-shell (Ubuntu) |
Confirmed
|
High
|
Paweł Stołowski | ||
Bug Description
It's seems like the plugin doesn't notice when one of the departments disappears (is no longer returned by the scope) and doesn't notify shell about it, so that department is still displayed.
This is visible with the following branch of click scope: https:/
The case is as follows - consider we're always in the root of all departments in the dash.
1) scope responds with A and B sub-departments of "All departments"; A and B are shown when you open the departments menu.
2) scope content is refreshed somehow (e.g. you redo a search), and now it responds with A only.
Result: both A and B are still shown.
Expected result: only A is shown.
Steps to reproduce with the above branch of click scope:
1) Go to Ubuntu Store and install an app from a department, that was previously not shown in Apps.
2) After installation completes, go back to Apps - search results are refreshed (new app appears), and new department appears in the departments menu.
3) Uninstall that app: search results are refreshed, but the department that is now empty doesn't disappear (you can verify with scopes-cli that it's not returned anymore by the scope); after reboot however the department is not shown anymore
Related branches
- Marcus Tomlinson (community): Approve
- PS Jenkins bot (community): Needs Fixing (continuous-integration)
-
Diff: 355 lines (+243/-2)9 files modifiedsrc/Unity/scope.cpp (+8/-0)
src/Unity/scope.h (+1/-1)
tests/data/CMakeLists.txt (+1/-0)
tests/data/mock-scope-departments-flipflop/CMakeLists.txt (+16/-0)
tests/data/mock-scope-departments-flipflop/mock-scope-departments-flipflop.cpp (+144/-0)
tests/data/mock-scope-departments-flipflop/mock-scope-departments-flipflop.ini.in (+8/-0)
tests/departmentstest.cpp (+48/-1)
tests/test-utils.cpp (+14/-0)
tests/test-utils.h (+3/-0)
| tags: | added: rtm14 |
| Changed in unity-scopes-shell: | |
| assignee: | nobody → Pete Woods (pete-woods) |
| Changed in unity-scopes-shell: | |
| importance: | Undecided → High |
| Changed in unity-scopes-shell: | |
| assignee: | Pete Woods (pete-woods) → Pawel Stolowski (stolowski) |
| Changed in unity-scopes-shell: | |
| status: | New → In Progress |
| Changed in unity-scopes-shell (Ubuntu): | |
| assignee: | nobody → Pawel Stolowski (stolowski) |
| importance: | Undecided → High |
| status: | New → In Progress |
| no longer affects: | unity-scopes-shell |
| tags: | added: touch-2014-10-09 |
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in unity-scopes-shell (Ubuntu): | |
| status: | In Progress → Fix Released |
| Changed in unity-scopes-shell (Ubuntu): | |
| status: | Fix Released → Confirmed |
| Pete Woods (pete-woods) wrote | #2 |
This bug was fixed in the package unity-scopes-shell - 0.5.4+14.
---------------
unity-scopes-shell (0.5.4+
[ Pete Woods ]
* Remove missing departments (LP: #1354362)
[ Pawel Stolowski ]
* Remove missing departments (LP: #1354362)
* Iterate over temprary dash pages of every scope to find matching
scope when dbus signal for results invalidation was received. This
is only done if there was no match among favorite scopes. (LP:
#1365544)
* Fix signature of the deleteLater slot when scheduling scope for
removal after un-favoriting.
* Send build number, release name and package versions of unity8,
shell plugin and scopes api with user-agent hint in SearchMetadata
and PreviewMetadata. (LP: #1372834)
[ Marcus Tomlinson ]
* Handle "scopes" scope invalidation by re-populating the overview
scope. (LP: #1375718)
-- Ubuntu daily release <email address hidden> Thu, 02 Oct 2014 07:18:26 +0000