Push method for filters should be updated
Bug #1566952 reported by
Paweł Stołowski
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| unity-scopes-api (Ubuntu) |
In Progress
|
Medium
|
Paweł Stołowski | ||
Bug Description
The push(filters, filterState) method should be marked deprecated. The doc for this method should be updated to say that sending modified filterState back to the UI has no effect.
A new overloaded push method that only takes filters should be added.
Related branches
lp://staging/~stolowski/unity-scopes-api/update-push-filters
- PS Jenkins bot (community): Approve (continuous-integration)
- Marcus Tomlinson (community): Approve
- unity-api-1-bot: Needs Fixing (continuous-integration)
-
Diff: 503 lines (+105/-75)18 files modifiedRELEASE_NOTES.md (+5/-0)
STRUCTS (+2/-3)
debian/VERSION (+1/-1)
debian/changelog (+8/-0)
include/unity/scopes/SearchListenerBase.h (+9/-0)
include/unity/scopes/SearchReply.h (+8/-1)
include/unity/scopes/internal/SearchReplyImpl.h (+2/-1)
include/unity/scopes/testing/MockSearchReply.h (+1/-0)
include/unity/scopes/utility/internal/BufferedSearchReplyImpl.h (+1/-0)
src/scopes/SearchListenerBase.cpp (+5/-0)
src/scopes/internal/ResultReplyObject.cpp (+5/-10)
src/scopes/internal/SearchReplyImpl.cpp (+7/-14)
src/scopes/testing/InProcessBenchmark.cpp (+5/-0)
src/scopes/utility/internal/BufferedSearchReplyImpl.cpp (+5/-0)
test/gtest/scopes/Filters/Filters_test.cpp (+21/-10)
test/gtest/scopes/Filters/TestScope.h (+19/-2)
test/gtest/scopes/ResultCache/ResultCache_test.cpp (+1/-32)
test/gtest/scopes/ResultCache/no_filter_state_cache (+0/-1)
| Changed in unity-scopes-api (Ubuntu): | |
| status: | New → Confirmed |
| description: | updated |
| Changed in unity-scopes-api (Ubuntu): | |
| assignee: | nobody → Pawel Stolowski (stolowski) |
| importance: | Undecided → Medium |
| status: | Confirmed → In Progress |
To post a comment you must log in.
