Ubuntu
unity-scopes-api package

expandable widget cannot collapse widgets to the number defined by "collapsed-widgets"

Bug #1467886 reported by XiaoGuo, Liu
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
unity-scopes-api (Ubuntu)
In Progress
Medium
Paweł Stołowski
unity-scopes-shell (Ubuntu)
Invalid
Undecided
Unassigned
unity8 (Ubuntu)
Invalid
Undecided
Unassigned

Bug Description

https://developer.ubuntu.com/api/scopes/cpp/sdk-15.04/previewwidgets/

I tried to used the example code shown in the above link:

PreviewWidget expandable("exp", "expandable");
expandable.add_attribute_value("title", Variant("This is an expandable widget"));
expandable.add_attribute_value("collapsed-widgets", Variant(0));
PreviewWidget w1("w1", "text");
w1.add_attribute_value("title", Variant("Subwidget 1"));
w1.add_attribute_value("text", Variant("A text"));
PreviewWidget w2("w2", "text");
w2.add_attribute_value("title", Variant("Subwidget 2"));
w2.add_attribute_value("text", Variant("A text"));
expandable.add_widget(w1);
expandable.add_widget(w2);

regardless of whatever number is defined in "collapsed-widgets", it always shows all of the widgets there.

Thanks & best regards,
XiaoGuo

See original description

Related branches

lp://staging/~stolowski/unity-scopes-api/fix-expandable-widget-doc
PS Jenkins bot (community): Approve (continuous-integration)
Albert Astals Cid (community): Approve
unity-api-1-bot: Needs Fixing (continuous-integration)
Unity Team: Pending requested
Diff: 36 lines (+9/-2)
1 file modified
src/scopes/PreviewWidget.cpp (+9/-2)
Revision history for this message
XiaoGuo, Liu (liu-xiao-guo) wrote :
description: updated
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in unity-scopes-api (Ubuntu):
status: New → Confirmed
Paweł Stołowski (stolowski)
Changed in unity-scopes-shell (Ubuntu):
status: New → Invalid
Revision history for this message
Albert Astals Cid (aacid) wrote :

I think the problem is that the documentation doesn't match what the code does.

The internal documentation we have in the code says

    This widget shows a list of widgets defined in widgetData["widgets"]
    Those widgets can be collapsed or uncollapsed. When uncollapsed
    all the widgets are shown, when collapsed only the first
    widgetData["collapsed-widgets"] are shown. It has a title that comes
    in via widgetData["title"]. This widget expands all child widgets
    when initialized by specifying widgetData["expanded"] == true.
    It's in unexpanded mode by default.

There's nothing about 0 being a magic number and also collapsed-widgets is the number of widgets that will still be shown when the widget is collapsed.

I think it's best to update the documentation to match the code since there's a few scopes using the widget already.

Paweł Stołowski (stolowski)
Changed in unity-scopes-api (Ubuntu):
importance: Undecided → Medium
assignee: nobody → Pawel Stolowski (stolowski)
Changed in unity8 (Ubuntu):
status: New → Invalid
Paweł Stołowski (stolowski)
Changed in unity-scopes-api (Ubuntu):
status: Confirmed → In Progress
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.