Ubuntu
unity-notifications package

image_path and image_data hints are not supported

Bug #1194629 reported by Bill Filler
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
unity-notifications
Confirmed
Undecided
Unassigned
unity-notifications (Ubuntu)
Triaged
Low
Unassigned

Bug Description

build saucy-24
Galaxy Nexus

This is a regression, guessing when we moved away from notify-osd. When incoming call is received on phone, the notification does not show any avatar, only text and accept/decline buttons. It used to show either a default avatar or the actual avatar of the contact if available.

Note that incoming text messages do show avatars still, just not phone calls.

Related branches

lp://staging/~macslow/phone-app/fix-1194629
Gustavo Pichorim Boiko (community): Approve
PS Jenkins bot: Approve (continuous-integration)
Diff: 15 lines (+1/-4)
1 file modified
approver/phoneappapprover.cpp (+1/-4)
Bill Filler (bfiller)
Changed in touch-preview-images:
assignee: nobody → Michał Sawicz (saviq)
Michał Sawicz (saviq)
Changed in touch-preview-images:
assignee: Michał Sawicz (saviq) → Mirco Müller (macslow)
importance: Undecided → High
Revision history for this message
Mirco Müller (macslow) wrote :

I just verified with the examples/sd-example-incoming-call.py from lp:unity-notifications (you need to "sudo apt-get install python-notify" too) on the GalaxyNexus (using: build saucy-24), that notifications are correctly rendered, if the right parameters were passed. I'm now looking into the phone-app to see what arguments it passes to the notification.

Changed in touch-preview-images:
status: New → Confirmed
Revision history for this message
Mirco Müller (macslow) wrote :

Because the notification-backend does not yet support the hints "image_path" or "image_data", the current method phone-app uses to pass the avatar-image fails. The attached patch is a fix for this.

Changed in touch-preview-images:
status: Confirmed → In Progress
Michał Sawicz (saviq)
summary: - incoming call notifications missing avatar
+ image_path and image_data hints are not supported
Changed in unity-notifications:
status: New → Confirmed
Matthew Paul Thomas (mpt)
affects: touch-preview-images → unity-notifications (Ubuntu)
tags: added: touch-preview-images
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags: added: patch
Mirco Müller (macslow)
Changed in unity-notifications (Ubuntu):
status: In Progress → Triaged
importance: High → Low
Lukáš Tinkl (lukas-kde)
Changed in unity-notifications (Ubuntu):
assignee: Mirco Müller (macslow) → nobody
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Patches

Remote bug watches

Bug watches keep track of this bug in other bug trackers.