unity-lens-video could use libgnomedesktop to do thumbnailing

Bug #1027317 reported by Michael Blennerhassett
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Unity Videos Lens
New
Undecided
Unassigned
unity-lens-video (Ubuntu)
Confirmed
Undecided
Unassigned

Bug Description

Nautilus uses libgnomedesktop3 to do its thumbnailing. As there is a python binding (gir1.2-gnomedesktop-3.0), the lens should use that, rather than rolling its own thumbnails.

The attached patch uses multiprocessing.pool to queue all the files that don't already have thumbnails. There is also per 1 second watchdog that will close the pool if it is empty (otherwise the child processes hang around). The multiprocessing bits are in a different file so that all the stuff at the top of unity-lens-video doesn't get re-run when child processes are created.

I've tested the patch a little, and it seems to do the right thing.

ProblemType: Bug
DistroRelease: Ubuntu 12.10
Package: unity-lens-video 0.3.6-0ubuntu2 [modified: usr/lib/unity-lens-video/unity-lens-video]
ProcVersionSignature: Ubuntu 3.5.0-5.5-generic 3.5.0-rc7
Uname: Linux 3.5.0-5-generic x86_64
ApportVersion: 2.4-0ubuntu3
Architecture: amd64
Date: Sat Jul 21 10:24:17 2012
InstallationMedia: Ubuntu 12.10 "Quantal Quetzal" - Alpha amd64 (20120606.2)
PackageArchitecture: all
ProcEnviron:
 LANGUAGE=en_AU:en
 TERM=xterm
 PATH=(custom, no user)
 LANG=en_AU.UTF-8
 SHELL=/bin/bash
SourcePackage: unity-lens-video
UpgradeStatus: No upgrade log present (probably fresh install)

Revision history for this message
Michael Blennerhassett (mjblenner) wrote :
Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "thumb.patch" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-reviewers team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

tags: added: patch
Revision history for this message
Michael Blennerhassett (mjblenner) wrote :

This patch is the same thing, but without the extra file. python multiprocessing is a bit better behaved on linux than I expected.

Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in unity-lens-video (Ubuntu):
status: New → Confirmed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.