Ubuntu
unity-lens-shopping package

[UIFe] Display category emblems on results

Bug #1056901 reported by Michal Hruby
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
unity-lens-shopping
Fix Committed
High
Michal Hruby
unity-lens-shopping 7.0.0
6.0
New
Undecided
Unassigned
unity-lens-shopping 6.12.0 "SRU-1"
unity-lens-shopping (Ubuntu)
Triaged
Medium
Unassigned
Ubuntu quantal-updates

Bug Description

== Proposed Change ==

Make sure results from the shopping lens show also the category emblem (the tiny icon on the right part of the price ribbon), similarly to the "More suggestions" categories in apps / music / video lens.

== Test ==

This is mostly visual change, the lens is using the same infrastructure as the other lenses which already display the emblems.

== Contingency? ==

Reverting the change is trivial by reverting the single commit to shopping lens that added it.

Attaching before and after screenshots.

See original description

Related branches

lp://staging/~mhr3/unity-lens-shopping/use-proper-emblems
Paweł Stołowski (community): Approve
Diff: 64 lines (+36/-4)
2 files modified
src/scope.vala (+23/-4)
tests/manual-tests/shopping-lens-tests.txt (+13/-0)
lp://staging/~sil2100/unity-lens-shopping/ubuntu_6.8.0 (Merged)
Revision history for this message
Michal Hruby (mhr3) wrote :
Revision history for this message
Michal Hruby (mhr3) wrote :
Changed in unity-lens-shopping:
status: New → In Progress
importance: Undecided → High
assignee: nobody → Michal Hruby (mhr3)
Michal Hruby (mhr3)
description: updated
Revision history for this message
Jeremy Bícha (jbicha) wrote :

Where does the icon for "Death Comes to Pemberley" come from? Why is it different than the others which are just using lens icons (with the exception of the shopping bag)?

Revision history for this message
Scott Kitterman (kitterman) wrote :

This is non-critical (although I understand desirable). I think it's too late for non-critical. We should focus on landing the critical changes like the online search privacy change and the shopping switch to https. Nack from me.

Revision history for this message
Alan Pope 🍺🐧🐱 🦄 (popey) wrote :

@Jeremy. It's a book, so the emblem is a book. The others are tangible goods like the Webcam & Roku (shopping bag) and Music (note icon)

Revision history for this message
Alan Pope 🍺🐧🐱 🦄 (popey) wrote :

Just to be clear, the emblems are already in Ubuntu. Searching for music in the music lens shows the musical note emblem and searching in the video lens shows them too. This bug is to fix a visual inconsistency between those lenses and the new shopping lens surfaced in the dash.

Without this fix there will be a mixture of results (books, tangible goods, music, videos) in the dash which the user will be unable to differentiate until they click through. So this bug fixes that inconsistency.

Revision history for this message
Jeremy Bícha (jbicha) wrote :

The point I was making is that I don't think anything else uses the book icon.

Revision history for this message
Mark Shuttleworth (sabdfl) wrote :

Let's address this post-release. Critical bugs are the focus now.

Revision history for this message
Scott Kitterman (kitterman) wrote :

Bug status updated based on sabdfl's comment.

Changed in unity-lens-shopping (Ubuntu):
milestone: none → quantal-updates
importance: Undecided → Medium
Łukasz Zemczak (sil2100)
Changed in unity-lens-shopping:
milestone: none → 6.8.0
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package unity-lens-shopping - 6.8.0-0ubuntu1

---------------
unity-lens-shopping (6.8.0-0ubuntu1) quantal-proposed; urgency=low

  [ Łukasz 'sil2100' Zemczak ]
  * New upstream release.
    - Use music lens details page for music store results (LP: #1055684)
    - No easy way to disable online-fetched results in lenses (LP: #1054746)
    - Display category emblems on results (LP: #1056901)
    - Descriptions are missing all html tags (LP: #1058197)

  [ Didier Roche ]
  * debian/control:
    - bump libunity build-dep
 -- Didier Roche <email address hidden> Thu, 04 Oct 2012 16:46:32 +0200

Changed in unity-lens-shopping (Ubuntu):
status: New → Fix Released
Timo Jyrinki (timo-jyrinki)
Changed in unity-lens-shopping:
status: In Progress → Fix Released
Michal Hruby (mhr3)
Changed in unity-lens-shopping:
milestone: 6.8.0 → 7.0.0
status: Fix Released → Fix Committed
Changed in unity-lens-shopping (Ubuntu):
status: Fix Released → Triaged
Revision history for this message
Michal Hruby (mhr3) wrote :

The janitor comment here isn't correct, this didn't make its way to quantal yet. I updated the statuses.

Revision history for this message
Scott Kitterman (kitterman) wrote :

This will need to be done post-release, if at all for quantal. Unsubscribing the release team and adding SRU team.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.