lens privacy feature does not work on all lenses

I could easily make the lens do nothing if the dconf key com/canonical/unity/lenses/remote-content-search is set to 'none' I suppose. Although I'm not sure if that key should apply to third-party lenses that don't do any local searches, and aren't shown in the home lens. If people disagree and think I should implement it, I'd be happy to

The fix should not require extra work from third-party developers.

That is a very fair question and I have no idea what the answer is to it. I think the way the flag is worded a user would have an expectation that remote searching lenses would stop working - especially as it does currently apply to the default lenses when searching in the home lens or in the specific lens, and other lenses such as the loco portal lens stop working when the flag is set. Maybe we could get some design input as to what the expected behaviour should be.

Adolfo, that is not possible, lenses and scopes are independent processes that can perform whatever actions they want. There is no way for the Dash code to restrict their access to the network.

Pushed the fix to scopes-packagers/ppa. It will hopefully go through the ARB quickly and get into extras repo

@Michael Hall:

Perhaps it should be a requirement that lenses and scopes have a string that checks Privacy setting to see if it is disabled and if it is then nothing over the wire. This seems like a reasonable requirement that the Development Community can offer as a specification or best practice and if its not followed it would have no chance of being shipped as a default lenses/scope?

the setting has changed in 13.10, it is now a declarative part of the .scope file. Online searching lenses have to declare themselves as being online lenses by using the RemoteContent=true flag in the .scope file. If that is set then those lenses won't be queried when the privacy flag is set. This is now documented in the tutorial.
http://developer.ubuntu.com/scopes/tutorial/
Please note that the default is false which is bug 1250134 so that a lens author who does not include that line will automatically be assumed to be a local lens and will be queried when the flag is set to local results only - so by default online lenses will still ignore the flag - but it is now declarative and external to the code of the lens, so this bug is fixed in Saucy.