| 2020-05-09 17:41:36 |
Balint Reczey |
bug |
|
|
added bug |
| 2020-05-09 17:44:09 |
Balint Reczey |
bug watch added |
|
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=958883 |
|
| 2020-05-09 17:44:09 |
Balint Reczey |
bug task added |
|
unattended-upgrades (Debian) |
|
| 2020-05-10 00:21:02 |
Bug Watch Updater |
unattended-upgrades (Debian): status |
Unknown |
Confirmed |
|
| 2020-05-11 13:50:32 |
Balint Reczey |
description |
TODO |
[Impact]
* Unattended-upgrades consumes excessive amount of CPU when rewinding cache trying to mark packages to upgrade or install even when they are already marked to be upgraded or installed. This can be triggered by packages held back.
[Test Case]
* Run test_rewind.py:
-Fixed output:
$ python3 test_rewind.py
INFO:root:Allowed origins are: o=Ubuntu,a=lucid-security
INFO:root:Initial blacklist: ant-doc
INFO:root:Initial whitelist (not strict):
DEBUG:root:Marking not allowed <apt_pkg.PackageFile object: filename:'/home/rbalint/projects/deb/unattended-upgrades/test/root.rewind/var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_lucid-updates_main_binary-amd64_Packages' a=lucid-updates,c=main,v=10.04,o=Ubuntu,l=Ubuntu arch='amd64' site='archive.ubuntu.com' IndexType='Debian Package Index' Size=894 ID:0> with -32768 pin
DEBUG:root:Applying pinning: PkgFilePin(id=0, priority=-32768)
DEBUG:root:Applying pin -32768 to package_file: <apt_pkg.PackageFile object: filename:'/home/rbalint/projects/deb/unattended-upgrades/test/root.rewind/var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_lucid-updates_main_binary-amd64_Packages' a=lucid-updates,c=main,v=10.04,o=Ubuntu,l=Ubuntu arch='amd64' site='archive.ubuntu.com' IndexType='Debian Package Index' Size=894 ID:0>
DEBUG:root:Applying pinning: PkgPin(pkg='/^ant-doc/', priority=-32768)
DEBUG:root:APT::VersionedKernelPackages is not set
DEBUG:root:adjusting candidate version: test-package=2.0
DEBUG:root:adjusting candidate version: test2-package=2.0
DEBUG:root:falling back to adjusting test2-package's dependencies
DEBUG:root:falling back to adjusting z-package's dependencies
DEBUG:root:sanity check failed for: set() : no package is selected to be upgraded or installed
.
----------------------------------------------------------------------
Ran 1 test in 0.022s
OK
- Not fixed output:
$ python3 test_rewind.py
INFO:root:Allowed origins are: o=Ubuntu,a=lucid-security
INFO:root:Initial blacklist: ant-doc
INFO:root:Initial whitelist (not strict):
DEBUG:root:Marking not allowed <apt_pkg.PackageFile object: filename:'/home/rbalint/projects/deb/unattended-upgrades/test/root.rewind/var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_lucid-updates_main_binary-amd64_Packages' a=lucid-updates,c=main,v=10.04,o=Ubuntu,l=Ubuntu arch='amd64' site='archive.ubuntu.com' IndexType='Debian Package Index' Size=894 ID:0> with -32768 pin
DEBUG:root:Applying pinning: PkgFilePin(id=0, priority=-32768)
DEBUG:root:Applying pin -32768 to package_file: <apt_pkg.PackageFile object: filename:'/home/rbalint/projects/deb/unattended-upgrades/test/root.rewind/var/lib/apt/lists/archive.ubuntu.com_ubuntu_dists_lucid-updates_main_binary-amd64_Packages' a=lucid-updates,c=main,v=10.04,o=Ubuntu,l=Ubuntu arch='amd64' site='archive.ubuntu.com' IndexType='Debian Package Index' Size=894 ID:0>
DEBUG:root:Applying pinning: PkgPin(pkg='/^ant-doc/', priority=-32768)
DEBUG:root:APT::VersionedKernelPackages is not set
DEBUG:root:adjusting candidate version: test-package=2.0
DEBUG:root:adjusting candidate version: test2-package=2.0
DEBUG:root:falling back to adjusting test2-package's dependencies
DEBUG:root:falling back to adjusting z-package's dependencies
DEBUG:root:sanity check failed for: set() : no package is selected to be upgraded or installed
DEBUG:root:falling back to adjusting test-package's dependencies
DEBUG:root:falling back to adjusting test2-package's dependencies
DEBUG:root:falling back to adjusting test3-package's dependencies
DEBUG:root:falling back to adjusting test-package's dependencies
DEBUG:root:falling back to adjusting test2-package's dependencies
DEBUG:root:falling back to adjusting test3-package's dependencies
.
----------------------------------------------------------------------
Ran 1 test in 0.024s
(Note the extra "DEBUG:root:falling back to adjusting" ... lines)
[Regression Potential]
* Minimal. The very small change fixes how call_checked() verifies that the package to be upgrades/installed is indeed marked to either being installed or upgraded.
In the worst case, if call_checked() erroneously returns success for a package as a result of a regression, unattended-upgrades does not fall back to adjusting packages to make marking successful. Later unattended-upgrades finds out that the package could not be marked and should be treated as kept back. |
|
| 2020-05-12 02:13:54 |
Bug Watch Updater |
unattended-upgrades (Debian): status |
Confirmed |
Fix Released |
|
| 2020-05-12 19:54:38 |
Launchpad Janitor |
unattended-upgrades (Ubuntu): status |
In Progress |
Fix Released |
|
| 2020-07-21 13:02:45 |
Balint Reczey |
nominated for series |
|
Ubuntu Focal |
|
| 2020-07-21 13:02:45 |
Balint Reczey |
bug task added |
|
unattended-upgrades (Ubuntu Focal) |
|
| 2020-07-22 15:40:41 |
Brian Murray |
unattended-upgrades (Ubuntu Focal): status |
New |
Fix Committed |
|
| 2020-07-22 15:40:43 |
Brian Murray |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2020-07-22 15:40:45 |
Brian Murray |
bug |
|
|
added subscriber SRU Verification |
| 2020-07-22 15:40:49 |
Brian Murray |
tags |
|
verification-needed verification-needed-focal |
|
| 2020-07-31 17:06:43 |
Balint Reczey |
tags |
verification-needed verification-needed-focal |
verification-done verification-done-focal |
|
| 2020-08-10 13:10:58 |
Launchpad Janitor |
unattended-upgrades (Ubuntu Focal): status |
Fix Committed |
Fix Released |
|
| 2020-08-10 13:11:01 |
Łukasz Zemczak |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
| 2021-04-03 09:56:59 |
ali |
information type |
Public |
Public Security |
|
| 2021-04-03 09:57:07 |
ali |
information type |
Public Security |
Public |
|
