Activity log for bug #1781176

Date Who What changed Old value New value Message
2018-07-11 10:01:16 Balint Reczey bug added bug
2018-07-11 10:01:34 Balint Reczey bug watch added https://github.com/mvo5/unattended-upgrades/issues/116
2018-07-11 10:01:34 Balint Reczey bug task added unattended-upgrades
2018-07-11 10:38:29 Bug Watch Updater unattended-upgrades: status Unknown Fix Released
2018-07-12 13:00:10 Łukasz Zemczak unattended-upgrades (Ubuntu): status New Fix Released
2018-07-12 13:01:33 Łukasz Zemczak unattended-upgrades (Ubuntu Bionic): status New Fix Committed
2018-07-12 13:01:34 Łukasz Zemczak bug added subscriber Ubuntu Stable Release Updates Team
2018-07-12 13:01:35 Łukasz Zemczak bug added subscriber SRU Verification
2018-07-12 13:01:37 Łukasz Zemczak tags verification-needed verification-needed-bionic
2018-07-18 23:40:36 Balint Reczey description [Impact] * Reports from u-u incorrectly list packages from non-upgradable origins as "Packages with upgradable origin but kept back" * The incorrectly the packages incorrectly is a result of is_pkgname_in_blacklist() having a side effect and removing the side effect is part of fixing LP: #1396787 which fix is also being SRU-d. * The fix is removing the side effect of is_pkgname_in_blacklist() [Test Case] * There is a build-time test in test/test_blacklisted_wrong_origin.py * TODO copy test case here from GitHub report [Regression Potential] * Regressions may make packages incorrectly missing from u-u's report, but the autopkgtests also cover that to some extent. [Other Info] * Original report: https://github.com/mvo5/unattended-upgrades/issues/116 [Impact]  * Reports from u-u incorrectly list packages from non-upgradable origins as "Packages with upgradable origin but kept back"  * The incorrectly the packages incorrectly is a result of is_pkgname_in_blacklist() having a side effect and removing the side effect is part of fixing LP: #1396787 which fix is also being SRU-d.  * The fix is removing the side effect of is_pkgname_in_blacklist() [Test Case]  * There is a build-time test in test/test_blacklisted_wrong_origin.py  * To reproduce the original problem set up a system where all security updates are installed but ebtables (from bionic-updates) is not updated: $ sudo unattended-upgrade --verbose Initial blacklisted packages: Initial whitelisted packages: Starting unattended upgrades script Allowed origins are: o=Ubuntu,a=bionic, o=Ubuntu,a=bionic-security, o=UbuntuESM,a=bionic No packages found that can be upgraded unattended and no pending auto-removals $ sudo apt upgrade Reading package lists... Done Building dependency tree Reading state information... Done Calculating upgrade... Done The following packages will be upgraded: apt apt-utils ebtables initramfs-tools initramfs-tools-bin initramfs-tools-core libapt-inst2.0 libapt-pkg5.0 liblxc-common liblxc1 libpython3-stdlib lxcfs lxd lxd-client netplan.io networkd-dispatcher nplan python-apt-common python3 python3-apt python3-minimal python3-update-manager snapd squashfs-tools unattended-upgrades update-manager-core update-notifier-common 27 upgraded, 0 newly installed, 0 to remove and 0 not upgraded. Need to get 24.1 MB of archives. After this operation, 1454 kB of additional disk space will be used. Do you want to continue? [Y/n] n Abort. * blacklist ebtables, set up emails from u-u, then run u-u again: $ sudo echo 'Unattended-Upgrade::Package-Blacklist {"ebtables";};' > /etc/apt/apt.conf.d/51unattended-upgrades-blacklist-ebtables $ sudo echo 'Unattended-Upgrade::Mail "root";' > /etc/apt/apt.conf.d/51unattended-upgrades-mail $ sudo unattended-upgrade --verbose Initial blacklisted packages: ebtables Initial whitelisted packages: Starting unattended upgrades script Allowed origins are: o=Ubuntu,a=bionic, o=Ubuntu,a=bionic-security, o=UbuntuESM,a=bionic Packages that will be upgraded: * Observe ebtables listed as being kept back and having upgradable origin with buggy u-u: $ sudo cat /var/mail/mail ... Packages with upgradable origin but kept back: ebtables=20 ... * Upgrade u-u to a fixed version and run it, observing ebtables to be not listed as having upgradable origin [Regression Potential]  * Regressions may make packages incorrectly missing from u-u's report, but the autopkgtests also cover that to some extent. [Other Info]  * Original report: https://github.com/mvo5/unattended-upgrades/issues/116
2018-07-18 23:55:27 Balint Reczey tags verification-needed verification-needed-bionic verification-failed verification-failed-bionic
2018-07-19 00:01:02 Balint Reczey unattended-upgrades (Ubuntu Bionic): status Fix Committed In Progress
2018-07-19 00:01:08 Balint Reczey unattended-upgrades (Ubuntu Bionic): assignee Balint Reczey (rbalint)
2018-07-19 00:02:46 Balint Reczey description [Impact]  * Reports from u-u incorrectly list packages from non-upgradable origins as "Packages with upgradable origin but kept back"  * The incorrectly the packages incorrectly is a result of is_pkgname_in_blacklist() having a side effect and removing the side effect is part of fixing LP: #1396787 which fix is also being SRU-d.  * The fix is removing the side effect of is_pkgname_in_blacklist() [Test Case]  * There is a build-time test in test/test_blacklisted_wrong_origin.py  * To reproduce the original problem set up a system where all security updates are installed but ebtables (from bionic-updates) is not updated: $ sudo unattended-upgrade --verbose Initial blacklisted packages: Initial whitelisted packages: Starting unattended upgrades script Allowed origins are: o=Ubuntu,a=bionic, o=Ubuntu,a=bionic-security, o=UbuntuESM,a=bionic No packages found that can be upgraded unattended and no pending auto-removals $ sudo apt upgrade Reading package lists... Done Building dependency tree Reading state information... Done Calculating upgrade... Done The following packages will be upgraded: apt apt-utils ebtables initramfs-tools initramfs-tools-bin initramfs-tools-core libapt-inst2.0 libapt-pkg5.0 liblxc-common liblxc1 libpython3-stdlib lxcfs lxd lxd-client netplan.io networkd-dispatcher nplan python-apt-common python3 python3-apt python3-minimal python3-update-manager snapd squashfs-tools unattended-upgrades update-manager-core update-notifier-common 27 upgraded, 0 newly installed, 0 to remove and 0 not upgraded. Need to get 24.1 MB of archives. After this operation, 1454 kB of additional disk space will be used. Do you want to continue? [Y/n] n Abort. * blacklist ebtables, set up emails from u-u, then run u-u again: $ sudo echo 'Unattended-Upgrade::Package-Blacklist {"ebtables";};' > /etc/apt/apt.conf.d/51unattended-upgrades-blacklist-ebtables $ sudo echo 'Unattended-Upgrade::Mail "root";' > /etc/apt/apt.conf.d/51unattended-upgrades-mail $ sudo unattended-upgrade --verbose Initial blacklisted packages: ebtables Initial whitelisted packages: Starting unattended upgrades script Allowed origins are: o=Ubuntu,a=bionic, o=Ubuntu,a=bionic-security, o=UbuntuESM,a=bionic Packages that will be upgraded: * Observe ebtables listed as being kept back and having upgradable origin with buggy u-u: $ sudo cat /var/mail/mail ... Packages with upgradable origin but kept back: ebtables=20 ... * Upgrade u-u to a fixed version and run it, observing ebtables to be not listed as having upgradable origin [Regression Potential]  * Regressions may make packages incorrectly missing from u-u's report, but the autopkgtests also cover that to some extent. [Other Info]  * Original report: https://github.com/mvo5/unattended-upgrades/issues/116 [Impact]  * Reports from u-u incorrectly list packages from non-upgradable origins as "Packages with upgradable origin but kept back"  * Listing the packages incorrectly is a result of is_pkgname_in_blacklist() having a side effect and removing the side effect is part of fixing LP: #1396787 which fix is also being SRU-d.  * The fix is removing the side effect of is_pkgname_in_blacklist() [Test Case]  * There is a build-time test in test/test_blacklisted_wrong_origin.py  * To reproduce the original problem set up a system where all security updates are installed but ebtables (from bionic-updates) is not updated: $ sudo unattended-upgrade --verbose Initial blacklisted packages: Initial whitelisted packages: Starting unattended upgrades script Allowed origins are: o=Ubuntu,a=bionic, o=Ubuntu,a=bionic-security, o=UbuntuESM,a=bionic No packages found that can be upgraded unattended and no pending auto-removals $ sudo apt upgrade Reading package lists... Done Building dependency tree Reading state information... Done Calculating upgrade... Done The following packages will be upgraded:   apt apt-utils ebtables initramfs-tools initramfs-tools-bin initramfs-tools-core libapt-inst2.0 libapt-pkg5.0   liblxc-common liblxc1 libpython3-stdlib lxcfs lxd lxd-client netplan.io networkd-dispatcher nplan   python-apt-common python3 python3-apt python3-minimal python3-update-manager snapd squashfs-tools   unattended-upgrades update-manager-core update-notifier-common 27 upgraded, 0 newly installed, 0 to remove and 0 not upgraded. Need to get 24.1 MB of archives. After this operation, 1454 kB of additional disk space will be used. Do you want to continue? [Y/n] n Abort. * blacklist ebtables, set up emails from u-u, then run u-u again: $ sudo echo 'Unattended-Upgrade::Package-Blacklist {"ebtables";};' > /etc/apt/apt.conf.d/51unattended-upgrades-blacklist-ebtables $ sudo echo 'Unattended-Upgrade::Mail "root";' > /etc/apt/apt.conf.d/51unattended-upgrades-mail $ sudo unattended-upgrade --verbose Initial blacklisted packages: ebtables Initial whitelisted packages: Starting unattended upgrades script Allowed origins are: o=Ubuntu,a=bionic, o=Ubuntu,a=bionic-security, o=UbuntuESM,a=bionic Packages that will be upgraded: * Observe ebtables listed as being kept back and having upgradable origin with buggy u-u: $ sudo cat /var/mail/mail ... Packages with upgradable origin but kept back:  ebtables=20 ... * Upgrade u-u to a fixed version and run it, observing ebtables to be not listed as having upgradable origin [Regression Potential]  * Regressions may make packages incorrectly missing from u-u's report, but the autopkgtests also cover that to some extent. [Other Info]  * Original report: https://github.com/mvo5/unattended-upgrades/issues/116
2018-07-19 09:31:24 Balint Reczey unattended-upgrades (Ubuntu): status Fix Released In Progress
2018-07-19 09:45:34 Launchpad Janitor unattended-upgrades (Ubuntu Bionic): status In Progress Fix Released
2018-07-19 09:45:54 Łukasz Zemczak removed subscriber Ubuntu Stable Release Updates Team
2018-08-28 15:50:32 Launchpad Janitor unattended-upgrades (Ubuntu): status In Progress Fix Released
2018-12-03 17:26:21 Brian Murray nominated for series Ubuntu Xenial
2018-12-03 17:26:21 Brian Murray bug task added unattended-upgrades (Ubuntu Xenial)
2018-12-03 19:19:48 Brian Murray unattended-upgrades (Ubuntu Xenial): status New Fix Committed
2018-12-03 19:19:51 Brian Murray bug added subscriber Ubuntu Stable Release Updates Team
2018-12-03 19:19:55 Brian Murray tags verification-failed verification-failed-bionic verification-failed-bionic verification-needed verification-needed-xenial
2019-02-07 14:39:07 Balint Reczey tags verification-failed-bionic verification-needed verification-needed-xenial verification-failed verification-failed-bionic verification-failed-xenial
2019-02-07 14:42:17 Balint Reczey unattended-upgrades (Ubuntu Bionic): status Fix Released Confirmed
2019-02-11 08:32:51 Balint Reczey unattended-upgrades (Ubuntu Xenial): status Fix Committed In Progress
2019-02-12 13:35:37 Francis Ginther tags verification-failed verification-failed-bionic verification-failed-xenial id-5c5c4493f028f40f2e8867c3 verification-failed verification-failed-bionic verification-failed-xenial
2019-02-21 17:30:45 Łukasz Zemczak unattended-upgrades (Ubuntu Bionic): status Confirmed Fix Committed
2019-02-21 17:30:50 Łukasz Zemczak tags id-5c5c4493f028f40f2e8867c3 verification-failed verification-failed-bionic verification-failed-xenial id-5c5c4493f028f40f2e8867c3 verification-failed-xenial verification-needed verification-needed-bionic
2019-02-22 13:48:02 Balint Reczey tags id-5c5c4493f028f40f2e8867c3 verification-failed-xenial verification-needed verification-needed-bionic id-5c5c4493f028f40f2e8867c3 verification-done-bionic verification-failed-xenial verification-needed
2019-02-28 13:00:23 Łukasz Zemczak unattended-upgrades (Ubuntu Xenial): status In Progress Fix Committed
2019-02-28 13:00:28 Łukasz Zemczak tags id-5c5c4493f028f40f2e8867c3 verification-done-bionic verification-failed-xenial verification-needed id-5c5c4493f028f40f2e8867c3 verification-done-bionic verification-needed verification-needed-xenial
2019-02-28 13:20:51 Launchpad Janitor unattended-upgrades (Ubuntu Bionic): status Fix Committed Fix Released
2019-04-05 16:21:57 Balint Reczey tags id-5c5c4493f028f40f2e8867c3 verification-done-bionic verification-needed verification-needed-xenial id-5c5c4493f028f40f2e8867c3 verification-done verification-done-bionic verification-done-xenial
2019-04-25 10:50:00 Launchpad Janitor unattended-upgrades (Ubuntu Xenial): status Fix Committed Fix Released